| Age | Commit message (Collapse) | Author |
|---|
|
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
|
|
Conflicts:
modules/akismet/views/admin_akismet.html.php
modules/comment/helpers/comment_rss.php
modules/gallery/helpers/gallery_rss.php
modules/gallery/libraries/I18n.php
modules/gallery/views/permissions_browse.html.php
modules/gallery/views/simple_uploader.html.php
modules/info/views/info_block.html.php
modules/organize/controllers/organize.php
modules/organize/views/organize.html.php
modules/organize/views/organize_album.html.php
themes/default/views/album.html.php
themes/default/views/movie.html.php
themes/default/views/photo.html.php
|
|
SafeString::purify().
Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
|
|
Refactoring of Xss_Security_Test.
t() and t2() return a SafeString instance.
TODO:
- Update all code to use SafeString where appropriate.
- Update golden fole of Xss_Security_Test
- Stop reporting CLEAN vars in Xss_Security_Test
|
|
gallery_dialog respectively
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
made in dbeadc1407293d0c7af36723db6fe5699890b845
|
|
don't break encapsulation. In the logout controller, don't run the
url through url::redirect because that uses url::site(). Just set the
Location header directly.
This fixes ticket #483.
|
|
|
|
uses the full name if there is one, or falls back to the name if
that's all we have.
|
|
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
$theme->theme_script().
|
|
|
|
functions that format a unix timestamp into a date+time/date/time
string.
Partial fix for ticket #347.
Signed-off-by: <unostar@danalan.info>
|
|
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
|
|
* added drag & drop help message for empty groups
* fixed overflow issue with more than ~10 members in one group
* CSS improvements
|
|
|
|
when group is refreshed.
|
|
|
|
toggle, and forms to external files.
|
|
|
|
|
|
|
|
|
|
use this as the default instead of id. This prepares the way for
manual reordering in the organize functionality.
|
|
directly wherever possible instead of access::csrf_token().
|
|
|
|
FullName"
|
|
|
|
We now have two clear and separate login approaches:
login/ajax
login/html
Choose the one that's appropriate. Totally simplified the maintenance
page to be separate from the theme and dead simple, and use login/html
approach there. Totally simplified the top level login
(login_page.html.php) to just be a login page, not the rest of the
chrome on the page and use the login/ajax approach there.
Don't use access::required in albums and then catch the exception,
instead use access::can and check the return code.
Improve the text for maintenance mode.
|
|
as the Modify profile and logout links.
|
|
draggable user. Also, drag the icon and name not just the icon.
|
|
|
|
buttons, buttons!
|
|
|
|
icon doesn't appear within the button outline with buttons that aren't floated. Will have to debug later.
|
|
user/group buttons and search form on search results page.
|
|
can start to logon, request the password to be reset, and an email is
sent to the users email address. If you click on the link you get an
unformatted form. But its a start :-)
|
|
user email address to list.
|
|
not list. Apply cursor: move to jQuery UI draggable and sortable. Clean up admin table styles a bit.
|
|
|
|
|
|
users to groups.
|
|
a work in progress but it actually works mostly.
|
|
|
|
|
|
it unique, changed gFirstRow to gHeaderRow to make more semantically meaningful. Fixed closing span that I broke after Bharat fixed it last night.
|
|
into a single set of reusable classes. Applied alternating row bg colors. Removed inline CSS from admin views. Moved user admin css into admin_default theme style sheet.
|
