| Age | Commit message (Collapse) | Author |
|---|
|
|
|
files out in a separate model for scalability. Removed the "pause"
functionality.
- Server_Add_Controller extends Admin_Controller so that we don't have
to check for admin every time.
- Task completion time now factors in the time it takes to walk the
arbitrarily deep trees
- Moved checkbox management entirely into JS using jQuery
- Simplified the JS considerably
|
|
Conflicts:
modules/server_add/controllers/admin_server_add.php
|
|
|
|
parent itself, otherwise in the code we'll add the entire parent since if
we find an album as a leaf, we assume that it's never been expanded in the UI.
|
|
|
|
|
|
|
|
I've redone the browsing code but I have not implemented the adding
code.
1) Rename index() to browse() since index is too generic.
2) Simplify the data that we pass to _dialog and _tree
3) Change _tree to return list items only, so that the outer dialog
can be a <ul> for consistency.
4) Simplify the data structures so that we're not tracking checked vs.
unchecked status in the PHP code, it's all done in jquery where we
can do it with just a line or two of JS
5) use glob() which pretty much entirely replaces _get_children
|
|
making API calls on the item.
|
|
|
|
|
|
using the checklist in ticket #385.
|
|
|
|
|
|
|
|
|
|
Add xxx_installer::upgrade($version) method so that upgrade stanzas
are separate from install stanzas. In the old code, to do an upgrade
meant that you had to re-evolve everything from the initial install
because we'd step through each version's changes. But what we really
want is for the initial install to start off in the perfect initial
state, and the upgrades to do the work behind the scenes. So now the
install() function gets things set up properly the first time, and the
upgrade() function does any work to catch you up to the latest code.
See gallery_installer.php for a good example.
|
|
uploader works.
|
|
the branch was never opened on the client. This should fix some of the issues
with the server_add as I was able to select the staging directory and then add
over 400 images in a multi-tier structure.
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
|
|
is opened. Sub trees re only retrieved when the branch is opened. Changed the
start task processing to fill in any subtrees that are selected, but were never expanded on the client. Added the loading icon.
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
|
|
to make it a little more robust.
|
|
* open for suggestions on the submenu item labels
* @bharat: not sure about the add photos menu item id in the dropdown case
|
|
make "Add from Server" a 2nd option there.
This requires adding the Menu::remove() API function.
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
|
|
Install: <module>_installer::install() is called, any necessary tables
are created.
Activate: <module>_installer::activate() is called. Module
controllers are routable, helpers are accessible, etc. The module is
in use.
Deactivate: <module>_installer::deactivate() is called. Module code
is not accessible or routable. Module is *not* in use, but its tables
are still around.
Uninstall: <module>_installer::uninstall() is called. Module is
completely removed from the database.
Admin > Modules will install and activate modules, but will only
deactivate (will NOT uninstall modules).
|
|
|
|
|
|
when adding photos/movies/albums
|
|
|
|
|
|
|
|
|
|
if there are no eligible files selected
2) Change the javascript to handle this condition and show a pop up
|
|
|
|
|
|
optional parameter/
|
|
files to be uploaded from it.
|
|
1) Fixes Ticket #208
2) Fixes Ticket #190
3) Fixes an unticketed issue where two items could collide when
creating the thumbnail and/or resize. For example, loading a.flv and
a.jpg would have generated the same thumbnail image. This change adds
a random value to the name to avoid conflicts.
4) Added item::__set() to clear the relative path if the name changes
|
|
errors that are described in ticket #208.
|
|
longer admin/server_add but admin/server_add/add_path and the equality
check fails.
|
|
directly wherever possible instead of access::csrf_token().
|
|
does not provide a sort order. Separate the directory and files, sort
them individually and then merge them together so directories are at
the top of the list
|
|
completed.
|
|
the upload is paused. If the dialog is closed and the task is not
complete then a warning message is displayed on the album.
|
|
uploader. This is modeled on
http://codex.gallery2.org/Gallery3:Upload_UX but is not yet complete.
Notes:
* Changed #gProgressBar to .gProgressBar to support multiple progress
bars on the same page
* Added a bunch of CSS to the "needs a home" section in
themes/default/css/screen.css
|
|
|
