| Age | Commit message (Collapse) | Author |
|---|
|
add form. Created a server_add.css file.
|
|
plugin. Dropped gallery.form.js. Applied short forms to server_add and tag admin pages. Added tag.css to admin views. Added .g-wide {}.
|
|
|
|
shared images from wind to lib. Deleted unused images in the admin_wind. This will likely break a few ajax features.
|
|
add the contents of the staging directlyinto the album that server_add was invoked from. Fixes ticket #785
|
|
|
|
|
|
more details.
|
|
Conflicts:
modules/akismet/views/admin_akismet.html.php
modules/comment/helpers/comment_rss.php
modules/gallery/helpers/gallery_rss.php
modules/gallery/libraries/I18n.php
modules/gallery/views/permissions_browse.html.php
modules/gallery/views/simple_uploader.html.php
modules/info/views/info_block.html.php
modules/organize/controllers/organize.php
modules/organize/views/organize.html.php
modules/organize/views/organize_album.html.php
themes/default/views/album.html.php
themes/default/views/movie.html.php
themes/default/views/photo.html.php
|
|
SafeString::purify().
Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
|
|
a BMP masquerading as a .jpg causing us to be unable to rebuild
resizes and thumbnails. Now if that happens, we discard the file, log
it and move on.
|
|
|
|
This fixes ticket #546
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
|
|
Now we don't have checkboxes, but instead we restrict you to selecting
directories and albums from only one level in the hierarchy. This
makes it easier for us to make sure that we properly create the
hierarchy that you want and avoid confusion about what's going to wind
up where.
Modify Server_Add_File_Model to have a parent_id and item_id and then
modify them as we go so that we can build up a tree structure there
*before* we create any items. This makes it much easier to figure out
where a new item is going to go and get rid of a bunch of probably
buggy code in the main task.
|
|
|
|
adding a new album or photo.
Simplify the data structure that we pass down to
server_add_tree.html.php so that we just pass a file list and let it
do whatever it wants with it.
|
|
instead of directories and files.
|
|
|
|
files out in a separate model for scalability. Removed the "pause"
functionality.
- Server_Add_Controller extends Admin_Controller so that we don't have
to check for admin every time.
- Task completion time now factors in the time it takes to walk the
arbitrarily deep trees
- Moved checkbox management entirely into JS using jQuery
- Simplified the JS considerably
|
|
Conflicts:
modules/server_add/controllers/admin_server_add.php
|
|
|
|
I've redone the browsing code but I have not implemented the adding
code.
1) Rename index() to browse() since index is too generic.
2) Simplify the data that we pass to _dialog and _tree
3) Change _tree to return list items only, so that the outer dialog
can be a <ul> for consistency.
4) Simplify the data structures so that we're not tracking checked vs.
unchecked status in the PHP code, it's all done in jquery where we
can do it with just a line or two of JS
5) use glob() which pretty much entirely replaces _get_children
|
|
making API calls on the item.
|
|
|
|
using the checklist in ticket #385.
|
|
the branch was never opened on the client. This should fix some of the issues
with the server_add as I was able to select the staging directory and then add
over 400 images in a multi-tier structure.
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
is opened. Sub trees re only retrieved when the branch is opened. Changed the
start task processing to fill in any subtrees that are selected, but were never expanded on the client. Added the loading icon.
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
|
|
|
|
when adding photos/movies/albums
|
|
|
|
|
|
if there are no eligible files selected
2) Change the javascript to handle this condition and show a pop up
|
|
|
|
optional parameter/
|
|
1) Fixes Ticket #208
2) Fixes Ticket #190
3) Fixes an unticketed issue where two items could collide when
creating the thumbnail and/or resize. For example, loading a.flv and
a.jpg would have generated the same thumbnail image. This change adds
a random value to the name to avoid conflicts.
4) Added item::__set() to clear the relative path if the name changes
|
|
longer admin/server_add but admin/server_add/add_path and the equality
check fails.
|
|
does not provide a sort order. Separate the directory and files, sort
them individually and then merge them together so directories are at
the top of the list
|
|
completed.
|
|
the upload is paused. If the dialog is closed and the task is not
complete then a warning message is displayed on the album.
|
|
task::create method call
|
|
#125). Haven't quite figured out what to do with the errors in the
context. Maybe they should show on the mainenance screen?
|
|
|
|
|
|
- Show the "Server Add needs configuration" message whenever
there are no paths.
- Un-ajaxify the admin code to remove complexity and allow us to
update the status message as appropriate.
- Rename server_add_admin.html.php to admin_server_add.html.php
for consistency.
- Fix up form to properly display error messages
- Get rid of server_add_dir_list.html.php now that we're
non-ajaxified.
- Change delete <span> to an <a> for non-ajax world.
|
|
|
|
|
|
for unique identifier as opposed to user id. :-)
|
