summaryrefslogtreecommitdiff
path: root/modules/server_add/controllers/server_add.php
AgeCommit message (Collapse)Author
2009-07-02Merge branch 'master' of git@github.com:/gallery/gallery3Bharat Mediratta
Conflicts: modules/server_add/controllers/admin_server_add.php
2009-07-02Temporary version add() that just dumps out the values for now.Bharat Mediratta
2009-07-02Partial pass of server_add cleanup. It's broken at this stage sinceBharat Mediratta
I've redone the browsing code but I have not implemented the adding code. 1) Rename index() to browse() since index is too generic. 2) Simplify the data that we pass to _dialog and _tree 3) Change _tree to return list items only, so that the outer dialog can be a <ul> for consistency. 4) Simplify the data structures so that we're not tracking checked vs. unchecked status in the PHP code, it's all done in jquery where we can do it with just a line or two of JS 5) use glob() which pretty much entirely replaces _get_children
2009-07-02Eliminate temporary variables by passing the $item into the view andBharat Mediratta
making API calls on the item.
2009-07-01Fix a bunch of XSS vulnerabilities turned up by manual inspectionBharat Mediratta
using the checklist in ticket #385.
2009-06-10Changed how directories are processed when the parent directory is selected andTim Almdal
the branch was never opened on the client. This should fix some of the issues with the server_add as I was able to select the staging directory and then add over 400 images in a multi-tier structure. Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-05Rewrite the server_add to have the server format the selection when a branch ↵Tim Almdal
is opened. Sub trees re only retrieved when the branch is opened. Changed the start task processing to fill in any subtrees that are selected, but were never expanded on the client. Added the loading icon. Signed-off-by: Bharat Mediratta <bharat@menalto.com>
2009-06-01Security pass over all controller code. Mostly adding CSRF checkingBharat Mediratta
and verifying user permissions, but there are several above-the-bar changes: 1) Server add is now only available to admins. This is a hard requirement because we have to limit server access (eg: server_add::children) to a user subset and the current permission model doesn't include that. Easiest fix is to restrict to admins. Got rid of the server_add permission. 2) We now know check permissions at every level, which means in controllers AND in helpers. This "belt and suspenders" approach will give us defense in depth in case we overlook it in one area. 3) We now do CSRF checking in every controller method that changes the code, in addition to the Forge auto-check. Again, defense in depth and it makes scanning the code for security much simpler. 4) Moved Simple_Uploader_Controller::convert_filename_to_title to item:convert_filename_to_title 5) Fixed a bug in sending notification emails. 6) Fixed the Organize code to verify that you only have access to your own tasks. In general, added permission checks to organize which had pretty much no validation code. I did my best to verify every feature that I touched.
2009-05-21Change $view->action to a absolute url.Bharat Mediratta
2009-05-13Gee it's May already. Update copyright to 2009.Bharat Mediratta
2009-05-13Create a new "add" permission and require it at the controller levelBharat Mediratta
when adding photos/movies/albums
2009-05-09Remove quotes and correct typoTim Almdal
2009-05-09Fix for ticket #217Tim Almdal
2009-04-231) Change the processing so the server_add start task can return done = 1Tim Almdal
if there are no eligible files selected 2) Change the javascript to handle this condition and show a pop up
2009-04-09Don't try to import the staging directory as an albumTim Almdal
2009-04-09Create a pause method on the server_add controller and get rid of theTim Almdal
optional parameter/
2009-04-08Fixes issues with Server Add:Tim Almdal
1) Fixes Ticket #208 2) Fixes Ticket #190 3) Fixes an unticketed issue where two items could collide when creating the thumbnail and/or resize. For example, loading a.flv and a.jpg would have generated the same thumbnail image. This change adds a random value to the name to avoid conflicts. 4) Added item::__set() to clear the relative path if the name changes
2009-03-25Fix for ticket #184. Sort the output children as DirectoryIteratorTim Almdal
does not provide a sort order. Separate the directory and files, sort them individually and then merge them together so directories are at the top of the list
2009-03-24Fix the problem I created by trying to run the task again after it was ↵Tim Almdal
completed.
2009-03-24Add a pause button to the server add dialog and if it is clicked thenTim Almdal
the upload is paused. If the dialog is closed and the task is not complete then a warning message is displayed on the album.
2009-03-11Refine the task api but removing the optional parameters on theTim Almdal
task::create method call
2009-03-10Refactor the server add module to make use of the task api (TicketTim Almdal
#125). Haven't quite figured out what to do with the errors in the context. Maybe they should show on the mainenance screen?
2009-03-05Change how the urls are built in the java scriptTim Almdal
2009-03-04Last of changes required from Bharat's 2nd review passTim Almdal
2009-03-04Changed $uid to $tree_id, so not to confuse anyone between and acroynmTim Almdal
for unique identifier as opposed to user id. :-)
2009-03-04Rename local_import module to server_addTim Almdal