gallery3.git - A clone of the Gallery3 code for testing and development.

Age	Commit message (Collapse)	Author
2009-06-01	Security pass over all controller code. Mostly adding CSRF checking	Bharat Mediratta
	and verifying user permissions, but there are several above-the-bar changes: 1) Server add is now only available to admins. This is a hard requirement because we have to limit server access (eg: server_add::children) to a user subset and the current permission model doesn't include that. Easiest fix is to restrict to admins. Got rid of the server_add permission. 2) We now know check permissions at every level, which means in controllers AND in helpers. This "belt and suspenders" approach will give us defense in depth in case we overlook it in one area. 3) We now do CSRF checking in every controller method that changes the code, in addition to the Forge auto-check. Again, defense in depth and it makes scanning the code for security much simpler. 4) Moved Simple_Uploader_Controller::convert_filename_to_title to item:convert_filename_to_title 5) Fixed a bug in sending notification emails. 6) Fixed the Organize code to verify that you only have access to your own tasks. In general, added permission checks to organize which had pretty much no validation code. I did my best to verify every feature that I touched.
2009-05-31	Clear the site status message on deactivate, not on uninstall.	Bharat Mediratta

2009-05-26	Restructure the module lifecycle.	Bharat Mediratta
	Install: <module>_installer::install() is called, any necessary tables are created. Activate: <module>_installer::activate() is called. Module controllers are routable, helpers are accessible, etc. The module is in use. Deactivate: <module>_installer::deactivate() is called. Module code is not accessible or routable. Module is not in use, but its tables are still around. Uninstall: <module>_installer::uninstall() is called. Module is completely removed from the database. Admin > Modules will install and activate modules, but will only deactivate (will NOT uninstall modules).
2009-05-13	Gee it's May already. Update copyright to 2009.	Bharat Mediratta

2009-03-16	Remove unused orig_public_key from the form, it wasn't actually doing ↵	Bharat Mediratta
	anything (and was causing an error).
2009-02-05	Don't try to show the recaptcha if we don't have a public key	Bharat Mediratta

2009-01-30	Correct indentation	Tim Almdal

2009-01-28	Add module name to log::success() calls	Bharat Mediratta

2009-01-28	Simplify the recaptcha admin page. It's not guaranteed to verify your	Bharat Mediratta
	recaptcha private key properly anymore, but it's more intuitive to configure in the admin UI.
2009-01-27	Make the comment -> recaptcha binding happen via an event dispatch as	Bharat Mediratta
	opposed to a direct call.
2009-01-26	Forgot to add the Form_Recaptcha class	Tim Almdal

2009-01-26	Adding Recaptcha to the comment module. Recaptcha integration consists of a ↵	Tim Almdal
	Form_Recaptcha class derived from Form_Input that can be added to any class that requires Recaptcha verfication.
2009-01-25	Removed all the complex code to locate the forms. Now the admin	Tim Almdal
	screen just has the public and private keys and if the public key is provided a recaptcha box shows up which is used to validate the public private key pair.
2009-01-25	Added the ability to identify and present the defined forms to the	Tim Almdal
	adminstrator. The forms are presented as a checklist, I would have preferred a selection list, but Forge doesn't have one. The generated html to contain the recaptcha challenge is defined as <ul> as that was the only way to force itto line up.
2009-01-24	Supply a form id on all forms. This id can be used by modules other	Tim Almdal
	than the originating module to provide additional functionality to the form.
2009-01-23	The adminstration portion of the recaptcha module. I haven't figured out ↵	Tim Almdal
	how to integrate it with the other module forms.