| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
|
|
|
|
|
|
recaptcha private key properly anymore, but it's more intuitive to
configure in the admin UI.
|
|
Form_Recaptcha class derived from Form_Input that can be added to any class that requires Recaptcha verfication.
|
|
screen just has the public and private keys and if the public key is
provided a recaptcha box shows up which is used to validate the public
private key pair.
|
|
adminstrator. The forms are presented as a checklist, I would have
preferred a selection list, but Forge doesn't have one. The generated
html to contain the recaptcha challenge is defined as <ul> as that was
the only way to force itto line up.
|
|
how to integrate it with the other module forms.
|
