| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-01-21 | Exclude modules/gallery_unit_test/views/kohana/error.php | Bharat Mediratta | |
| 2010-01-21 | Fix a minor bad expectation. | Bharat Mediratta | |
| 2010-01-21 | Can't call ORM_MPTT::move_to() externally, so call Item_Model::save() instead. | Bharat Mediratta | |
| 2010-01-21 | Reload the album after adding the photo so that MPTT pointers are correct. | Bharat Mediratta | |
| 2010-01-20 | Whitespace. | Bharat Mediratta | |
| 2010-01-20 | Two fixes: | Bharat Mediratta | |
| 1) Don't call ORM_MPTT::move_to() directly. Use the new model-based-validation approach of changing the parent_id and saving. 2) Item_Model::parent() can return null; check for it. | |||
| 2010-01-20 | Make move_to protected since we don't want folks calling it on | Bharat Mediratta | |
| Item_Model. If there's a need to make this public, we should override it in Item_Model and throw an exception there. | |||
| 2010-01-20 | Remove debug code. | Bharat Mediratta | |
| 2010-01-20 | Oops, bug in save() -- we weren't returning the saved value! | Bharat Mediratta | |
| 2010-01-20 | Delete MY_ORM::original(). We did not have proper containment to | Bharat Mediratta | |
| generate $original when we needed it, resulting in inconsistent behavior. | |||
| 2010-01-20 | Stop using MY_ORM::original(). | Bharat Mediratta | |
| 2010-01-20 | Throw Kohana_Exception instead of Exception on access denied, since that may ↵ | Bharat Mediratta | |
| bubble all the way up | |||
| 2010-01-20 | Stop using MY_ORM::original(). It's got very odd semantics and we are | Bharat Mediratta | |
| not capturing all cases for setting and resetting $original, which leads to some weird and hard to reproduce behavior. Instead, if we need the original just reload it from the database. This may result in a somewhat excessive load in places, but we'll have to fix that in a later optimization pass. | |||
| 2010-01-20 | Throw Rest exceptions, not regular exceptions. | Bharat Mediratta | |
| 2010-01-20 | Forbidden is a 403, not a 503. | Bharat Mediratta | |
| 2010-01-19 | Extend Gallery_Unit_Test_Case instead of Unit_Test_Case. | Bharat Mediratta | |
| 2010-01-19 | Fix some validation checks to check to see if the original was loaded | Bharat Mediratta | |
| before deciding whether or not we changed a value. Change valid_name to be cascading, not parallel. | |||
| 2010-01-19 | Move data initialization into the constructor so that it happens | Bharat Mediratta | |
| before validate() is called, which is important with our two phase web controllers. Make valid_parent smarter about moving existing items, vs new items. | |||
| 2010-01-19 | Change "filename" to "name" in the edit album form. I'd rather have | Bharat Mediratta | |
| consistency between field names than deal with underlying issues with Forge bitching about the "name" property. | |||
| 2010-01-19 | Make video/x-flv a valid movie mime_type | Bharat Mediratta | |
| 2010-01-19 | Change "dirname" to "name" in the edit album form. I'd rather have | Bharat Mediratta | |
| consistency between field names than deal with underlying issues with Forge bitching about the "name" property. | |||
| 2010-01-19 | Use property_exists() on our stdClass instead of array_key_exists() | Bharat Mediratta | |
| 2010-01-19 | Change rest::url() to take a module name and a resource. The module | Bharat Mediratta | |
| does the rest. This function is symmetrical to rest::resolve. | |||
| 2010-01-19 | Rewrite the tests entirely to cover the new REST code. | Bharat Mediratta | |
| 2010-01-19 | Make scope default to direct. | Bharat Mediratta | |
| Add slug to the post params. Fix minor output bug. | |||
| 2010-01-19 | Don't try to set the album cover for the grandparent if we don't have edit ↵ | Bharat Mediratta | |
| permissions for it. | |||
| 2010-01-19 | Return arrays instead of calling rest::reply. | Bharat Mediratta | |
| 2010-01-18 | Updated for model based validation. Fixed | Bharat Mediratta | |
| change_photo_no_csrf_fails_test() which has been broken since we deleted Rest_Controller. | |||
| 2010-01-18 | Add slug_is_url_safe_test() | Bharat Mediratta | |
| 2010-01-18 | Update for model validation. Move the url safe tests into Item_Model_Test. | Bharat Mediratta | |
| 2010-01-18 | No longer necessary; all photo and movie helper code is now in the model. | Bharat Mediratta | |
| 2010-01-18 | No longer necessary; all relevant album helper code is now in the model. | Bharat Mediratta | |
| 2010-01-18 | Updated for model based validation. | Bharat Mediratta | |
| change_album_no_csrf_fails_test() had been broken since we got rid of REST_Controller, but was poorly written so we didn't realize it. Boo. | |||
| 2010-01-18 | Update for model based validation. Use test helper. Reduce the code size ↵ | Bharat Mediratta | |
| greatly! | |||
| 2010-01-18 | switch to test::starts_with(). | Bharat Mediratta | |
| 2010-01-18 | Whitespace. | Bharat Mediratta | |
| 2010-01-18 | Switch from ORM_MPTT::$db_builder to db::build(). | Bharat Mediratta | |
| 2010-01-18 | Minor test cleanup. | Bharat Mediratta | |
| 2010-01-18 | Update valid_parent() to disallow moving an item inside its own hierarchy. | Bharat Mediratta | |
| Move move_to() inside save() | |||
| 2010-01-18 | in move_to(), move the lock to before we do any calculations so that we have ↵ | Bharat Mediratta | |
| the latest data. | |||
| 2010-01-18 | Added move_album_fails_wrong_target_type_test() | Bharat Mediratta | |
| 2010-01-18 | Updated tests to match what the expected new API for moving items. | Bharat Mediratta | |
| Now to move an item, you just change its parent_id. | |||
| 2010-01-18 | Switch to using test::random_name() to avoid integer names. | Bharat Mediratta | |
| Fix up rename_photo_test. | |||
| 2010-01-18 | Fix renaming in save() by moving the actual rename action under | Bharat Mediratta | |
| parent::save(). This is consistent with other changes because all filesystem operations happen after the database change is committed. Also, inline rename() since it's fairly simple now. | |||
| 2010-01-18 | Kohana ticket #2504 is resolved, so this test is no longer necessary. | Bharat Mediratta | |
| 2010-01-18 | In valid_name, don't query on the id if it's null. | Bharat Mediratta | |
| 2010-01-18 | In item_rename_fails_with_existing_name_test switch validate() to | Bharat Mediratta | |
| save() now that Kohana ticket #2504 is resolved. | |||
| 2010-01-18 | Merge branch 'master' into bharat_dev | Bharat Mediratta | |
| 2010-01-18 | Coerce some integers to strings now that ORM isn't typecasting anymore. | Bharat Mediratta | |
| 2010-01-18 | The root parent id is 0, not null (this deviation exposed by the new lack of ↵ | Bharat Mediratta | |
| typecasting in ORM). | |||
