summaryrefslogtreecommitdiff
path: root/modules/gallery
AgeCommit message (Collapse)Author
2010-01-18Fix renaming in save() by moving the actual rename action underBharat Mediratta
parent::save(). This is consistent with other changes because all filesystem operations happen after the database change is committed. Also, inline rename() since it's fairly simple now.
2010-01-18Kohana ticket #2504 is resolved, so this test is no longer necessary.Bharat Mediratta
2010-01-18In valid_name, don't query on the id if it's null.Bharat Mediratta
2010-01-18In item_rename_fails_with_existing_name_test switch validate() toBharat Mediratta
save() now that Kohana ticket #2504 is resolved.
2010-01-18Merge branch 'master' into bharat_devBharat Mediratta
2010-01-18Coerce some integers to strings now that ORM isn't typecasting anymore.Bharat Mediratta
2010-01-18The root parent id is 0, not null (this deviation exposed by the new lack of ↵Bharat Mediratta
typecasting in ORM).
2010-01-18Don't assert_same() now that typecasting is gone from ORM.Bharat Mediratta
2010-01-18Don't use rand() as the name. Now that ORM::load_types() is gone, itBharat Mediratta
won't get coerced to a string, and then we wind up comparing: 12345 != 12345-12321 In the old approach, they'd both be strings so they'd be inequal. But in the new approach the first value is an integer (sinced it came from rand()) so the second value is typecast to an integer which drops everything after the - sign so they appear equal.
2010-01-18Merge branch 'master' into kohana_updateBharat Mediratta
2010-01-18VerifiedBharat Mediratta
2010-01-18Switch from stdClass to arrays which works around issues caused inBharat Mediratta
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but the solutions are equivalent so I'm not going to dig too far.
2010-01-18Change DENY and ALLOW to "0" and "1" to match the fact that ORM noBharat Mediratta
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18Reload $item after removing view permissions.Bharat Mediratta
2010-01-18Overload url::current() and url::merge() to make the current url XSSBharat Mediratta
safe. Add tests to make sure that it doesn't relapse with future Kohana changes. Fixes ticket #983. Ref: http://gallery.menalto.com/node/93738
2010-01-18Add a test to verify that bug #2504 is still around. When this testBharat Mediratta
starts failing, the bug is fixed and we can go fix our code that works around it.
2010-01-17Convert a $root to item::root() to fix a test.Bharat Mediratta
2010-01-17Get rid of urls_are_rawurlencoded_test -- it's no longer necessaryBharat Mediratta
since we can't have unsafe slugs. Add basic_validation_test.
2010-01-17Fix item_rename_fails_with_existing_name_test() -- broken because ofBharat Mediratta
http://dev.kohanaphp.com/issues/2504
2010-01-17Fix rename_album_test()Bharat Mediratta
2010-01-17Fix rename_photo_test().Bharat Mediratta
2010-01-17Partially updated for model based validation.Bharat Mediratta
2010-01-17Mostly conver to model based validation. Not all tests pass yet.Bharat Mediratta
2010-01-17Change IdentityProvider::create_user() to take $email as well, since that's ↵Bharat Mediratta
a required parameter for the Gallery driver.
2010-01-17Make set_data_file() chainable.Bharat Mediratta
2010-01-17Get rid of internal_only designation -- it's too hard to enforce cleanly.Bharat Mediratta
2010-01-17Remove a @todo.Bharat Mediratta
2010-01-17If we call original() and there's no $original yet, then consider thisBharat Mediratta
to be the original. That should be safe because we're already guarding __set, __unset and save.
2010-01-17Adjust installers to work with model based validation.Bharat Mediratta
2010-01-17Move rules entirely down into validate() so that we can be moreBharat Mediratta
sophisticated but keep all our rules in one place. Add rules for most fields.
2010-01-16Use "(string) $form" instead of "$form->__toString()"Bharat Mediratta
2010-01-16Get rid of add_rules_from() -- it's no longer necessary now that we're doing ↵Bharat Mediratta
model based validation.
2010-01-16PHPdoc.Bharat Mediratta
2010-01-16Don't forget to save when we make insignificant chagnes only.Bharat Mediratta
2010-01-16Convert Movies_Controller::update() over to model based validation.Bharat Mediratta
2010-01-16Make movie creation use model based validation. Move movie relatedBharat Mediratta
logic from movie::create() into Item_Model
2010-01-16Oops, log::failure() doesn't exist. Use log::error().Bharat Mediratta
2010-01-16Convert Photos_Controller::update() to use model based validation.Bharat Mediratta
2010-01-16Check for illegal extensions in valid_name()Bharat Mediratta
Fix a bug where we were not calling valid_data_file correctly.
2010-01-16Convert photo uploading over to the new model based validationBharat Mediratta
approach. - Rearrange Simple_Uploader_Controller::add_photo() to validate the form early in the process, and switch to using model based validation. - Move thumbnail generation into gallery_event::item_created() so that it's decoupled from the model. - Delete photo::create() and move all of its logic into Item_Model::save(). - Add Item_Model::$data_file to track the data file associated with new movies and photos. - Do some cleanup on the validation callbacks -- it turns out the 2nd argument is the field name not the value.
2010-01-16Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
Conflicts: modules/gallery/models/item.php
2010-01-16Don't pass MY_ORM::original() to update event handlers, since afterBharat Mediratta
parent::save() it'll be reset. Clone it first. This is an alternate fix for #978.
2010-01-15Revert "Fix for ticket #978. Don't reset the original property as part of ↵Bharat Mediratta
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
2010-01-15Revert "Did the old commit then save trick"Bharat Mediratta
This reverts commit e41ad23a8ea05d28a99d12c01d8f317455b1d361.
2010-01-15Validate the model type.Bharat Mediratta
2010-01-15Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-15Call parent::save() before releasing the lock to make creating the hole and ↵Bharat Mediratta
filling it an atomic operation.
2010-01-15Move model business logic out of album::create() and intoBharat Mediratta
Item_Model::save(). This makes creating albums similar to editing them and makes it difficult to create an album poorly. I expect to be able to remove a lot of code from the photo and movie helper because it's duplicated here. In order to do this, I refactored ORM_MPTT::add_to_parent() into ORM_MPTT::save() so we now add it to the parent when we do save. This allows us to call save() only once which saves a database call per add. The Albums_Controller logic is roughly the same as before. Haven't updated the tests yet, they're going to fail miserably since many of them depend on album::create() which is now gone.
2010-01-15Don't use Input directly to get album names, etc. Use the form fields.Bharat Mediratta
2010-01-15Move setting Item_Model::rand_key into Item_Model::save() since it'sBharat Mediratta
business logic.
generated by cgit v1.2.3 (git 2.51.0) at 2025-11-11 14:58:18 +0000