summaryrefslogtreecommitdiff
path: root/modules/gallery
AgeCommit message (Collapse)Author
2010-01-21Use Unicode instead of HTML entity (since the l10n server normalizes this ↵Andy Staudacher
way and rejects submissions that change under the normalization step)
2010-01-21Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-21Internationalize all strings in admin_modules.hmtl and corrected comments.Tim Almdal
2010-01-21We don't need CSRF in Rest_Controller::__call() because we use access tokens.Bharat Mediratta
2010-01-21Make sure that we actually don't have permissions, to avoid contamination w/ ↵Bharat Mediratta
other tests.
2010-01-21Exclude modules/gallery_unit_test/views/kohana/error.phpBharat Mediratta
2010-01-21Fix a minor bad expectation.Bharat Mediratta
2010-01-21Can't call ORM_MPTT::move_to() externally, so call Item_Model::save() instead.Bharat Mediratta
2010-01-21The admin module controller allows modules to provide a check_environment methodTim Almdal
which is called prior to installation. The method allows the module to provide an error message or warnings if the module can not be installed or activated without issues. The admin module controller also will fire a pre_deactivate event, which allows modules to indicate issues that may arise be deactivating the specified module. These messages are displayed in a dialog box prior to installation in order to allow the gallery administrator to determine the appropriate action before proceeding. Lays the foundation for implementing a fix for ticket #937
2010-01-21Reload the album after adding the photo so that MPTT pointers are correct.Bharat Mediratta
2010-01-20Whitespace.Bharat Mediratta
2010-01-20Two fixes:Bharat Mediratta
1) Don't call ORM_MPTT::move_to() directly. Use the new model-based-validation approach of changing the parent_id and saving. 2) Item_Model::parent() can return null; check for it.
2010-01-20Make move_to protected since we don't want folks calling it onBharat Mediratta
Item_Model. If there's a need to make this public, we should override it in Item_Model and throw an exception there.
2010-01-20Remove debug code.Bharat Mediratta
2010-01-20Oops, bug in save() -- we weren't returning the saved value!Bharat Mediratta
2010-01-20Fix maintenance tasks / language admin for bug introduced earlier by no ↵Andy Staudacher
longer casting in ORM. Task->done is now a string, boolean false is stored as integer 0 and loaded as string "0". On the client side that's interpreted as truthy in JavaScript. Fix: cast "0" to (bool) before encoding to JSON.
2010-01-20Delete MY_ORM::original(). We did not have proper containment toBharat Mediratta
generate $original when we needed it, resulting in inconsistent behavior.
2010-01-20Stop using MY_ORM::original().Bharat Mediratta
2010-01-20Throw Kohana_Exception instead of Exception on access denied, since that may ↵Bharat Mediratta
bubble all the way up
2010-01-20Stop using MY_ORM::original(). It's got very odd semantics and we areBharat Mediratta
not capturing all cases for setting and resetting $original, which leads to some weird and hard to reproduce behavior. Instead, if we need the original just reload it from the database. This may result in a somewhat excessive load in places, but we'll have to fix that in a later optimization pass.
2010-01-20Throw Rest exceptions, not regular exceptions.Bharat Mediratta
2010-01-20Forbidden is a 403, not a 503.Bharat Mediratta
2010-01-19Extend Gallery_Unit_Test_Case instead of Unit_Test_Case.Bharat Mediratta
2010-01-19Fix some validation checks to check to see if the original was loadedBharat Mediratta
before deciding whether or not we changed a value. Change valid_name to be cascading, not parallel.
2010-01-19Move data initialization into the constructor so that it happensBharat Mediratta
before validate() is called, which is important with our two phase web controllers. Make valid_parent smarter about moving existing items, vs new items.
2010-01-19Change "filename" to "name" in the edit album form. I'd rather haveBharat Mediratta
consistency between field names than deal with underlying issues with Forge bitching about the "name" property.
2010-01-19Make video/x-flv a valid movie mime_typeBharat Mediratta
2010-01-19Change "dirname" to "name" in the edit album form. I'd rather haveBharat Mediratta
consistency between field names than deal with underlying issues with Forge bitching about the "name" property.
2010-01-19Use property_exists() on our stdClass instead of array_key_exists()Bharat Mediratta
2010-01-19Change rest::url() to take a module name and a resource. The moduleBharat Mediratta
does the rest. This function is symmetrical to rest::resolve.
2010-01-19Rewrite the tests entirely to cover the new REST code.Bharat Mediratta
2010-01-19Make scope default to direct.Bharat Mediratta
Add slug to the post params. Fix minor output bug.
2010-01-19Don't try to set the album cover for the grandparent if we don't have edit ↵Bharat Mediratta
permissions for it.
2010-01-19Return arrays instead of calling rest::reply.Bharat Mediratta
2010-01-18Updated for model based validation. FixedBharat Mediratta
change_photo_no_csrf_fails_test() which has been broken since we deleted Rest_Controller.
2010-01-18Add slug_is_url_safe_test()Bharat Mediratta
2010-01-18Update for model validation. Move the url safe tests into Item_Model_Test.Bharat Mediratta
2010-01-18No longer necessary; all photo and movie helper code is now in the model.Bharat Mediratta
2010-01-18No longer necessary; all relevant album helper code is now in the model.Bharat Mediratta
2010-01-18Updated for model based validation.Bharat Mediratta
change_album_no_csrf_fails_test() had been broken since we got rid of REST_Controller, but was poorly written so we didn't realize it. Boo.
2010-01-18Update for model based validation. Use test helper. Reduce the code size ↵Bharat Mediratta
greatly!
2010-01-18switch to test::starts_with().Bharat Mediratta
2010-01-18Whitespace.Bharat Mediratta
2010-01-18Switch from ORM_MPTT::$db_builder to db::build().Bharat Mediratta
2010-01-18Minor test cleanup.Bharat Mediratta
2010-01-18Update valid_parent() to disallow moving an item inside its own hierarchy.Bharat Mediratta
Move move_to() inside save()
2010-01-18in move_to(), move the lock to before we do any calculations so that we have ↵Bharat Mediratta
the latest data.
2010-01-18Added move_album_fails_wrong_target_type_test()Bharat Mediratta
2010-01-18Updated tests to match what the expected new API for moving items.Bharat Mediratta
Now to move an item, you just change its parent_id.
2010-01-18Switch to using test::random_name() to avoid integer names.Bharat Mediratta
Fix up rename_photo_test.