summaryrefslogtreecommitdiff
path: root/modules/gallery
AgeCommit message (Collapse)Author
2010-01-20Make move_to protected since we don't want folks calling it onBharat Mediratta
Item_Model. If there's a need to make this public, we should override it in Item_Model and throw an exception there.
2010-01-20Remove debug code.Bharat Mediratta
2010-01-20Oops, bug in save() -- we weren't returning the saved value!Bharat Mediratta
2010-01-20Fix maintenance tasks / language admin for bug introduced earlier by no ↵Andy Staudacher
longer casting in ORM. Task->done is now a string, boolean false is stored as integer 0 and loaded as string "0". On the client side that's interpreted as truthy in JavaScript. Fix: cast "0" to (bool) before encoding to JSON.
2010-01-20Delete MY_ORM::original(). We did not have proper containment toBharat Mediratta
generate $original when we needed it, resulting in inconsistent behavior.
2010-01-20Stop using MY_ORM::original().Bharat Mediratta
2010-01-20Throw Kohana_Exception instead of Exception on access denied, since that may ↵Bharat Mediratta
bubble all the way up
2010-01-20Stop using MY_ORM::original(). It's got very odd semantics and we areBharat Mediratta
not capturing all cases for setting and resetting $original, which leads to some weird and hard to reproduce behavior. Instead, if we need the original just reload it from the database. This may result in a somewhat excessive load in places, but we'll have to fix that in a later optimization pass.
2010-01-20Throw Rest exceptions, not regular exceptions.Bharat Mediratta
2010-01-20Forbidden is a 403, not a 503.Bharat Mediratta
2010-01-19Extend Gallery_Unit_Test_Case instead of Unit_Test_Case.Bharat Mediratta
2010-01-19Fix some validation checks to check to see if the original was loadedBharat Mediratta
before deciding whether or not we changed a value. Change valid_name to be cascading, not parallel.
2010-01-19Move data initialization into the constructor so that it happensBharat Mediratta
before validate() is called, which is important with our two phase web controllers. Make valid_parent smarter about moving existing items, vs new items.
2010-01-19Change "filename" to "name" in the edit album form. I'd rather haveBharat Mediratta
consistency between field names than deal with underlying issues with Forge bitching about the "name" property.
2010-01-19Make video/x-flv a valid movie mime_typeBharat Mediratta
2010-01-19Change "dirname" to "name" in the edit album form. I'd rather haveBharat Mediratta
consistency between field names than deal with underlying issues with Forge bitching about the "name" property.
2010-01-19Use property_exists() on our stdClass instead of array_key_exists()Bharat Mediratta
2010-01-19Change rest::url() to take a module name and a resource. The moduleBharat Mediratta
does the rest. This function is symmetrical to rest::resolve.
2010-01-19Rewrite the tests entirely to cover the new REST code.Bharat Mediratta
2010-01-19Make scope default to direct.Bharat Mediratta
Add slug to the post params. Fix minor output bug.
2010-01-19Don't try to set the album cover for the grandparent if we don't have edit ↵Bharat Mediratta
permissions for it.
2010-01-19Return arrays instead of calling rest::reply.Bharat Mediratta
2010-01-18Updated for model based validation. FixedBharat Mediratta
change_photo_no_csrf_fails_test() which has been broken since we deleted Rest_Controller.
2010-01-18Add slug_is_url_safe_test()Bharat Mediratta
2010-01-18Update for model validation. Move the url safe tests into Item_Model_Test.Bharat Mediratta
2010-01-18No longer necessary; all photo and movie helper code is now in the model.Bharat Mediratta
2010-01-18No longer necessary; all relevant album helper code is now in the model.Bharat Mediratta
2010-01-18Updated for model based validation.Bharat Mediratta
change_album_no_csrf_fails_test() had been broken since we got rid of REST_Controller, but was poorly written so we didn't realize it. Boo.
2010-01-18Update for model based validation. Use test helper. Reduce the code size ↵Bharat Mediratta
greatly!
2010-01-18switch to test::starts_with().Bharat Mediratta
2010-01-18Whitespace.Bharat Mediratta
2010-01-18Switch from ORM_MPTT::$db_builder to db::build().Bharat Mediratta
2010-01-18Minor test cleanup.Bharat Mediratta
2010-01-18Update valid_parent() to disallow moving an item inside its own hierarchy.Bharat Mediratta
Move move_to() inside save()
2010-01-18in move_to(), move the lock to before we do any calculations so that we have ↵Bharat Mediratta
the latest data.
2010-01-18Added move_album_fails_wrong_target_type_test()Bharat Mediratta
2010-01-18Updated tests to match what the expected new API for moving items.Bharat Mediratta
Now to move an item, you just change its parent_id.
2010-01-18Switch to using test::random_name() to avoid integer names.Bharat Mediratta
Fix up rename_photo_test.
2010-01-18Fix renaming in save() by moving the actual rename action underBharat Mediratta
parent::save(). This is consistent with other changes because all filesystem operations happen after the database change is committed. Also, inline rename() since it's fairly simple now.
2010-01-18Kohana ticket #2504 is resolved, so this test is no longer necessary.Bharat Mediratta
2010-01-18In valid_name, don't query on the id if it's null.Bharat Mediratta
2010-01-18In item_rename_fails_with_existing_name_test switch validate() toBharat Mediratta
save() now that Kohana ticket #2504 is resolved.
2010-01-18Merge branch 'master' into bharat_devBharat Mediratta
2010-01-18Coerce some integers to strings now that ORM isn't typecasting anymore.Bharat Mediratta
2010-01-18The root parent id is 0, not null (this deviation exposed by the new lack of ↵Bharat Mediratta
typecasting in ORM).
2010-01-18Don't assert_same() now that typecasting is gone from ORM.Bharat Mediratta
2010-01-18Don't use rand() as the name. Now that ORM::load_types() is gone, itBharat Mediratta
won't get coerced to a string, and then we wind up comparing: 12345 != 12345-12321 In the old approach, they'd both be strings so they'd be inequal. But in the new approach the first value is an integer (sinced it came from rand()) so the second value is typecast to an integer which drops everything after the - sign so they appear equal.
2010-01-18Merge branch 'master' into kohana_updateBharat Mediratta
2010-01-18VerifiedBharat Mediratta
2010-01-18Switch from stdClass to arrays which works around issues caused inBharat Mediratta
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but the solutions are equivalent so I'm not going to dig too far.