| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-08-01 | Make the continuation url go to admin/maintenance. | Bharat Mediratta | |
| 2010-08-01 | Focus on the username field by default. Don't use jQuery because we're ↵ | Bharat Mediratta | |
| operating in a very limited context. | |||
| 2010-08-01 | Write appropriate PHPdoc for json::reply. | Bharat Mediratta | |
| 2010-08-01 | Specify the charset on the content type header | Tim Almdal | |
| 2010-07-31 | Full pass over all the JSON encoding and JS dialog code. We now abide | Bharat Mediratta | |
| by the following rules: 1) An initial dialog or panel load can take either HTML or JSON, but the mime type must accurately reflect its payload. 2) dialog form submits can handle a pure HTML response, but the mime type must also be correct. This properly resolves the problem where the reauth code gets a JSON response first from the reauth code, and then an HTML response when you reauth and continue on to a given form -- try it out with Admin > Settings > Advanced. 3) All JSON replies must set the mime type correctly. The json::reply convenience function does this for us. 4) By default, any HTML content sent back in the JSON response should be in the "html" field, no longer the "form" field. The combination of these allows us to stop doing boilerplate code like this in our controllers: // Print our view, JSON encoded json::reply(array("form" => (string) $view)); instead, controllers can just return HTML, eg: // Print our view print $view; That's much more intuitive for developers. | |||
| 2010-07-31 | "Save" -> "Download" for clarity. | Bharat Mediratta | |
| 2010-07-31 | Resend the entire dialog content (including the wrapping view) instead of ↵ | Tim Almdal | |
| just the form. | |||
| 2010-07-31 | Missing the user name on the reauthenticate form. | Tim Almdal | |
| 2010-07-31 | When the admin controller redirects to the reauthenticate controller, the ↵ | Tim Almdal | |
| value of request::is_ajax() from the original request is lost. This patch stores its value in the session so the reauthenticate controller knows whether its in a dialog/panel or not. | |||
| 2010-07-31 | Convert the admin_theme controller to use the json::reply method | Tim Almdal | |
| 2010-07-31 | More patches as part of #1225. Change the 'core' modules to use the json::reply | Tim Almdal | |
| method to set the content type header and encode the response as a json object | |||
| 2010-07-31 | Partial fix for #1225. Create a json reply helper that sets the content type ↵ | Tim Almdal | |
| to application/json and then json encodes the reply. | |||
| 2010-07-31 | Fix typo: ui-corners-all --> ui-corner-all | Bharat Mediratta | |
| thanks Lord Beowulf! | |||
| 2010-07-31 | Use readfile() instead of fopen()/fpassthru()/fclose() for brevity. | Bharat Mediratta | |
| I've done some tests on a 60M flv and found that there's no difference in memory consumption with these three approaches: public function test() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; if ($fd = fopen($file, "rb")) { while (true) { $bits = fread($fd, 65535); if (strlen($bits) == 0) { break; } print $bits; set_time_limit(30); } fclose($fd); } Kohana_Log::add("error","test: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); } public function test2() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; $fd = fopen($file, "rb"); fpassthru($fd); fclose($fd); Kohana_Log::add("error","test2: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); } public function test3() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; readfile($file); Kohana_Log::add("error","test3: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); } | |||
| 2010-07-29 | Add recovery code for dupe slugs and dupe names to the general purpose Fix | Bharat Mediratta | |
| task. Fixes ticket #1260. | |||
| 2010-07-29 | We don't care about the name and slug for the root album so don't bother ↵ | Bharat Mediratta | |
| enforcing them. | |||
| 2010-07-29 | Trap ORM_Validation_Exception specially and report which fields failed ↵ | Bharat Mediratta | |
| validation. | |||
| 2010-07-28 | Combine the Fix MPTT and Fix Permissions tasks into one magical fix-it | Bharat Mediratta | |
| task. | |||
| 2010-07-27 | "public static" ==> "static" to match code conventions. | Bharat Mediratta | |
| 2010-07-27 | Verified | Bharat Mediratta | |
| 2010-07-27 | Updated | Bharat Mediratta | |
| 2010-07-27 | Don't invoke a graphics toolkit when setting the album cover from a | Bharat Mediratta | |
| clean thumbnail; we can just copy it over. Should be a decent perf improvement in many cases. Fixes ticket #1255. | |||
| 2010-07-25 | Add a new maintenance task that resyncs album .htaccess files with | Bharat Mediratta | |
| database access intents. Use this to fix up .htaccess files after you relocate your Gallery. Fixes ticket #1252. | |||
| 2010-07-25 | Move the "cancel all" running tasks button up to make it consistent with the ↵ | Bharat Mediratta | |
| "remove all finished" button. | |||
| 2010-07-25 | Don't use hardcoded id 1 as the everybody group; it won't work with ↵ | Bharat Mediratta | |
| alternative auth schemes. | |||
| 2010-07-22 | Initialize $request in submit_translations(). Fixes ticket #1239. | Bharat Mediratta | |
| 2010-07-22 | Properly handle the case where the album_cover_item_id points to an | Bharat Mediratta | |
| invalid (probably deleted) item. Fixes ticket #1238. | |||
| 2010-07-21 | Catch any exceptions thrown when we try to restore the original | Bharat Mediratta | |
| identity provider after we fail to set up a new one. | |||
| 2010-07-21 | Null out relative_path_cache and relative_url_cache after we update | Bharat Mediratta | |
| the pointers in case the hierarchy was adversely affected by actions when the MPTT pointers were desynced. Fixes ticket #1235. | |||
| 2010-07-20 | Cleanup on the Admin > Languages page. | Bharat Mediratta | |
| Hide the fieldset and legend in the theme, since they don't add any value. Change l10n_client::_server_url() to use the short style GMC urls and make the API a little tighter. | |||
| 2010-07-20 | Use Session::get_once() instead of Session::get() followed by Session::delete(); | Bharat Mediratta | |
| 2010-07-20 | Oops! Proper fix for #1201. My last fix just redirected back to the | Bharat Mediratta | |
| main site, and didn't actually log you out. | |||
| 2010-07-17 | Fix margin: 0 auto; IE issue in the upgrader view by adding a doctype to the ↵ | Chad Kieffer | |
| template. Minor code refactoring. Also seems to fix #1188. | |||
| 2010-07-17 | Fix closing ul on inactive modules list, replaced <i> with <em> in footer. | Chad Kieffer | |
| 2010-07-16 | Merge branch 'master' of github.com:gallery/gallery3 | Bharat Mediratta | |
| 2010-07-16 | Improve the fix for #1176 to use request::is_ajax() instead of tacking | Bharat Mediratta | |
| on a query param to urls that appear in dialogs. This keeps things simpler. | |||
| 2010-07-16 | Remove code that was inadvertently committed. | Tim Almdal | |
| 2010-07-15 | Don't show a themed 404 page if we get to a 404 via file_proxy. Just | Bharat Mediratta | |
| return a simple "File not found" message, since this is a very basic file access (thumbnail, resize, original etc) | |||
| 2010-07-15 | Remove the code to call the controller directly and just use redirect. Now ↵ | Tim Almdal | |
| that all the form calls actually return the form as a json object, calling the form creation controller method i no longer required. | |||
| 2010-07-15 | Rename g-in-dialog to the naming standard for query parameters and give it ↵ | Tim Almdal | |
| something more representative... 'gallery_dialog_request' | |||
| 2010-07-15 | Redirect users away from admin to the main site if you click logout on | Bharat Mediratta | |
| the admin dashboard. Fixes ticket #1201 | |||
| 2010-07-15 | Rename Flash_Uploader to just Uploader. Modules that want to replace | Bharat Mediratta | |
| this will just replace the controller. This makes overriding that much easier in the future. | |||
| 2010-07-13 | Revert "Fix for ticket #1182. Remove the trailing slash and just let it be ↵ | Bharat Mediratta | |
| matched by the trailing (.*) group" This breaks adding new albums. I get the following in my error log: "2010-07-13 13:08:46 -07:00 --- error: Kohana_404_Exception [ 43 ]: The page you requested, form/add/albums/1?type=album&g-in-dialog, could not be found." This reverts commit cb4e18f9dddd82a283f0208c694a9b4eb1a2eaca. | |||
| 2010-07-13 | Fix reauth authentication to use the identity helper instead of the | Bharat Mediratta | |
| user helper directly. Else it doesn't work with LDAP and other identity systems. | |||
| 2010-07-11 | Merge branch 'master' into talmdal_dev | Tim Almdal | |
| 2010-07-10 | Rotate all matching album covers when we rotate an item. Fixes ticket #1200. | Bharat Mediratta | |
| 2010-07-10 | If the target of an item move has no album cover, make the newly moved item ↵ | Bharat Mediratta | |
| the album cover. Fixes ticket #1196. | |||
| 2010-07-10 | Wrap album deletes in a batch so that we can handle lots of cascading | Bharat Mediratta | |
| deletes in bulk. This lets us avoid the problem where we continually choose and delete album covers which makes deletes really slow. It probably also avoids huge amounts of notification emails (untested). Fixes ticket #1190. | |||
| 2010-07-10 | PHPDoc fix. | Bharat Mediratta | |
| 2010-07-10 | Reset the time limit to 30 seconds every time we delete a child. Fixes ↵ | Bharat Mediratta | |
| ticket #1199. | |||
