| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Instead of overwriting Kohana_Exception::handle() (which we were doing
in MY_Kohana_Exception) we instead use their existing template system.
gallery/views/kohana/error.php overrides system/views/kohana/error.php
and is the standard error template for all exceptions. Our version of
error.php figures out the appropriate view based on context (cli,
authenticated admin, guest viewing a 404, guest viewing a system
error) and delegates appropriately. Each delegated view has a narrow
responsibility.
This paves the way for us to add new error views per module. For
example, the rest module will define its own template in
Rest_Exception and then its exceptions can be rendered the way that it
wants (json encoded, in that case).
|
|
|
|
|
|
|
|
|
|
find the item. Thanks to samdavidoff for the initial fix.
|
|
|
|
|
|
|
|
|
|
This reverts commit 98fce83de5f772482382bfabdbcd94c25ecdbb1a.
Conflicts:
modules/gallery/tests/Item_Model_Test.php
|
|
item::move(source, target) helper when the parent member has changed.
Using the move method insures that names and slugs that could conflict
in the target album are resolved properly. Changed the item::move
method so it returns a message to be displayed if the caller chooses.
And changed the move controller to display the message returned by the
move if the item name was renamed as part of the move."
Rolling this back for a couple of reasons:
1) Bug in move.php ("message.info" is not a function name)
2) Having the message come back from the API call as a side-effect is
sloppy. We should find a cleaner way to do this checking.
3) having item::move() call save() on any changed values in the ORM
is counter-intuitive. Move should move, save should save.
I think the right approach here is to roll the move() code properly into
save().
This reverts commit 2492280cc0ec9eb64a8daeccc7b5698ece7fea66.
|
|
method, which encapsulates saving an item and handling name and slug
conflicts. Call this instead of doing a save directly."
Rolled this back because it fails KISS. We already have an API for
saving models with Item_Model::save() that's consistent with all of
our other model code. Adding a new way to save items is confusing and
inconsistent.
This reverts commit 9504f71efcadc7ed27f6f09e5d663e8025bf3b86.
|
|
|
|
|
|
Skip . and .. (PHP 5.3 iterators seem to include those now).
|
|
encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly.
|
|
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move.
|
|
to weight.
|
|
itemm::move(source, target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Also, only change the weights of the album children if the item sort_column is set to weight."
This reverts commit 603d4640141a43350f50da747d747456b28fdd93.
|
|
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Also, only change the weights of the album children if the item sort_column is set to weight.
|
|
ticket #1029.
|
|
|
|
|
|
|
|
|
|
|
|
admin site as a guest. Also, theme the login/html page.
|
|
we specify the continue_url in the session, but we store it in the
login form so that we can propagate it across the session creation
that happens at login time.
|
|
reauth code.
|
|
login/continue code.
|
|
it requires us to reproduce a bunch of complex routing logic.
Instead, just have the logout link generating code generate a link
that's visible to guests.
|
|
slugs as errors. There was already code in the item save to insure that any"
This introduces a bug where you can create two items with the same slug.
This reverts commit cb01f4017d70a7d73273052b424e8b78b794bc1c.
|
|
errors. There was already code in the item save to insure that any
duplicates were made unique, so this patch removes the validation as unnecessary.
|
|
the full url in the continue parameter. In the logout controller, we tried to get the item from the url so we could check the permission of the item to insure that the guest user had access. But url::get_item_from_url expects a relative url.
|
|
ticket #1092. Thanks to shinta for pointing the way.
|
|
ticket #1092. Thanks to shinta for pointing the way.
|
|
|
|
|
|
|
|
about .svn
|
|
|
|
bad idea.
This reverts commit 6425d41eddd44091b2d83ba3c3734cc6990ca581.
|
|
applicable to the current user.
|
|
part of a REST request. Format the exception as a json encoded text string so the client can extract the fault information if they so choose.
|
|
indicates that we shouldn't opportunistically convert ids into REST
urls.
|
|
we can turn on with a query parameter.
|
|
|
|
ticket #1157. Thanks to psvo.
|
