| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-01-20 | Stop using MY_ORM::original(). It's got very odd semantics and we are | Bharat Mediratta | |
| not capturing all cases for setting and resetting $original, which leads to some weird and hard to reproduce behavior. Instead, if we need the original just reload it from the database. This may result in a somewhat excessive load in places, but we'll have to fix that in a later optimization pass. | |||
| 2010-01-19 | Extend Gallery_Unit_Test_Case instead of Unit_Test_Case. | Bharat Mediratta | |
| 2010-01-19 | Fix some validation checks to check to see if the original was loaded | Bharat Mediratta | |
| before deciding whether or not we changed a value. Change valid_name to be cascading, not parallel. | |||
| 2010-01-19 | Change "filename" to "name" in the edit album form. I'd rather have | Bharat Mediratta | |
| consistency between field names than deal with underlying issues with Forge bitching about the "name" property. | |||
| 2010-01-19 | Change "dirname" to "name" in the edit album form. I'd rather have | Bharat Mediratta | |
| consistency between field names than deal with underlying issues with Forge bitching about the "name" property. | |||
| 2010-01-19 | Change rest::url() to take a module name and a resource. The module | Bharat Mediratta | |
| does the rest. This function is symmetrical to rest::resolve. | |||
| 2010-01-19 | Rewrite the tests entirely to cover the new REST code. | Bharat Mediratta | |
| 2010-01-18 | Updated for model based validation. Fixed | Bharat Mediratta | |
| change_photo_no_csrf_fails_test() which has been broken since we deleted Rest_Controller. | |||
| 2010-01-18 | Add slug_is_url_safe_test() | Bharat Mediratta | |
| 2010-01-18 | Update for model validation. Move the url safe tests into Item_Model_Test. | Bharat Mediratta | |
| 2010-01-18 | No longer necessary; all photo and movie helper code is now in the model. | Bharat Mediratta | |
| 2010-01-18 | No longer necessary; all relevant album helper code is now in the model. | Bharat Mediratta | |
| 2010-01-18 | Updated for model based validation. | Bharat Mediratta | |
| change_album_no_csrf_fails_test() had been broken since we got rid of REST_Controller, but was poorly written so we didn't realize it. Boo. | |||
| 2010-01-18 | Update for model based validation. Use test helper. Reduce the code size ↵ | Bharat Mediratta | |
| greatly! | |||
| 2010-01-18 | switch to test::starts_with(). | Bharat Mediratta | |
| 2010-01-18 | Minor test cleanup. | Bharat Mediratta | |
| 2010-01-18 | Added move_album_fails_wrong_target_type_test() | Bharat Mediratta | |
| 2010-01-18 | Updated tests to match what the expected new API for moving items. | Bharat Mediratta | |
| Now to move an item, you just change its parent_id. | |||
| 2010-01-18 | Switch to using test::random_name() to avoid integer names. | Bharat Mediratta | |
| Fix up rename_photo_test. | |||
| 2010-01-18 | Kohana ticket #2504 is resolved, so this test is no longer necessary. | Bharat Mediratta | |
| 2010-01-18 | In item_rename_fails_with_existing_name_test switch validate() to | Bharat Mediratta | |
| save() now that Kohana ticket #2504 is resolved. | |||
| 2010-01-18 | Merge branch 'master' into bharat_dev | Bharat Mediratta | |
| 2010-01-18 | Coerce some integers to strings now that ORM isn't typecasting anymore. | Bharat Mediratta | |
| 2010-01-18 | The root parent id is 0, not null (this deviation exposed by the new lack of ↵ | Bharat Mediratta | |
| typecasting in ORM). | |||
| 2010-01-18 | Don't assert_same() now that typecasting is gone from ORM. | Bharat Mediratta | |
| 2010-01-18 | Don't use rand() as the name. Now that ORM::load_types() is gone, it | Bharat Mediratta | |
| won't get coerced to a string, and then we wind up comparing: 12345 != 12345-12321 In the old approach, they'd both be strings so they'd be inequal. But in the new approach the first value is an integer (sinced it came from rand()) so the second value is typecast to an integer which drops everything after the - sign so they appear equal. | |||
| 2010-01-18 | Verified | Bharat Mediratta | |
| 2010-01-18 | Reload $item after removing view permissions. | Bharat Mediratta | |
| 2010-01-18 | Overload url::current() and url::merge() to make the current url XSS | Bharat Mediratta | |
| safe. Add tests to make sure that it doesn't relapse with future Kohana changes. Fixes ticket #983. Ref: http://gallery.menalto.com/node/93738 | |||
| 2010-01-18 | Add a test to verify that bug #2504 is still around. When this test | Bharat Mediratta | |
| starts failing, the bug is fixed and we can go fix our code that works around it. | |||
| 2010-01-17 | Convert a $root to item::root() to fix a test. | Bharat Mediratta | |
| 2010-01-17 | Get rid of urls_are_rawurlencoded_test -- it's no longer necessary | Bharat Mediratta | |
| since we can't have unsafe slugs. Add basic_validation_test. | |||
| 2010-01-17 | Fix item_rename_fails_with_existing_name_test() -- broken because of | Bharat Mediratta | |
| http://dev.kohanaphp.com/issues/2504 | |||
| 2010-01-17 | Fix rename_album_test() | Bharat Mediratta | |
| 2010-01-17 | Fix rename_photo_test(). | Bharat Mediratta | |
| 2010-01-17 | Partially updated for model based validation. | Bharat Mediratta | |
| 2010-01-17 | Mostly conver to model based validation. Not all tests pass yet. | Bharat Mediratta | |
| 2010-01-16 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| Conflicts: modules/gallery/models/item.php | |||
| 2010-01-15 | Revert "Fix for ticket #978. Don't reset the original property as part of ↵ | Bharat Mediratta | |
| the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6. | |||
| 2010-01-15 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-13 | Fix for ticket #978. Don't reset the original property as part of the save ↵ | Tim Almdal | |
| processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original. | |||
| 2010-01-10 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-09 | Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where | Tim Almdal | |
| clauses and deletes all the entries in the table unless an array of id's are passed as the parameter. This fix used the Database_builder to specify any where conditions. Thanks psvo for find the first one. :-) | |||
| 2010-01-07 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-06 | Correct the controller_auth_data golden file to reflect that the csrf is not ↵ | Tim Almdal | |
| longer considered dirty in the logout controller. | |||
| 2010-01-03 | Simplify the REST API code. Here's what I did: | Bharat Mediratta | |
| 1) Simplify gallery_rest to return flat models, no children and do no validation for now. 2) Flatten the REST replies and use HTTP codes to indicate success/failure instead of additional status messages. 3) Use the message and error code support in the base Exception class, instead of brewing our own in Rest_Exception. 4) Get rid of rest::success() and rest::fail() -- we only need rest::reply() since all failures are covered by throwing an exception. 5) Get rid of /rest/access_key and just use /rest for authentication. 6) Inline and simplify rest::normalize_request since we only use it once 7) Change rest::set_active_user to succeed or throw an exception 8) Extract Rest_Exception::sendHeaders into rest::send_headers() Here's what's currently broken: 1) Data validation. There currently is none 2) Logging. That's gone too 3) image block and tag code is broken 4) Tests are broken 5) No movie support | |||
| 2010-01-02 | Add rest_controller::__call to the authorized controller methods | Tim Almdal | |
| 2010-01-02 | Clean up gallery_rest helper test | Tim Almdal | |
| 2010-01-02 | Merge branch 'master' of git@github.com:gallery/gallery3 | Bharat Mediratta | |
| 2010-01-02 | Fix two issues with change_album_test() | Bharat Mediratta | |
| 1) We do support changing the name. 2) Choose a random name to avoid conflicts. | |||
 |
index : gallery3.git | |
| A clone of the Gallery3 code for testing and development. | root |
| summaryrefslogtreecommitdiff |