summaryrefslogtreecommitdiff
path: root/modules/gallery/tests
AgeCommit message (Collapse)Author
2010-01-18Added move_album_fails_wrong_target_type_test()Bharat Mediratta
2010-01-18Updated tests to match what the expected new API for moving items.Bharat Mediratta
Now to move an item, you just change its parent_id.
2010-01-18Switch to using test::random_name() to avoid integer names.Bharat Mediratta
Fix up rename_photo_test.
2010-01-18Kohana ticket #2504 is resolved, so this test is no longer necessary.Bharat Mediratta
2010-01-18In item_rename_fails_with_existing_name_test switch validate() toBharat Mediratta
save() now that Kohana ticket #2504 is resolved.
2010-01-18Merge branch 'master' into bharat_devBharat Mediratta
2010-01-18Coerce some integers to strings now that ORM isn't typecasting anymore.Bharat Mediratta
2010-01-18The root parent id is 0, not null (this deviation exposed by the new lack of ↵Bharat Mediratta
typecasting in ORM).
2010-01-18Don't assert_same() now that typecasting is gone from ORM.Bharat Mediratta
2010-01-18Don't use rand() as the name. Now that ORM::load_types() is gone, itBharat Mediratta
won't get coerced to a string, and then we wind up comparing: 12345 != 12345-12321 In the old approach, they'd both be strings so they'd be inequal. But in the new approach the first value is an integer (sinced it came from rand()) so the second value is typecast to an integer which drops everything after the - sign so they appear equal.
2010-01-18VerifiedBharat Mediratta
2010-01-18Reload $item after removing view permissions.Bharat Mediratta
2010-01-18Overload url::current() and url::merge() to make the current url XSSBharat Mediratta
safe. Add tests to make sure that it doesn't relapse with future Kohana changes. Fixes ticket #983. Ref: http://gallery.menalto.com/node/93738
2010-01-18Add a test to verify that bug #2504 is still around. When this testBharat Mediratta
starts failing, the bug is fixed and we can go fix our code that works around it.
2010-01-17Convert a $root to item::root() to fix a test.Bharat Mediratta
2010-01-17Get rid of urls_are_rawurlencoded_test -- it's no longer necessaryBharat Mediratta
since we can't have unsafe slugs. Add basic_validation_test.
2010-01-17Fix item_rename_fails_with_existing_name_test() -- broken because ofBharat Mediratta
http://dev.kohanaphp.com/issues/2504
2010-01-17Fix rename_album_test()Bharat Mediratta
2010-01-17Fix rename_photo_test().Bharat Mediratta
2010-01-17Partially updated for model based validation.Bharat Mediratta
2010-01-17Mostly conver to model based validation. Not all tests pass yet.Bharat Mediratta
2010-01-16Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
Conflicts: modules/gallery/models/item.php
2010-01-15Revert "Fix for ticket #978. Don't reset the original property as part of ↵Bharat Mediratta
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
2010-01-15Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-13Fix for ticket #978. Don't reset the original property as part of the save ↵Tim Almdal
processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original.
2010-01-10Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-09Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any whereTim Almdal
clauses and deletes all the entries in the table unless an array of id's are passed as the parameter. This fix used the Database_builder to specify any where conditions. Thanks psvo for find the first one. :-)
2010-01-07Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-06Correct the controller_auth_data golden file to reflect that the csrf is not ↵Tim Almdal
longer considered dirty in the logout controller.
2010-01-03Simplify the REST API code. Here's what I did:Bharat Mediratta
1) Simplify gallery_rest to return flat models, no children and do no validation for now. 2) Flatten the REST replies and use HTTP codes to indicate success/failure instead of additional status messages. 3) Use the message and error code support in the base Exception class, instead of brewing our own in Rest_Exception. 4) Get rid of rest::success() and rest::fail() -- we only need rest::reply() since all failures are covered by throwing an exception. 5) Get rid of /rest/access_key and just use /rest for authentication. 6) Inline and simplify rest::normalize_request since we only use it once 7) Change rest::set_active_user to succeed or throw an exception 8) Extract Rest_Exception::sendHeaders into rest::send_headers() Here's what's currently broken: 1) Data validation. There currently is none 2) Logging. That's gone too 3) image block and tag code is broken 4) Tests are broken 5) No movie support
2010-01-02Add rest_controller::__call to the authorized controller methodsTim Almdal
2010-01-02Clean up gallery_rest helper testTim Almdal
2010-01-02Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2010-01-02Fix two issues with change_album_test()Bharat Mediratta
1) We do support changing the name. 2) Choose a random name to avoid conflicts.
2010-01-02Correct unexpected error in gallery_rest_put_album_no_path_testTim Almdal
2010-01-02Ignore modules/gallery/views/kohana/error.php -- we're required to have that ↵Bharat Mediratta
name by Kohana_404_Exception.
2010-01-02Update the expected response after modifying an album to match theBharat Mediratta
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
2010-01-02Update the expected response after modifying an album to match theBharat Mediratta
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
2010-01-02Correct file structure tests, Have the tests delete the userid they create ↵Tim Almdal
so as not to impact other tests.
2010-01-02Verified and updated.Bharat Mediratta
2010-01-02Verified and updated.Bharat Mediratta
2010-01-02Update the expected response after modifying an album to match theBharat Mediratta
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
2010-01-02Add a cache buster to the resize and file urls. This fixes ticketBharat Mediratta
2009-12-31Merge branch 'master' into talmdal_devTim Almdal
2009-12-31Modify Forge to accept multiple hidden params (this was broken by anBharat Mediratta
API change in K24).
2009-12-31Create helper functions to create a test user, an album or image. Don't ↵Tim Almdal
create the test objects in the setup, but do it in each test.
2009-12-301) Remove the rest::not_found method and replace it with "throw new ↵Tim Almdal
Kohana_404_Exception 2) Don't use the input path to lookup the item via relative_path_cache. Instead use url::get_item_from_uri method.
2009-12-27Clean up validation the check for duplicate names or slugs, finish ↵Tim Almdal
converting the rest API to Kohana 2.4
2009-12-26Merge branch 'master' into talmdal_devTim Almdal
Conflicts: modules/gallery/controllers/albums.php modules/gallery/controllers/movies.php modules/gallery/controllers/photos.php
2009-12-24Update the gallery_rest handlers test to pass the path in as an array in the ↵Tim Almdal
request arguments property instead of the path property.