| Age | Commit message (Collapse) | Author |
|
won't get coerced to a string, and then we wind up comparing:
12345 != 12345-12321
In the old approach, they'd both be strings so they'd be inequal. But
in the new approach the first value is an integer (sinced it came from
rand()) so the second value is typecast to an integer which drops
everything after the - sign so they appear equal.
|
|
|
|
|
|
safe. Add tests to make sure that it doesn't relapse with future
Kohana changes. Fixes ticket #983.
Ref: http://gallery.menalto.com/node/93738
|
|
starts failing, the bug is fixed and we can go fix our code that works
around it.
|
|
|
|
since we can't have unsafe slugs.
Add basic_validation_test.
|
|
http://dev.kohanaphp.com/issues/2504
|
|
|
|
|
|
|
|
|
|
Conflicts:
modules/gallery/models/item.php
|
|
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original."
This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
|
|
|
|
processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original.
|
|
|
|
clauses and deletes all the entries in the table unless an array of id's are
passed as the parameter. This fix used the Database_builder to specify any where
conditions. Thanks psvo for find the first one. :-)
|
|
|
|
longer considered dirty in the logout controller.
|
|
1) Simplify gallery_rest to return flat models, no children and do no
validation for now.
2) Flatten the REST replies and use HTTP codes to indicate
success/failure instead of additional status messages.
3) Use the message and error code support in the base Exception class,
instead of brewing our own in Rest_Exception.
4) Get rid of rest::success() and rest::fail() -- we only need
rest::reply() since all failures are covered by throwing an
exception.
5) Get rid of /rest/access_key and just use /rest for authentication.
6) Inline and simplify rest::normalize_request since we only use it once
7) Change rest::set_active_user to succeed or throw an exception
8) Extract Rest_Exception::sendHeaders into rest::send_headers()
Here's what's currently broken:
1) Data validation. There currently is none
2) Logging. That's gone too
3) image block and tag code is broken
4) Tests are broken
5) No movie support
|
|
|
|
|
|
|
|
1) We do support changing the name.
2) Choose a random name to avoid conflicts.
|
|
|
|
name by Kohana_404_Exception.
|
|
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
|
|
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
|
|
so as not to impact other tests.
|
|
|
|
|
|
change I made in 20bd09ff004816ae152a2f890a24dc5e85741fac
|
|
|
|
|
|
API change in K24).
|
|
create the test objects in the setup, but do it in each test.
|
|
Kohana_404_Exception
2) Don't use the input path to lookup the item via relative_path_cache. Instead use url::get_item_from_uri method.
|
|
converting the rest API to Kohana 2.4
|
|
Conflicts:
modules/gallery/controllers/albums.php
modules/gallery/controllers/movies.php
modules/gallery/controllers/photos.php
|
|
request arguments property instead of the path property.
|
|
Corrected a problem identified with the unit tests... failed if the path was empty on PUT.
|
|
|
|
|
|
new K24 ORM).
Fix up a bad where tuple in the test.
|
|
|
|
element with the same value as the name. Yay! That was a weird and
unexpected behavior.
|
|
Database_Builder::where()
|
|
because of preamble variation in K24.
|
|
|