| Age | Commit message (Collapse) | Author |
|
Refactor the rotate code in Quick_Controller to replace the data file,
and then have gallery_event::item_updated_data_file() pick up after
the change is saved, rebuild the image and handle album covers. This
is much more portable than before and it will allow any mechanism (eg:
REST) to replace the source image.
|
|
This reverts commit 98fce83de5f772482382bfabdbcd94c25ecdbb1a.
Conflicts:
modules/gallery/tests/Item_Model_Test.php
|
|
bad idea.
This reverts commit 6425d41eddd44091b2d83ba3c3734cc6990ca581.
|
|
applicable to the current user.
|
|
indicates that we shouldn't opportunistically convert ids into REST
urls.
|
|
we can turn on with a query parameter.
|
|
deleted. Fixes ticket #1083.
|
|
|
|
characters, we'll get an empty slug. Partial fix for #1086.
|
|
|
|
|
|
|
|
|
|
|
|
not capturing all cases for setting and resetting $original, which
leads to some weird and hard to reproduce behavior.
Instead, if we need the original just reload it from the database.
This may result in a somewhat excessive load in places, but we'll have
to fix that in a later optimization pass.
|
|
|
|
before deciding whether or not we changed a value.
Change valid_name to be cascading, not parallel.
|
|
|
|
|
|
|
|
|
|
Now to move an item, you just change its parent_id.
|
|
Fix up rename_photo_test.
|
|
save() now that Kohana ticket #2504 is resolved.
|
|
|
|
|
|
|
|
since we can't have unsafe slugs.
Add basic_validation_test.
|
|
http://dev.kohanaphp.com/issues/2504
|
|
|
|
|
|
|
|
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original."
This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
|
|
processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original.
|
|
|
|
|
|
exist. fixes ticket #694
|
|
relative_url_cache so that they're safe for browser use.
|
|
|
|
Old API: $obj->original("field_name")
New API: $obj->original()->field_name
This allows us to revert the varous xxx_updated events back to passing
an original ORM as well as the the updated one. This makes for a
cleaner event API.
Old API: comment_updated($comment) { $comment->original("field_name") }
Old API: comment_updated($old, $new) { $old->field_name }
|
|
|
|
1) The item_updated event no longer takes the old and new items.
Instead we overload ORM to track the original data and make
that available via the item. This will allow us to move event
publishing down into the API methods which in turn will give us
more stability since we won't require each controller to remember
to do it.
2) ORM class now tracks the original values. It doesn't track
the original relationships (no need for that, yet)
3) Added new events:
item_deleted
group_deleted
user_deleted
|
|
Kohana makes this type of transition fairly straightforward in that
all controllers/helpers/etc are still located in the cascading
filesystem without any extra effort, except that I've temporarily
added a hack to force modules/gallery into the module path.
Rename what's left of "core" to be "application" so that it conforms
more closely to the Kohana standard (basically, just
application/config/config.php which is the minimal thing that you need
in the application directory)
There's still considerable work left to be done here.
|