| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-01-29 | Strongly type the argument list to the model::validate method. | Tim Almdal | |
| 2010-01-27 | Convert back to using ORM::factory(..., $id) instead of calling where(). | Bharat Mediratta | |
| 2010-01-27 | Prevent accidentally deleting the root album. | Bharat Mediratta | |
| 2010-01-26 | Specialize the album cover id check to allow the root album to have no | Bharat Mediratta | |
| album cover. | |||
| 2010-01-25 | Always keep the original around when updating existing items, because | Bharat Mediratta | |
| we need it for the item_updated event. | |||
| 2010-01-20 | Whitespace. | Bharat Mediratta | |
| 2010-01-20 | Stop using MY_ORM::original(). It's got very odd semantics and we are | Bharat Mediratta | |
| not capturing all cases for setting and resetting $original, which leads to some weird and hard to reproduce behavior. Instead, if we need the original just reload it from the database. This may result in a somewhat excessive load in places, but we'll have to fix that in a later optimization pass. | |||
| 2010-01-19 | Fix some validation checks to check to see if the original was loaded | Bharat Mediratta | |
| before deciding whether or not we changed a value. Change valid_name to be cascading, not parallel. | |||
| 2010-01-19 | Move data initialization into the constructor so that it happens | Bharat Mediratta | |
| before validate() is called, which is important with our two phase web controllers. Make valid_parent smarter about moving existing items, vs new items. | |||
| 2010-01-19 | Make video/x-flv a valid movie mime_type | Bharat Mediratta | |
| 2010-01-18 | Update valid_parent() to disallow moving an item inside its own hierarchy. | Bharat Mediratta | |
| Move move_to() inside save() | |||
| 2010-01-18 | Fix renaming in save() by moving the actual rename action under | Bharat Mediratta | |
| parent::save(). This is consistent with other changes because all filesystem operations happen after the database change is committed. Also, inline rename() since it's fairly simple now. | |||
| 2010-01-18 | In valid_name, don't query on the id if it's null. | Bharat Mediratta | |
| 2010-01-17 | Make set_data_file() chainable. | Bharat Mediratta | |
| 2010-01-17 | Get rid of internal_only designation -- it's too hard to enforce cleanly. | Bharat Mediratta | |
| 2010-01-17 | Move rules entirely down into validate() so that we can be more | Bharat Mediratta | |
| sophisticated but keep all our rules in one place. Add rules for most fields. | |||
| 2010-01-16 | PHPdoc. | Bharat Mediratta | |
| 2010-01-16 | Don't forget to save when we make insignificant chagnes only. | Bharat Mediratta | |
| 2010-01-16 | Make movie creation use model based validation. Move movie related | Bharat Mediratta | |
| logic from movie::create() into Item_Model | |||
| 2010-01-16 | Check for illegal extensions in valid_name() | Bharat Mediratta | |
| Fix a bug where we were not calling valid_data_file correctly. | |||
| 2010-01-16 | Convert photo uploading over to the new model based validation | Bharat Mediratta | |
| approach. - Rearrange Simple_Uploader_Controller::add_photo() to validate the form early in the process, and switch to using model based validation. - Move thumbnail generation into gallery_event::item_created() so that it's decoupled from the model. - Delete photo::create() and move all of its logic into Item_Model::save(). - Add Item_Model::$data_file to track the data file associated with new movies and photos. - Do some cleanup on the validation callbacks -- it turns out the 2nd argument is the field name not the value. | |||
| 2010-01-16 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| Conflicts: modules/gallery/models/item.php | |||
| 2010-01-16 | Don't pass MY_ORM::original() to update event handlers, since after | Bharat Mediratta | |
| parent::save() it'll be reset. Clone it first. This is an alternate fix for #978. | |||
| 2010-01-15 | Validate the model type. | Bharat Mediratta | |
| 2010-01-15 | Move model business logic out of album::create() and into | Bharat Mediratta | |
| Item_Model::save(). This makes creating albums similar to editing them and makes it difficult to create an album poorly. I expect to be able to remove a lot of code from the photo and movie helper because it's duplicated here. In order to do this, I refactored ORM_MPTT::add_to_parent() into ORM_MPTT::save() so we now add it to the parent when we do save. This allows us to call save() only once which saves a database call per add. The Albums_Controller logic is roughly the same as before. Haven't updated the tests yet, they're going to fail miserably since many of them depend on album::create() which is now gone. | |||
| 2010-01-15 | Move setting Item_Model::rand_key into Item_Model::save() since it's | Bharat Mediratta | |
| business logic. | |||
| 2010-01-15 | Use $value in valid_xxx() functions instead of the member field. They're ↵ | Bharat Mediratta | |
| equivalent, but it's more intuitive this way. | |||
| 2010-01-14 | Begin the process of converting to model based validation. Right | Bharat Mediratta | |
| now only Albums_Controller::update() supports the pattern. All form and controller based validation happening when editing an album has been moved over. Model based validation means that our REST controllers share the same validation as web controllers. We'll have consistency enforced at the model level, which is a Good Thing. The basic pattern is now: 1) Rules are in the model 2) ORM::validate() (which is called by ORM::save() but you can call it directly, too) checks the model for all the rules and throws an ORM_Validation_Exception if there are failures 3) Actions are no longer taken when you call Item_Model::__set(). Instead, they're all queued up and executed when you call Item_Model::save(). Notes: - item::validate_xxx() functions are now in Item_Model:: - We still call $form->validate() because the form can have rules (and forms triggered by events will likely continue to have rules. | |||
| 2010-01-04 | Change uppercase NULL to lowercase null to match the gallery3 style guide | Tim Almdal | |
| 2010-01-04 | Another K2.4 holder over... We had, when checking for position, ->where(, ↵ | Tim Almdal | |
| "=", NULL) which would never find any. It should have been ->where(, "is", NULL) | |||
| 2010-01-02 | Add a cache buster to the resize and file urls. This fixes ticket | Bharat Mediratta | |
| 2010-01-02 | Take precautions against deleting var/albums, var/thumbs or var/resizes. | Bharat Mediratta | |
| Fixes ticket #916. | |||
| 2009-12-22 | The default value for $offset should always be null (according to the | Bharat Mediratta | |
| new K24 ORM). Fix up a bad where tuple in the test. | |||
| 2009-12-18 | Convert a database query. | Bharat Mediratta | |
| 2009-12-16 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2009-12-16 | Adjust for the fact that movies have JPG thumbnails. Fixes ticket | Bharat Mediratta | |
| 2009-12-13 | Convert some database calls. | Bharat Mediratta | |
| 2009-11-26 | Convert some more Database::instance() calls to db::build() form. | Bharat Mediratta | |
| 2009-11-26 | ORM::find_all() now uses null as the default value for offset. | Bharat Mediratta | |
| 2009-11-26 | Overload Database_Builder to add merge_where() which takes predefined | Bharat Mediratta | |
| where clauses and adds them to the existing query. Update all existing queries that take an additional where clause to use it. | |||
| 2009-11-26 | Convert all DB where() calls to take 3 arguments. | Bharat Mediratta | |
| Convert all open_paren() calls to and_open() or or_open() as appropriate. | |||
| 2009-11-26 | ORM::$rules now has a special meaning. Use $form_rules for our | Bharat Mediratta | |
| internal rules code. | |||
| 2009-11-25 | ORM::orderby -> ORM::order_by | Bharat Mediratta | |
| 2009-11-25 | Preliminary work to cut over to Kohana 2.4 | Bharat Mediratta | |
| - Kohana::log() -> Kohana_Log::add() - Kohana::config_XXX -> Kohana_Config::instance()->XXX - Implement View::set_global in MY_View - Updated Cache_Database_Driver to latest APIs - ORM::$loaded -> ORM::loaded() - Updated item::viewable() to use K2.4 parenthesization | |||
| 2009-11-06 | Make sure the position method works for both ascending and descending sort ↵ | Tim Almdal | |
| orders. | |||
| 2009-11-04 | Modified the so that a where clause can be passed into item::get_position. ↵ | Tim Almdal | |
| Was also able to remove the sub-select from the calculation of the current position as we already have the child item containing the sort column value. Also added a where clause that ignores albums to the get_position, children and children_count method calls in photos.php and movies.php | |||
| 2009-10-30 | Log an alert when we can't load a user. | Bharat Mediratta | |
| 2009-10-27 | Refix #812, by removing the decoding in file_proxy instead of not encoding ↵ | Tim Almdal | |
| in Item_Model when creating the relative_path_cache. | |||
| 2009-10-27 | Don't url encode the components of the relative_path_cache as we they refer ↵ | Tim Almdal | |
| to file paths and they are converted back in the file proxy. Fixes ticket #812 | |||
| 2009-10-24 | Merge branch 'master' into talmdal_dev | Tim Almdal | |
 |
index : gallery3.git | |
| A clone of the Gallery3 code for testing and development. | root |
| summaryrefslogtreecommitdiff |