| Age | Commit message (Collapse) | Author |
|
|
|
|
|
This reverts commit 98fce83de5f772482382bfabdbcd94c25ecdbb1a.
Conflicts:
modules/gallery/tests/Item_Model_Test.php
|
|
bad idea.
This reverts commit 6425d41eddd44091b2d83ba3c3734cc6990ca581.
|
|
applicable to the current user.
|
|
indicates that we shouldn't opportunistically convert ids into REST
urls.
|
|
we can turn on with a query parameter.
|
|
- Pass the CSS selector of the active image in as an arg to site_menu
so that quick operations know what they're operating on.
- Change the ids from g-{photo,movie}-id to the generic g-item-id
- Initialize ajax handlers for site menu on the photo and movie page
- Drop the movie context menu, it's now in the site menu
|
|
|
|
characters, we'll get an empty slug. Partial fix for #1086.
|
|
just entity.
TESTS ARE NOT UPDATED YET.
- Fix item_rest::get() to maintain the proper sort order, which
requires duplicating some Item_Model code.
- Elide "weight" from the REST version of item
- Adjust the weight of members according to the order they're returned
from the client. You can't add or remove members here, you can only
reorder them.
- Changed the wire protocol to handle more complex values.
Now "entity" and "members" are JSON encoded. The Gallery3
helper does this correctly.
- Changed the wire protocol for tag_item -- now it stores the
tag and item urls in the entity, not as members. This is more
consistent.
- Added missing security for renaming and deleting tags.
- Got rid of vestigial tag_rest::post(). We add/remove tags
via the relationship.
|
|
|
|
|
|
name of the field containing the url to the fullsize image to file_url instead of fullzie_url
|
|
images.
|
|
for an item. In addition, add links to the images.
|
|
This reverts commit 3439671bcfb99c1884285e4b4e53295f044e688f.
|
|
2) Standardize the structure of members so that client programs can consistently
parse the return information.
3) Added a summary parameter so that client programs can easily determine if the
information returned is summary (item type, item title) or the full meal deal
|
|
separate from a successful or failed login.
1) Rename user_login_failed event to user_authenticate_failed
2) Rename failed_logins table to failed_auth (bump Gallery module to
v27 to rename the table)
3) auth::too_many_failed_logins -> auth::too_many_failures
4) auth::record_failed_auth_attempts -> auth::record_failed_attempts
auth::clear_failed_auth_attempts -> auth::clear_failed_attempts
|
|
mostly issues around uninitialized variables, calling non-static
functions in a static context, calling Session functions directly
instead of on its singleton, passing non-variables by reference, and
subclasses not using the same interface as the parent class.
|
|
|
|
|
|
minute after there have been 5 consecutive failed login attempts.
Fix for ticket #589.
|
|
|
|
|
|
|
|
album cover.
|
|
we need it for the item_updated event.
|
|
|
|
not capturing all cases for setting and resetting $original, which
leads to some weird and hard to reproduce behavior.
Instead, if we need the original just reload it from the database.
This may result in a somewhat excessive load in places, but we'll have
to fix that in a later optimization pass.
|
|
before deciding whether or not we changed a value.
Change valid_name to be cascading, not parallel.
|
|
before validate() is called, which is important with our two phase web
controllers.
Make valid_parent smarter about moving existing items, vs new items.
|
|
|
|
Move move_to() inside save()
|
|
parent::save(). This is consistent with other changes because all
filesystem operations happen after the database change is committed.
Also, inline rename() since it's fairly simple now.
|
|
|
|
|
|
|
|
sophisticated but keep all our rules in one place.
Add rules for most fields.
|
|
|
|
|
|
logic from movie::create() into Item_Model
|
|
Fix a bug where we were not calling valid_data_file correctly.
|
|
approach.
- Rearrange Simple_Uploader_Controller::add_photo() to validate
the form early in the process, and switch to using model based
validation.
- Move thumbnail generation into gallery_event::item_created() so
that it's decoupled from the model.
- Delete photo::create() and move all of its logic into
Item_Model::save().
- Add Item_Model::$data_file to track the data file associated
with new movies and photos.
- Do some cleanup on the validation callbacks -- it turns out the
2nd argument is the field name not the value.
|
|
Conflicts:
modules/gallery/models/item.php
|
|
parent::save() it'll be reset. Clone it first.
This is an alternate fix for #978.
|
|
|
|
Item_Model::save(). This makes creating albums similar to editing
them and makes it difficult to create an album poorly. I expect to be
able to remove a lot of code from the photo and movie helper because
it's duplicated here.
In order to do this, I refactored ORM_MPTT::add_to_parent() into
ORM_MPTT::save() so we now add it to the parent when we do save. This
allows us to call save() only once which saves a database call per
add.
The Albums_Controller logic is roughly the same as before.
Haven't updated the tests yet, they're going to fail miserably since
many of them depend on album::create() which is now gone.
|
|
business logic.
|
|
equivalent, but it's more intuitive this way.
|