| Age | Commit message (Collapse) | Author |
|---|
|
Instead of overwriting Kohana_Exception::handle() (which we were doing
in MY_Kohana_Exception) we instead use their existing template system.
gallery/views/kohana/error.php overrides system/views/kohana/error.php
and is the standard error template for all exceptions. Our version of
error.php figures out the appropriate view based on context (cli,
authenticated admin, guest viewing a 404, guest viewing a system
error) and delegates appropriately. Each delegated view has a narrow
responsibility.
This paves the way for us to add new error views per module. For
example, the rest module will define its own template in
Rest_Exception and then its exceptions can be rendered the way that it
wants (json encoded, in that case).
|
|
|
|
we specify the continue_url in the session, but we store it in the
login form so that we can propagate it across the session creation
that happens at login time.
|
|
- Pass the CSS selector of the active image in as an arg to site_menu
so that quick operations know what they're operating on.
- Change the ids from g-{photo,movie}-id to the generic g-item-id
- Initialize ajax handlers for site menu on the photo and movie page
- Drop the movie context menu, it's now in the site menu
|
|
security check. Not sure why the patch worked for some and not for
others, but this should resolve it either way. Fixes ticket #1123.
|
|
|
|
admin pages, just like in non-admin pages.
TODO: Set $view->page_title in the many admin controllers we have. I just set it for admin_maintenance.php to show how it's intended to be used. I copied the title from views/admin_maintenance.html.php to the controller.
|
|
passwords, hashes or personally identifiable information.
|
|
a recent refactoring / fix.
|
|
|
|
|
|
array from the Cache.
Until now, we loaded hundreds of translation messages row by row, and unserializing one by one at bootstrap time. That amounted to a significant percentage of the complete request time. This approach is more than 10x faster.
|
|
tag value, but it was always an array of keys / tags.
(compare to system/libraries/Cache.php and the File.php driver)
|
|
|
|
by casting SafeString instances to string in translate()."
This reverts commit 4ca55a90ee2f8e1d8595b0ec53a601d6c65475f6.
|
|
the platform's locale names.
|
|
casting SafeString instances to string in translate().
|
|
|
|
|
|
attributes, use & not &)
|
|
registered users (not to admins though). And show a login form to guests for 404 (incl. insufficient view permissions) errors.
|
|
strings instead of dying. This at least gives us graceful degradation.
Fixes ticket #764, patch thanks to djnz.
|
|
|
|
for a config value "force_rtl" which will layout the gallery pages in rtl mode
without having to change to an language that is no longer understandable to the
developer.
Adding the line "$config['force_rtl'] = true;" to the config/locales.php file
will make it happen.
|
|
|
|
mostly issues around uninitialized variables, calling non-static
functions in a static context, calling Session functions directly
instead of on its singleton, passing non-variables by reference, and
subclasses not using the same interface as the parent class.
|
|
|
|
Update the way we include the hidden CSRF field for InPlaceEdit.
|
|
change providers otherwise the user_installer code is going to be
calling auth::login() which causes all kinds of unexpected weirdness,
like it triggers the handler in gallery_event which detects graphics
toolkits, and that's only supposed to run on the first admin login.
|
|
|
|
failure. Else, we can get into an infinite recursion.
|
|
Conflicts:
modules/gallery/tests/xss_data.txt
|
|
user menu. Since the information displayed is identical in both admin and
theme views, it makes sense to combine the generation to it is done in a common
location.
|
|
provider and then reinstall the current one.
|
|
(change_provider) with an initialization callback.
|
|
Item_Model. If there's a need to make this public, we should override
it in Item_Model and throw an exception there.
|
|
|
|
generate $original when we needed it, resulting in inconsistent
behavior.
|
|
|
|
|
|
the latest data.
|
|
a required
parameter for the Gallery driver.
|
|
to be the original. That should be safe because we're already
guarding __set, __unset and save.
|
|
model based validation.
|
|
Conflicts:
modules/gallery/models/item.php
|
|
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original."
This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
|
|
This reverts commit e41ad23a8ea05d28a99d12c01d8f317455b1d361.
|
|
|
|
filling it an atomic operation.
|
|
Item_Model::save(). This makes creating albums similar to editing
them and makes it difficult to create an album poorly. I expect to be
able to remove a lot of code from the photo and movie helper because
it's duplicated here.
In order to do this, I refactored ORM_MPTT::add_to_parent() into
ORM_MPTT::save() so we now add it to the parent when we do save. This
allows us to call save() only once which saves a database call per
add.
The Albums_Controller logic is roughly the same as before.
Haven't updated the tests yet, they're going to fail miserably since
many of them depend on album::create() which is now gone.
|
