| Age | Commit message (Collapse) | Author |
|---|
|
call HTMLPurifier->purify()
|
|
1) Include the url in the cache key so that if the Gallery moves, we
don't use old cached entries.
2) Use the relative path to files in the comments that we embed in our
files so that we don't leak local paths.
|
|
|
|
accept PHP constructs like arrays (the tests were choking on this).
Update tests to reflect the new `key` column.
|
|
|
|
in my last refactor):
1) Actually combine the JS (I was only combining the CSS)
2) Add line breaks between the files and comment them so that we can
find a specific file inside the blob.
3) Add an HTML comment to help developers figure out why they can't
find their CSS/JS.
|
|
doesn't fix the problem that we need to support multiple media types
(the original code had superfish using just "screen", and some other
deviations).
There's no code yet to support multiple media types, but it would not
be too difficult to create buckets based on media.
|
|
html functions to generate the resulting elements. Add phpdoc.
|
|
|
|
1) CSS files are added to the combined version by use of $theme->css() or $theme->css_theme() methods
2) url references in the css are converted to full paths as opposed to relative
3) @import statements in the css are resolved as well.
4) need to move the [if IE] statements into the css files so the will be honored in the browser. currently the ie fix css are always included.
|
|
|
|
Implement the combined css functionality. Local url references and replace with absolute urls instead of relative.
|
|
Conflicts:
modules/gallery/libraries/Theme_View.php
themes/admin_default/views/admin.html.php
|
|
|
|
$theme->theme_script().
|
|
Gallery_View base class from Theme_View and Admin_View.
1) Move all the theme specific jquery stuff from gallery_theme::head()
and admin_head() into the theme files. Use $theme->script() as
appropriate.
2) Get rid of the extra boolean on $theme->url() that we were using so
that we could call $theme->script($theme->url(...)) -- add
$theme->theme_script() instead (poorly named, but still clearer than
what we had before)
3) Fix the bug that combined scripts didn't work at all in the admin
theme.
4) Get rid of $theme->display() in favor of new View(...)
|
|
combined/javascript.
|
|
other gallery 3 tables. Update the driver to match, add more upgrader
code, update the installer block and change the gallery module version
to 6.
|
|
1) Drop the *_modified key, we don't really need it. The modification date is not
relevant to our browser caching strategy.
2) Fix multiple issues with the Expires header and just hardcode it to the biggest
possibly value for code clarity.
3) print the $content out directly instead of using fwrite
4) Minor cleanups in the installer.
|
|
respect the HTTP_IF_MODIFIED_SINCE header request.
|
|
ticket #485 and gives us the extra adavantage of not having to serialize the data (as the database driver handles that for us)
|
|
unit tests pass
|
|
|
|
|
|
1) Eliminate digibug_album.html
2) Get rid of the $(document).ready() in digibug.js and rename popUp() to
digibug_popup() then just make direct calls to digibug_popup() in the
menu urls.
|
|
|
|
admin_head functions to specify javascript files that are required for this page.
In this commit, these script files are expressed at the end of the head or admin_head calls and appended to the beginning of the block stack. In a future commit these will be combined and gzipped for download.
|
|
gallery_theme::admin_head. This allows us to potentially manage the scripts like we do in g2 (single file and compressed)
2) Change Theme_View::_call to always call the gallery_theme::$function first.
|
|
|
|
Move the creation of the setting menu back to gallery_menu::admin, now that
there is a mechanism to remove empty menu items
|
|
1) Stored the menu element type in the menu element
2) Scanned the menu before display removing any empty sub menus.
Went with the removal approach because there will more users than developers
|
|
|
|
while. This fixes ticket #342.
The bug is that we were using $item instead of $theme->item(). But we
were also not special casing tags properly, and they are effectively
first class citizens (at least for now) so treat them properly. Also,
set page_title by default in the theme so that we don't have to do an
empty() check on it (makes the theme easier to read) and move the
title out of Tags_Controller so that the theme has more control over
it.
|
|
Move the <link> for the container feed (either gallery/album/<id> or
tag/tag/<id>) back into gallery_theme
|
|
more intuitive for themers.
|
|
|
|
|
|
make "Add from Server" a 2nd option there.
This requires adding the Menu::remove() API function.
|
|
Ticket 148.
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
Fixes ticket #301
|
|
gallery module. This type of mass update is prone to some small bugs.
|
|
Kohana makes this type of transition fairly straightforward in that
all controllers/helpers/etc are still located in the cascading
filesystem without any extra effort, except that I've temporarily
added a hack to force modules/gallery into the module path.
Rename what's left of "core" to be "application" so that it conforms
more closely to the Kohana standard (basically, just
application/config/config.php which is the minimal thing that you need
in the application directory)
There's still considerable work left to be done here.
|
