| Age | Commit message (Collapse) | Author |
|---|
|
children(), thanks Tim!
|
|
remove Gallery3 concepts from ORM_MPTT.
The following API methods:
ORM_MPTT::children
ORM_MPTT::children_count
ORM_MPTT::descendants
ORM_MPTT::descendants_count
All now take a $where clause that allow you to pass through additional
field parameters.
old API:
$album->children(10, 0, "photos")
$album->children_count("photos")
new API:
$album->children(10, 0, array("type" => "photos"))
$album->children_count(array("type" => "photos"))
This gives us a more flexible API and simplifies the code. While I
was in there, I changed the way we deal with default orderby values so
that we just assign the default value in the function definition,
which allows us to get rid of all conditionals in the implementation
which results in simpler code.
|
|
specify a type parameter, so tht we can filter the children based
on type (i.e. album, photo, etc).
In addition, expose the sort order, so that we can specify the order
we want to return the children.
|
|
Old API: $obj->original("field_name")
New API: $obj->original()->field_name
This allows us to revert the varous xxx_updated events back to passing
an original ORM as well as the the updated one. This makes for a
cleaner event API.
Old API: comment_updated($comment) { $comment->original("field_name") }
Old API: comment_updated($old, $new) { $old->field_name }
|
|
View. This allows modules to piggyback on it.
|
|
|
|
can call admin_menu.
|
|
This is the first step towards having a simple, lightweight and
unified API for module interaction.
|
|
of either a url to a script file or in line text which will be included
in a script block.
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
|
|
theme. Because the theme comes first, this means that themes can
override any module resources, at the cost that we no longer have
namespacing for JS and CSS files.
The only file getting used outside of this model is
themes/default/screen.css which is used in the admin theme. I fixed
that by copying screen.css into admin_default and renaming its
screen.css to admin_screen.css. I also copied over all the images
that it was referencing.
Fixes tickets #48 and #539.
Theme API changes:
- theme_script(), theme_url() and theme_css() are no longer needed
- script(), url() and css() now refer to the first matching asset in
the module load path, where gallery3/lib is at the end of the path
|
|
exception from View::render()
|
|
Fixes ticket #194
|
|
Fixes ticket #554.
|
|
zlib.output_compression=On
|
|
old ORM relationships from hanging around, which was causing problems
when doing MPTT manipulations (resulting in incorrect permission
propagation-- very bad!)
|
|
1) The item_updated event no longer takes the old and new items.
Instead we overload ORM to track the original data and make
that available via the item. This will allow us to move event
publishing down into the API methods which in turn will give us
more stability since we won't require each controller to remember
to do it.
2) ORM class now tracks the original values. It doesn't track
the original relationships (no need for that, yet)
3) Added new events:
item_deleted
group_deleted
user_deleted
|
|
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
|
|
1) Stop changing the menu classes in JS, instead allow us to specify
it in the Menu class itself and then set it to be gThumbMenu in Theme_View
2) Move the gThumbMenu init code to the bottom of the $(document).ready() block;
something in there was interfering with it.
|
|
|
|
|
|
|
|
thumb menu shows up when it has nothing in it.
|
|
|
|
call HTMLPurifier->purify()
|
|
1) Include the url in the cache key so that if the Gallery moves, we
don't use old cached entries.
2) Use the relative path to files in the comments that we embed in our
files so that we don't leak local paths.
|
|
|
|
accept PHP constructs like arrays (the tests were choking on this).
Update tests to reflect the new `key` column.
|
|
|
|
in my last refactor):
1) Actually combine the JS (I was only combining the CSS)
2) Add line breaks between the files and comment them so that we can
find a specific file inside the blob.
3) Add an HTML comment to help developers figure out why they can't
find their CSS/JS.
|
|
doesn't fix the problem that we need to support multiple media types
(the original code had superfish using just "screen", and some other
deviations).
There's no code yet to support multiple media types, but it would not
be too difficult to create buckets based on media.
|
|
html functions to generate the resulting elements. Add phpdoc.
|
|
|
|
1) CSS files are added to the combined version by use of $theme->css() or $theme->css_theme() methods
2) url references in the css are converted to full paths as opposed to relative
3) @import statements in the css are resolved as well.
4) need to move the [if IE] statements into the css files so the will be honored in the browser. currently the ie fix css are always included.
|
|
|
|
Implement the combined css functionality. Local url references and replace with absolute urls instead of relative.
|
|
Conflicts:
modules/gallery/libraries/Theme_View.php
themes/admin_default/views/admin.html.php
|
|
|
|
$theme->theme_script().
|
|
Gallery_View base class from Theme_View and Admin_View.
1) Move all the theme specific jquery stuff from gallery_theme::head()
and admin_head() into the theme files. Use $theme->script() as
appropriate.
2) Get rid of the extra boolean on $theme->url() that we were using so
that we could call $theme->script($theme->url(...)) -- add
$theme->theme_script() instead (poorly named, but still clearer than
what we had before)
3) Fix the bug that combined scripts didn't work at all in the admin
theme.
4) Get rid of $theme->display() in favor of new View(...)
|
|
combined/javascript.
|
|
other gallery 3 tables. Update the driver to match, add more upgrader
code, update the installer block and change the gallery module version
to 6.
|
|
1) Drop the *_modified key, we don't really need it. The modification date is not
relevant to our browser caching strategy.
2) Fix multiple issues with the Expires header and just hardcode it to the biggest
possibly value for code clarity.
3) print the $content out directly instead of using fwrite
4) Minor cleanups in the installer.
|
|
respect the HTTP_IF_MODIFIED_SINCE header request.
|
|
ticket #485 and gives us the extra adavantage of not having to serialize the data (as the database driver handles that for us)
|
|
unit tests pass
|
|
|
|
|
