| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-01-20 | Make move_to protected since we don't want folks calling it on | Bharat Mediratta | |
| Item_Model. If there's a need to make this public, we should override it in Item_Model and throw an exception there. | |||
| 2010-01-20 | Oops, bug in save() -- we weren't returning the saved value! | Bharat Mediratta | |
| 2010-01-20 | Delete MY_ORM::original(). We did not have proper containment to | Bharat Mediratta | |
| generate $original when we needed it, resulting in inconsistent behavior. | |||
| 2010-01-18 | Whitespace. | Bharat Mediratta | |
| 2010-01-18 | Switch from ORM_MPTT::$db_builder to db::build(). | Bharat Mediratta | |
| 2010-01-18 | in move_to(), move the lock to before we do any calculations so that we have ↵ | Bharat Mediratta | |
| the latest data. | |||
| 2010-01-17 | Change IdentityProvider::create_user() to take $email as well, since that's ↵ | Bharat Mediratta | |
| a required parameter for the Gallery driver. | |||
| 2010-01-17 | If we call original() and there's no $original yet, then consider this | Bharat Mediratta | |
| to be the original. That should be safe because we're already guarding __set, __unset and save. | |||
| 2010-01-16 | Get rid of add_rules_from() -- it's no longer necessary now that we're doing ↵ | Bharat Mediratta | |
| model based validation. | |||
| 2010-01-16 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| Conflicts: modules/gallery/models/item.php | |||
| 2010-01-15 | Revert "Fix for ticket #978. Don't reset the original property as part of ↵ | Bharat Mediratta | |
| the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6. | |||
| 2010-01-15 | Revert "Did the old commit then save trick" | Bharat Mediratta | |
| This reverts commit e41ad23a8ea05d28a99d12c01d8f317455b1d361. | |||
| 2010-01-15 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-15 | Call parent::save() before releasing the lock to make creating the hole and ↵ | Bharat Mediratta | |
| filling it an atomic operation. | |||
| 2010-01-15 | Move model business logic out of album::create() and into | Bharat Mediratta | |
| Item_Model::save(). This makes creating albums similar to editing them and makes it difficult to create an album poorly. I expect to be able to remove a lot of code from the photo and movie helper because it's duplicated here. In order to do this, I refactored ORM_MPTT::add_to_parent() into ORM_MPTT::save() so we now add it to the parent when we do save. This allows us to call save() only once which saves a database call per add. The Albums_Controller logic is roughly the same as before. Haven't updated the tests yet, they're going to fail miserably since many of them depend on album::create() which is now gone. | |||
| 2010-01-13 | Did the old commit then save trick | Tim Almdal | |
| 2010-01-13 | Fix for ticket #978. Don't reset the original property as part of the save ↵ | Tim Almdal | |
| processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original. | |||
| 2010-01-08 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-08 | Remove stray semicolons. | Bharat Mediratta | |
| 2010-01-08 | Remove the display of the "body_attributes" div when in debug mode. debug ↵ | Tim Almdal | |
| mode is by default set up to add new div's to display the location of the content. "body_attributes" are attributes on the body tag and trying to add content introduces an extra > in the html stream. | |||
| 2010-01-08 | Expect merge_where and merge_or_where to handle empty tuples. | Bharat Mediratta | |
| 2009-12-27 | Fix a bug where we weren't replacing table names when there's no | Bharat Mediratta | |
| prefix. This is wrong because even when there's no prefix we have to get rid of the {curly} braces. | |||
| 2009-12-22 | Don't use as_array() on the result from db::build()->execute() -- it's no ↵ | Bharat Mediratta | |
| longer necessary. | |||
| 2009-12-22 | The default value for $offset should always be null (according to the | Bharat Mediratta | |
| new K24 ORM). Fix up a bad where tuple in the test. | |||
| 2009-12-21 | Updates for the latest version of Kohana 2.4: | Bharat Mediratta | |
| 1) Controller::$input is gone -- use Input::instance() now 2) Handle new 'database.<default>.connection.params' parameter 3) Handle new 'cache.<default>.prefix' parameter | |||
| 2009-12-21 | Fix some bugs in the cache database driver, and update the tests for K24. | Bharat Mediratta | |
| 2009-12-21 | Add Database::set_default_instance() for tests | Bharat Mediratta | |
| 2009-12-17 | Simplify add_table_prefixes. In Kohana 2.4, it returns the bare table | Bharat Mediratta | |
| name, not the prefixed one so this makes our logic easier. | |||
| 2009-12-06 | Add the current file/line at the top of the trace. | Bharat Mediratta | |
| 2009-12-06 | Overload Kohana_Exception::text() to dump out the complete stack trace | Bharat Mediratta | |
| so that we have useful data in the logs. | |||
| 2009-12-06 | Oops, removed the overload for query() before, we need this back so | Bharat Mediratta | |
| that we can prefix table names properly. | |||
| 2009-12-05 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2009-12-04 | Reload relevant models after acquiring a lock so that we don't make | Bharat Mediratta | |
| database calls based on obsolete data, which can lead to data corruption. Fixes ticket #926. | |||
| 2009-12-02 | Rename the "upload_limit" variable to "simultaneous_upload_limit" for | Bharat Mediratta | |
| clarity, since it only limits concurrency not the number of actual uploads. Move the default-setting code into the upgrader so that we avoid creating the variable as a side-effect of the view (personal preference to avoid side-effect code since it's led to problems in the past). | |||
| 2009-12-02 | Allow users to override the number of simulatenous uploads. This setting ↵ | Tim Almdal | |
| won't appear until after they have attempted to upload at least once and have issues. | |||
| 2009-12-02 | Use select() instead of select("*") | Bharat Mediratta | |
| 2009-12-02 | Convert more database calls over to the new format | Bharat Mediratta | |
| - admin/maintenance page loads, the rebuild thumbs/resizes task works - Fixed up some conversion bugs in the Cache driver | |||
| 2009-11-29 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| Conflicts: modules/gallery/helpers/theme.php modules/gallery/libraries/Admin_View.php modules/gallery/libraries/Theme_View.php | |||
| 2009-11-28 | Give the theme a chance to handle theme function callbacks as well. | Bharat Mediratta | |
| 2009-11-27 | Move the theme fallback checking into theme::load_themes() so that | Bharat Mediratta | |
| we're calling it once per request. | |||
| 2009-11-26 | Convert some more Database::instance() calls to db::build() form. | Bharat Mediratta | |
| 2009-11-26 | ORM::find_all() now uses null as the default value for offset. | Bharat Mediratta | |
| 2009-11-26 | Overload Database_Builder to add merge_where() which takes predefined | Bharat Mediratta | |
| where clauses and adds them to the existing query. Update all existing queries that take an additional where clause to use it. | |||
| 2009-11-26 | Convert all DB where() calls to take 3 arguments. | Bharat Mediratta | |
| Convert all open_paren() calls to and_open() or or_open() as appropriate. | |||
| 2009-11-26 | ORM::$rules now has a special meaning. Use $form_rules for our | Bharat Mediratta | |
| internal rules code. | |||
| 2009-11-25 | Move the CSRF initialization into the constructor, I don't see why we | Bharat Mediratta | |
| need it also in render(). | |||
| 2009-11-25 | Make globals work if you access the the variables directly with | Bharat Mediratta | |
| $v->foo instead of doing it in a rendered template. | |||
| 2009-11-25 | Fix set_global() to be more elegant and preserve local trumping | Bharat Mediratta | |
| 2009-11-25 | Switch from stdClass to arrays for global data. | Bharat Mediratta | |
| 2009-11-25 | Call execute() after upate() and insert(). | Bharat Mediratta | |
