| Age | Commit message (Collapse) | Author |
|---|
|
uploader.
|
|
semantic sense.
|
|
the end which triggers .gallery_show_loading(). Not a complete fix
for #817 but it's a start and it takes care of one place where we have
a long running process.
|
|
Instead of overwriting Kohana_Exception::handle() (which we were doing
in MY_Kohana_Exception) we instead use their existing template system.
gallery/views/kohana/error.php overrides system/views/kohana/error.php
and is the standard error template for all exceptions. Our version of
error.php figures out the appropriate view based on context (cli,
authenticated admin, guest viewing a 404, guest viewing a system
error) and delegates appropriately. Each delegated view has a narrow
responsibility.
This paves the way for us to add new error views per module. For
example, the rest module will define its own template in
Rest_Exception and then its exceptions can be rendered the way that it
wants (json encoded, in that case).
|
|
|
|
|
|
item::move(source, target) helper when the parent member has changed.
Using the move method insures that names and slugs that could conflict
in the target album are resolved properly. Changed the item::move
method so it returns a message to be displayed if the caller chooses.
And changed the move controller to display the message returned by the
move if the item name was renamed as part of the move."
Rolling this back for a couple of reasons:
1) Bug in move.php ("message.info" is not a function name)
2) Having the message come back from the API call as a side-effect is
sloppy. We should find a cleaner way to do this checking.
3) having item::move() call save() on any changed values in the ORM
is counter-intuitive. Move should move, save should save.
I think the right approach here is to roll the move() code properly into
save().
This reverts commit 2492280cc0ec9eb64a8daeccc7b5698ece7fea66.
|
|
method, which encapsulates saving an item and handling name and slug
conflicts. Call this instead of doing a save directly."
Rolled this back because it fails KISS. We already have an API for
saving models with Item_Model::save() that's consistent with all of
our other model code. Adding a new way to save items is confusing and
inconsistent.
This reverts commit 9504f71efcadc7ed27f6f09e5d663e8025bf3b86.
|
|
encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly.
|
|
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move.
|
|
to weight.
|
|
itemm::move(source, target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Also, only change the weights of the album children if the item sort_column is set to weight."
This reverts commit 603d4640141a43350f50da747d747456b28fdd93.
|
|
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Also, only change the weights of the album children if the item sort_column is set to weight.
|
|
|
|
|
|
|
|
|
|
we specify the continue_url in the session, but we store it in the
login form so that we can propagate it across the session creation
that happens at login time.
|
|
reauth code.
|
|
it requires us to reproduce a bunch of complex routing logic.
Instead, just have the logout link generating code generate a link
that's visible to guests.
|
|
|
|
bad idea.
This reverts commit 6425d41eddd44091b2d83ba3c3734cc6990ca581.
|
|
part of a REST request. Format the exception as a json encoded text string so the client can extract the fault information if they so choose.
|
|
indicates that we shouldn't opportunistically convert ids into REST
urls.
|
|
|
|
ticket #1157. Thanks to psvo.
|
|
generates an error if we call file() on it. Fixes ticket #1149.
|
|
|
|
to $entity based params.
|
|
|
|
it's returning a query, so the caller can add the where clause
himself. This makes for a cleaner API.
|
|
which deactivates modules on upgrade. No idea why we did that, but it
breaks upgrading because it deactivates any module that's been
upgraded.
|
|
|
|
so that the File_Structure_Test will pass.
|
|
increment the weight count (even if it is equal to the weight of the current child)
|
|
rest/gallery/items?urls=... request. This allows the client to pass the entire list of member urls and have the rest server filter the results based on the specified types.
(cherry picked from commit 3fe10b15cf9359b66452c24965df575203e8af8e)
|
|
Add the query parameter ancestors_for=<url> to provide a restful way to retrieve the ancestors of an item.
(cherry picked from commit e9c8a8ae532e785ab95e6b43864c93b485785d6c)
Conflicts:
modules/gallery/helpers/items_rest.php
|
|
exception before trying to create the item.
|
|
increment the weight count (even if it is equal to the weight of the current child)
|
|
rest/gallery/items?urls=... request. This allows the client to pass the entire list of member urls and have the rest server filter the results based on the specified types.
(cherry picked from commit 3fe10b15cf9359b66452c24965df575203e8af8e)
|
|
Add the query parameter ancestors_for=<url> to provide a restful way to retrieve the ancestors of an item.
(cherry picked from commit e9c8a8ae532e785ab95e6b43864c93b485785d6c)
Conflicts:
modules/gallery/helpers/items_rest.php
|
|
- Pass the CSS selector of the active image in as an arg to site_menu
so that quick operations know what they're operating on.
- Change the ids from g-{photo,movie}-id to the generic g-item-id
- Initialize ajax handlers for site menu on the photo and movie page
- Drop the movie context menu, it's now in the site menu
|
|
|
|
the site_menu.
|
|
deleted. Fixes ticket #1083.
|
|
|
|
Having a members sidebar element indicates to the rest clients that this is a resource collection.
Conflicts:
modules/gallery/helpers/items_rest.php
|
|
This makes it consistent to the rest client that collections will have a members element.
|
|
|
|
|
