summaryrefslogtreecommitdiff
path: root/modules/gallery/helpers
AgeCommit message (Collapse)Author
2009-09-07Add support for a per-item "slug" which will be the user-visible urlBharat Mediratta
component for that given item. Album hierarchies are represented by nested slugs. By default, we convert the filename to a slug when you create an album, photo or movie.
2009-09-07Quiet down ffmpeg in movie::extract_frame()Bharat Mediratta
2009-09-05Bugfixes for locales::locale_from_http_request(), and adding tests.Andy Staudacher
(And the tests should illustrate that kohana 2.4's API doesn't quite fit our purpose of simply getting the best match between the accepted (client) and the installed (g3) locales.)
2009-09-05Change the module installer so that you don't need to provide your ownBharat Mediratta
install() function if all you're going to do is to set the version of the module from module.info into the database. This means that for some simple modules, you don't need an install.php file at all.
2009-09-04Add @todo to replace locales::locale_from_http_request()Bharat Mediratta
request::accepts_language() when we upgrade to Kohana 2.4
2009-09-04Add new locale preferences: Adding per session (cookie) locale preferences ↵Andy Staudacher
and check the browser's / OS' locale preferences. Ticket 582.
2009-09-02Change graphics::generate() API so that it doesn't return a boolean,Bharat Mediratta
instead it throws an exception if there's a problem. The normal case for graphics::generate is that it's going to succeed. It'll only fail if something un-handleable went wrong, so just use the resulting exception.
2009-09-02Deal with the aftermath of adding sharpen() calls. Since GD does notBharat Mediratta
support it, this causes crashes as soon as you try to use it, which breaks a bunch of our tests. Also, give the user some idea that sharpen() is missing in the UI. Fixes #689.
2009-09-01Allow anything to be made an album cover, except for direct childrenBharat Mediratta
of the root album (which has no visible album cover, so no point in offering that option). This fully resolves #705.
2009-08-31Don't include Make this the album's cover in context menu's for albums. #705Chad Kieffer
2009-08-31Add icons to context menu for albums. I'm open to other options, if folks ↵Chad Kieffer
think there's something better in the jQuery UI themeroller set.
2009-08-31XSS review fixes (mostly adding missing html::mark_clean()) calls.Andy Staudacher
2009-08-31Rename mark_safe() to mark_clean()Andy Staudacher
2009-08-30Merge commit 'upstream/master'Andy Staudacher
Conflicts: modules/gallery/views/l10n_client.html.php modules/organize/views/organize_tree.html.php modules/server_add/helpers/server_add_event.php
2009-08-30Tabs to spaces cleanupAndy Staudacher
2009-08-30Rename clean_js to js_string and have it return a complete JS string (with ↵Andy Staudacher
delimiters) instead of just the string contents. Benefits: Using json_encode(), which is very robust. And as a user, it's clearer how to use this API compared to what it was before.
2009-08-30Change all instances of SafeString::of_safe_html() to html::mark_safe() in ↵Andy Staudacher
views.
2009-08-29Update all code to use helper method html::clean(), html::purify(), ... ↵Andy Staudacher
instead of SafeString directly.
2009-08-29Adding html::clean(), ::purify(), etc.Andy Staudacher
2009-08-29Remove try/catch in resize() since that will swallow any exceptionsBharat Mediratta
that we generate when resizing.
2009-08-29Undo url helper changes - url methods no longer return a SafeString.Andy Staudacher
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
2009-08-29Fix for ticket #628:Tim Almdal
1) increased gallery module version to 11 2) added image_sharpened parameter to the gallery module 3) sharpen all resizes.
2009-08-29Merge commit 'upstream/master'Andy Staudacher
Conflicts: modules/akismet/views/admin_akismet.html.php modules/comment/helpers/comment_rss.php modules/gallery/helpers/gallery_rss.php modules/gallery/libraries/I18n.php modules/gallery/views/permissions_browse.html.php modules/gallery/views/simple_uploader.html.php modules/info/views/info_block.html.php modules/organize/controllers/organize.php modules/organize/views/organize.html.php modules/organize/views/organize_album.html.php themes/default/views/album.html.php themes/default/views/movie.html.php themes/default/views/photo.html.php
2009-08-29Refactor all calls of p::clean() to SafeString::of() and p::purify() to ↵Andy Staudacher
SafeString::purify(). Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
2009-08-29Add more factory methods for convenience:Andy Staudacher
SafeString::purify() and SafeString::of_safe_html(). Removing SafeString::mark_html_safe() since it's no longer needed.
2009-08-29Merge branch 'talmdal_branch' of git@github.com:gallery/gallery3Bharat Mediratta
2009-08-29Fix for 641... extend viewable functionality to comments. Viewable unit test ↵Tim Almdal
is not working.
2009-08-29Have url::site() and other methods return a SafeString, just as t() and t2().Andy Staudacher
Benefits: - url::site() is often used in views and we can ensure in the url class that returned strings are indeed safe for use in HTML. Makes the list of vars of unknown safety status shorter. - url::site() is often used as message parameter to t() and t2(). The parameter would be HTML-escaped if it wasn't marked as safe HTML already. Makes the usage simpler / shorter.
2009-08-29* created new generic "Add" dropdown in the site menu. this should take care ↵jhilden
of ticket #537 * removed start/stop translation menu items from the admin, since they are on the languags admin page now
2009-08-29Adding SafeString which is going to replace p::clean() and p::purify().Andy Staudacher
Refactoring of Xss_Security_Test. t() and t2() return a SafeString instance. TODO: - Update all code to use SafeString where appropriate. - Update golden fole of Xss_Security_Test - Stop reporting CLEAN vars in Xss_Security_Test
2009-08-28Display the sort order in the Organize dialog, and allow users toBharat Mediratta
change the sort order on the fly.
2009-08-28Rename sort columns:Bharat Mediratta
* Order Added => Manual * Capture Date => Date captured * Creation Date => Date uploaded * Updated Date => Date modified Set the default sort order to "created" which mimics what we had before, expt that it is not manual.
2009-08-27Properly deal with invalid images. This fixes ticket #611 which showsBharat Mediratta
a BMP masquerading as a .jpg causing us to be unable to rebuild resizes and thumbnails. Now if that happens, we discard the file, log it and move on.
2009-08-27Remove 'ENGINE=InnoDB' specification from tables that we create. UseBharat Mediratta
the system's default table specification. Fixes ticket #597.
2009-08-19Change the setting of page type from "item" to "photo". Thre is no page typeTim Almdal
of item. All other references use photo for non album and non dynamic pages. Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-08-18Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-08-18Refactor the get maximum weight functionality into a method in the item ↵Tim Almdal
helper, so that we can use it else where (i.e. the new organize module) Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-08-10Create the concept of an "ajax link" and use it for thumbnail rotationBharat Mediratta
and album covers in the context menu. Notes: - This requires context_menu() to have a CSS selector that refers to the <img> that we're operating on, otherwise we don't know how to find the thumbnail, etc. - Create Menu_Element_Ajax_Link which has an ajax_handler attribute that contains a snippet of JS that we're going to run when the ajax call returns. - Add $.gallery_replace_image in gallery.common.js - Add lib/gallery.ajax.js which can be used to ajaxify any link, and have ui.init.js in the themes call that on all .gAjaxLink elements.
2009-08-10Fix indentation.Bharat Mediratta
2009-08-09Fix up context menus a bit.Bharat Mediratta
- Update digibug_event::context_menu() to take the actual item - Change gallery::context_menu() to not require the page_type as an argument
2009-08-09Fixed caseChad Kieffer
2009-08-08Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_branchBharat Mediratta
Conflicts: modules/gallery/js/quick.js
2009-08-08Improve the graphics toolkit detection code so that properlyBharat Mediratta
identifies situations where its restricted by open_basedir. We now track more informatoin about the toolkit including the version and any errors we encountered while doing the detection so that we can provide more info downstream. This makes graphics::detect_toolkits() a little heavier, but that's ok because it should not be called very often. In the process, refactor the controller and view hierarchy so that it's a little more straightforward in the code. Fixes ticket #616.
2009-08-08Merge branch 'master' of git@github.com:bharat/gallery3Chad Kieffer
2009-08-08Added basic context menu affects and styles. Simplified some of the action ↵Chad Kieffer
labels in the menu.
2009-08-06Merge branch 'master' of git@github.com:bharat/gallery3 into bharat_branchBharat Mediratta
2009-08-06Cleanup the javascript for enabling dialog or panel links.Tim Almdal
1) We don't need to loop over the elements to bind the event handler. 2) Just include gallery.panel.js for all the admin pages. Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-08-05Change the children and descendants APIs to be more consistent and toBharat Mediratta
remove Gallery3 concepts from ORM_MPTT. The following API methods: ORM_MPTT::children ORM_MPTT::children_count ORM_MPTT::descendants ORM_MPTT::descendants_count All now take a $where clause that allow you to pass through additional field parameters. old API: $album->children(10, 0, "photos") $album->children_count("photos") new API: $album->children(10, 0, array("type" => "photos")) $album->children_count(array("type" => "photos")) This gives us a more flexible API and simplifies the code. While I was in there, I changed the way we deal with default orderby values so that we just assign the default value in the function definition, which allows us to get rid of all conditionals in the implementation which results in simpler code.
2009-08-05Remove the trigger definition codeTim Almdal
2009-08-05Merge branch 'master' of git@github.com:gallery/gallery3Tim Almdal