| Age | Commit message (Collapse) | Author |
|
using the checklist in ticket #385.
|
|
change, but this is the part that we want to keep.
|
|
Obsoleted by upstream fix.
This reverts commit 06f066164f60fe0babbc7a480e6319a0702e0c46.
|
|
present the done box if you're done and let you get rid of it if you
want. It's not beautiful, by any means, but it gives you an easy link
back to your Gallery when you're finished.
Fixes ticket #479.
|
|
|
|
|
|
otherwise some browsers (Firefox, at least) thinks that it needs to
revalidate. At least in my case, it appears that my proxy tacks on
restrictive Cache-Control headers if they aren't there.
|
|
1) Don't use $_SERVER, use Input::instance()->server(). This fixes the problem
that when you use a browser that doesn't pass in an Accept-Encoding, we'd
barf on a missing array key
2) Don't bother looking up the _gz key if we don't have gzencode, because we
probably didn't store one.
3) Only emit the gzip Content-Encoding header if we're actually sending back
gzipped data.
|
|
Fixes ticket #489.
|
|
html functions to generate the resulting elements. Add phpdoc.
|
|
1) Create public javascript() and css() functions and turn __call()
into a private function to protect us against having some random
type show up in there. Otherwise anything you put in the 2nd
argument gets emitted in the header which is a security hole.
2) Fix a bug ("$key = $key[0]") which was breaking functionality.
Eliminate the hex check, it's not really necessary in the majority
case and doesn't hurt us in edge cases.
3) Convert some empty() calls to !, no need for a function call there.
4) Add phpDoc.
|
|
implemented
by the magic method __call. The first parameter is the content type for text/xxxx
and the 2nd parameter is the key of the combined file.
|
|
1) CSS files are added to the combined version by use of $theme->css() or $theme->css_theme() methods
2) url references in the css are converted to full paths as opposed to relative
3) @import statements in the css are resolved as well.
4) need to move the [if IE] statements into the css files so the will be honored in the browser. currently the ie fix css are always included.
|
|
Implement the combined css functionality. Local url references and replace with absolute urls instead of relative.
|
|
combined/javascript.
|
|
1) Drop the *_modified key, we don't really need it. The modification date is not
relevant to our browser caching strategy.
2) Fix multiple issues with the Expires header and just hardcode it to the biggest
possibly value for code clarity.
3) print the $content out directly instead of using fwrite
4) Minor cleanups in the installer.
|
|
respect the HTTP_IF_MODIFIED_SINCE header request.
|
|
|
|
|
|
|
|
can disable any module credits if you want. Update the theme to obey
it.
|
|
|
|
Add xxx_installer::upgrade($version) method so that upgrade stanzas
are separate from install stanzas. In the old code, to do an upgrade
meant that you had to re-evolve everything from the initial install
because we'd step through each version's changes. But what we really
want is for the initial install to start off in the perfect initial
state, and the upgrades to do the work behind the scenes. So now the
install() function gets things set up properly the first time, and the
upgrade() function does any work to catch you up to the latest code.
See gallery_installer.php for a good example.
|
|
buttons to the
quick pane. The quick pane is now divided into 4 sections: left, center, right and
additional. Additional items appear in the drop down box. Buttons are not sorted
within the groupings.
In addition, the quick pane will overflow onto the "additional" dropdown if there is not
enough room to display all the buttons.
The use case is the digibug printing module needed to add a button to the quick pane, and
I don't like putting code into core that says if module is active... That's another one
of those code smells :-)
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
Filed upstream as: http://dev.kohanaphp.com/issues/1801
|
|
contents are are not shown
|
|
|
|
TODO: The "Show All" link is almost invisible (link color ~= background)
|
|
Fix for ticket #428
|
|
while. This fixes ticket #342.
The bug is that we were using $item instead of $theme->item(). But we
were also not special casing tags properly, and they are effectively
first class citizens (at least for now) so treat them properly. Also,
set page_title by default in the theme so that we don't have to do an
empty() check on it (makes the theme easier to read) and move the
title out of Tags_Controller so that the theme has more control over
it.
|
|
|
|
|
|
Fixes ticket #317
|
|
without using our regular code paths.
|
|
it a second time mangles the urls.
Fixes ticket #360.
|
|
|
|
Force a HTTP_HOST so that url::base() works.
|
|
|
|
upgrade is complete.
|
|
|
|
type.
|
|
with the overall look of the Gallery3 theme
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
album is not publicly browsable.
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
is not viewable by a guest, display the root album as if it was empty. When
the page finishes loading force the login dialog to be displayed.
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
|
|
grandparent id. Oops. This caused navigation from photo back up to
album to be broken.
Also update Photos_Controller to use the active sort order.. it was
still hardcoded to use the id. It's more efficient now, yay.
Fixes ticket #340.
|
|
Ticket 148.
|
|
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
that install.sql is more stable.
|