summaryrefslogtreecommitdiff
path: root/modules/gallery/controllers
AgeCommit message (Collapse)Author
2010-06-15Revert "Change the item rest update processing to call theBharat Mediratta
item::move(source, target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move." Rolling this back for a couple of reasons: 1) Bug in move.php ("message.info" is not a function name) 2) Having the message come back from the API call as a side-effect is sloppy. We should find a cleaner way to do this checking. 3) having item::move() call save() on any changed values in the ORM is counter-intuitive. Move should move, save should save. I think the right approach here is to roll the move() code properly into save(). This reverts commit 2492280cc0ec9eb64a8daeccc7b5698ece7fea66.
2010-06-15Revert "Fix for ticket #1118. Create a item::save_with_retries helperBharat Mediratta
method, which encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly." Rolled this back because it fails KISS. We already have an API for saving models with Item_Model::save() that's consistent with all of our other model code. Adding a new way to save items is confusing and inconsistent. This reverts commit 9504f71efcadc7ed27f6f09e5d663e8025bf3b86.
2010-06-15Install the rest module by default.Bharat Mediratta
2010-06-15Sort files by path in _dump_var() for consistent output.Bharat Mediratta
Skip . and .. (PHP 5.3 iterators seem to include those now).
2010-06-15Fix for ticket #1118. Create a item::save_with_retries helper method, which ↵Tim Almdal
encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly.
2010-06-15Change the item rest update processing to call the item::move(source, ↵Tim Almdal
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move.
2010-06-12Bounce the user to the login page if they try to get to part of theBharat Mediratta
admin site as a guest. Also, theme the login/html page.
2010-06-12Make login/logout continuation url code consistent. Where necessary,Bharat Mediratta
we specify the continue_url in the session, but we store it in the login form so that we can propagate it across the session creation that happens at login time.
2010-06-12Use "continue_url" instead of "continue" for consistency with theBharat Mediratta
reauth code.
2010-06-12Push the continue url into the form for consistency with otherBharat Mediratta
login/continue code.
2010-06-12Stop trying to parse the continue url in the logout controller becauseBharat Mediratta
it requires us to reproduce a bunch of complex routing logic. Instead, just have the logout link generating code generate a link that's visible to guests.
2010-06-11Fix for ticket #1039. The problem was, as Bryan76 pointed out, with passing ↵Tim Almdal
the full url in the continue parameter. In the logout controller, we tried to get the item from the url so we could check the permission of the item to insure that the guest user had access. But url::get_item_from_url expects a relative url.
2010-06-11Actually execute the database query that updates the album view count. Fixes ↵Tim Almdal
ticket #1092. Thanks to shinta for pointing the way.
2010-05-14Remove "rnd=" param from quick changes since we have the m= cache-buster ↵Bharat Mediratta
already.
2010-04-30Add page_title to admin views. Closes #1038.ckieffer
2010-04-17Change the key for invalid passwords from "invalid" toBharat Mediratta
"invalid_password" to remove ambiguity.
2010-04-17Trigger the album_add_form_completed event after creating a new album.Bharat Mediratta
2010-03-03Update the copyright to 2010. It's only 3 months into the year :-)Bharat Mediratta
2010-02-28First step towards fixing ticket #1038: Allowing for custom page <title> in ↵Andy Staudacher
admin pages, just like in non-admin pages. TODO: Set $view->page_title in the many admin controllers we have. I just set it for admin_maintenance.php to show how it's intended to be used. I copied the title from views/admin_maintenance.html.php to the controller.
2010-02-27Additional fixes for plural handling when deleting translations / marking ↵Andy Staudacher
them as untranslated.
2010-02-27Incremental fix for ticket #1042: Delete translation from ↵Andy Staudacher
outgoing_translations when the user submits a form with an empty translation.
2010-02-22Fix for ticket #1027: Add index on cache key column.Andy Staudacher
(and fix the packager to truncate the cache table before packaging)
2010-02-21Performance improvement: Load all translations of a locale as one serialized ↵Andy Staudacher
array from the Cache. Until now, we loaded hundreds of translation messages row by row, and unserializing one by one at bootstrap time. That amounted to a significant percentage of the complete request time. This approach is more than 10x faster.
2010-02-21Fix progress bar / maintenance tasks for locales that use comma as decimal ↵Andy Staudacher
separator, such as German.
2010-02-19Refactor away the "display_all" construct in User_Profile_Controller.Bharat Mediratta
"display_all" is too coarse, and we should be letting event handlers make the appropriate decision on what to display and when. This duplicates some code, but it's now very clear in the event handlers what's getting shown. Throw a 404 if we try to view the user profile for a missing user. The only feature change in this should be that we now display the name, full name and website for a user to any other registered user, which makes sense since these are typically public fields. Don't show any of the edit buttons unless identity::is_writable()
2010-02-14Fix for ticket #491: Make user and group names translatable.Andy Staudacher
Also fixed a UI bug: No longer showing the edit user buttons to admins in the profile view (to be consistent with the requirements in the controller).
2010-02-14Change JavaScript reauthentication check to check via XHR.Andy Staudacher
Benefit: Getting the real deadline this way, not interfering with an ongoing maintenance task.
2010-02-14For consistency, use straight Kohana_404_Exception instead of the event system.Andy Staudacher
2010-02-12Fix for tickets 1009 and 603: Show a themed error page to guests / ↵Andy Staudacher
registered users (not to admins though). And show a login form to guests for 404 (incl. insufficient view permissions) errors.
2010-02-11Security: Fix leaking of album / photo names. Reject previous fix for ticket ↵Andy Staudacher
1009. Side effect: Renaming auth::required_login() to login_page().
2010-02-10Refactor the code to display the login page if the user does not have viewTim Almdal
permission into the common auth::require_login() method.
2010-02-10If the user does not have permission to view the album, photo or movie, redirectTim Almdal
to a logon page to allow the user to login. Pass the target url as a session variable to allow the user to be redirected where they want to go if the login was successful. Fixes ticket #1009.
2010-02-10Use the helper ulr:current instead of manually creating the continue url.Tim Almdal
2010-02-08Fix for ticket 1008: Redirect to destination after re-auth.Andy Staudacher
2010-02-07Revert "Add the scheduler component to the admin maintenance screen."Tim Almdal
This reverts commit 48cb5021c6bd7e65a13a0ff50a9e76f72da7d3a1.
2010-02-07Revert "Refactor the admin maintenance screen so that events are used toTim Almdal
populate the action buttons and other content such as the list of scheduled tasks." Leaving this api out of RC1. This reverts commit 19fee6b5e4ceb8a5f90cafe4ad770856ece108ef. Conflicts: modules/gallery/views/admin_maintenance.html.php
2010-02-07Last partial fix for ticket 585: Compartmentalize the admin area and require ↵Andy Staudacher
active authentication every 20 minutes to access the admin area. Also renaming auth::validate_too_many_failed_password_changes to validate_too_many_failed_auth_attempts since it's used in this generalized way in 3 places now.
2010-02-07Rename user_authenticate_xxx events to user_auth_xxx for brevity.Bharat Mediratta
2010-02-07Create the concept of a "failed authentication" as semanticallyBharat Mediratta
separate from a successful or failed login. 1) Rename user_login_failed event to user_authenticate_failed 2) Rename failed_logins table to failed_auth (bump Gallery module to v27 to rename the table) 3) auth::too_many_failed_logins -> auth::too_many_failures 4) auth::record_failed_auth_attempts -> auth::record_failed_attempts auth::clear_failed_auth_attempts -> auth::clear_failed_attempts
2010-02-02Refactor the admin maintenance screen so that events are used to pupluate ↵Tim Almdal
the action buttons and other content such as the list of scheduled tasks.
2010-02-01Refactor starting a task into the task helper so we can call it multiple times.Tim Almdal
2010-02-01Add the scheduler component to the admin maintenance screen.Tim Almdal
2010-01-31Fix lots of warnings that pop up when we're in E_STRICT mode. They'reBharat Mediratta
mostly issues around uninitialized variables, calling non-static functions in a static context, calling Session functions directly instead of on its singleton, passing non-variables by reference, and subclasses not using the same interface as the parent class.
2010-01-31Remove obsolete call to _force_block_adder() which has been broken for over ↵Bharat Mediratta
a year.
2010-01-30Update install.sql -- gallery version jumps from 23 to 25 due to a mistakeBharat Mediratta
in the version 24 upgrade code. Update packager to serialize files so that we can serialize the new .htaccess files Update init_var.php to include the newly serialized .htaccess files. Fixes ticket #587.
2010-01-30Prevent brute force login attacks by reducing login attempts to 1 perBharat Mediratta
minute after there have been 5 consecutive failed login attempts. Fix for ticket #589.
2010-01-28Add @todo.Bharat Mediratta
2010-01-28Cast the SafeString $task->status to (string) so that it doesn't comeBharat Mediratta
down to the JS as an object.
2010-01-28Do all the html::clean|purify calls in the views and not the controller. ↵Tim Almdal
Also clean the subject line and email message body of the contact user email.
2010-01-25Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
Conflicts: modules/gallery/libraries/MY_ORM.php
generated by cgit v1.2.3 (git 2.51.0) at 2025-11-15 00:37:14 +0000