summaryrefslogtreecommitdiff
path: root/modules/gallery/controllers
AgeCommit message (Collapse)Author
2010-01-15Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-15Move model business logic out of album::create() and intoBharat Mediratta
Item_Model::save(). This makes creating albums similar to editing them and makes it difficult to create an album poorly. I expect to be able to remove a lot of code from the photo and movie helper because it's duplicated here. In order to do this, I refactored ORM_MPTT::add_to_parent() into ORM_MPTT::save() so we now add it to the parent when we do save. This allows us to call save() only once which saves a database call per add. The Albums_Controller logic is roughly the same as before. Haven't updated the tests yet, they're going to fail miserably since many of them depend on album::create() which is now gone.
2010-01-15Don't use Input directly to get album names, etc. Use the form fields.Bharat Mediratta
2010-01-14Begin the process of converting to model based validation. RightBharat Mediratta
now only Albums_Controller::update() supports the pattern. All form and controller based validation happening when editing an album has been moved over. Model based validation means that our REST controllers share the same validation as web controllers. We'll have consistency enforced at the model level, which is a Good Thing. The basic pattern is now: 1) Rules are in the model 2) ORM::validate() (which is called by ORM::save() but you can call it directly, too) checks the model for all the rules and throws an ORM_Validation_Exception if there are failures 3) Actions are no longer taken when you call Item_Model::__set(). Instead, they're all queued up and executed when you call Item_Model::save(). Notes: - item::validate_xxx() functions are now in Item_Model:: - We still call $form->validate() because the form can have rules (and forms triggered by events will likely continue to have rules.
2010-01-13Somemore K24 migration holdovers. need to specify the where statement with ↵Tim Almdal
operands. '=' is no longer assumed. Fixes ticket #979
2010-01-11Remove the translation submit button from translation search form. Fixes ↵Tim Almdal
ticket #975
2010-01-08Change file proxy to url encode the path components instead of the entire ↵Tim Almdal
path. Otherwise, we will encode the slashes and won't find the item.
2010-01-07Use rawurlencode to remove any encoding that the browser may have added. ↵Tim Almdal
Fixes ticket #954.
2010-01-04Fix the logout link to send you back to the current url. The oldBharat Mediratta
approach depended on having an $item, which is not the case on all pages (eg: tag pages). Also, check the CSRF in the logout controller, else you can use the logout link as a blind forwarder.
2010-01-04Send an empty Pragma header and use the item-updated time in the ↵Tim Almdal
last-modified header
2010-01-01Don't enable the rest module by default yet; we should make sure thatBharat Mediratta
we do a more thorough security audit on it first.
2010-01-01Correct the sql so that the guest and admin passwords are actually blanked ↵Tim Almdal
as part of the export
2009-12-31A more thorough fix for #745 and #940. Stop using the referer toBharat Mediratta
guess how to send the user back. Instead, proxy the originating item id through the edit forms so that we can tell exactly what page we were on when we began editing. If we were viewing the item, then redirect to its new url (in case it changed) to fix ticket #745. But if we were viewing some other item, then just stay on the current page to fix #940. The page_type approach didn't work because you'd have the same "collection" page_type when doing a context menu edit for an album.
2009-12-30Change the file proxy to use the expires helper to manage content ↵Tim Almdal
expiration. Fixes ticket #953.
2009-12-23Convert a bunch of leftover kohana::show_404 calls to throwBharat Mediratta
Kohana_404_Exception instead. These are the ones where we used a lower-case 'k' so my previous filter didn't catch it.
2009-12-21Updates for the latest version of Kohana 2.4:Bharat Mediratta
1) Controller::$input is gone -- use Input::instance() now 2) Handle new 'database.<default>.connection.params' parameter 3) Handle new 'cache.<default>.prefix' parameter
2009-12-17Convert some more database queries.Bharat Mediratta
2009-12-17Update all database queries such that we can run "php index.phpBharat Mediratta
package" and generate the same SQL as before.
2009-12-17Improve the exception error message.Bharat Mediratta
2009-12-16Convert a database call.Bharat Mediratta
2009-12-16Convert a database call.Bharat Mediratta
2009-12-16Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2009-12-16Show the right edit form for movies.Bharat Mediratta
2009-12-16Convert some database calls.Bharat Mediratta
2009-12-13Convert a database call.Bharat Mediratta
2009-12-06Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2009-12-05Use NULL instead of actual values in the vars table, so that var tweaks ↵Bharat Mediratta
result in smaller diffs.
2009-12-05Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2009-12-04Make the rendering of the Theme Options page consistent between the first ↵Tim Almdal
request and any errors
2009-12-02Convert more database calls over to the new formatBharat Mediratta
- admin/maintenance page loads, the rebuild thumbs/resizes task works - Fixed up some conversion bugs in the Cache driver
2009-12-01Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2009-12-01Beter fix for #925.Bharat Mediratta
2009-12-01Use the real mime type for movies when we're requesting the full movieBharat Mediratta
instead of a thumbnail. Fixes ticket #925, thanks to lsowen.
2009-12-01Fix a typo that was breaking the home page (doh!)Bharat Mediratta
$this->_show() -> $this->show()
2009-11-30Clean up item routing a bit.Bharat Mediratta
1) The new default route is "albums", and Albums_Controller::index() does the right thing 2) Items_Controller redirects to the appropriate specific controller 3) All item controllers now have show() instead of _show(), so that the routing code in url::parse_url() can get to it. But that code is protected against receiving bogus requests.
2009-11-29Publish theme_edit_form and theme_edit_form_completed events so that themes ↵Bharat Mediratta
can piggyback on the regular Admin > Appearance > Theme Options page.
2009-11-29Update a few more occurrences of ORM/Database -> Database_BuilderBharat Mediratta
2009-11-26Database::orwhere() is now Database_Builder::or_where()Bharat Mediratta
2009-11-26Overload Database_Builder to add merge_where() which takes predefinedBharat Mediratta
where clauses and adds them to the existing query. Update all existing queries that take an additional where clause to use it.
2009-11-26Convert all DB where() calls to take 3 arguments.Bharat Mediratta
Convert all open_paren() calls to and_open() or or_open() as appropriate.
2009-11-25ORM::orderby -> ORM::order_byBharat Mediratta
2009-11-25The html helpers no longer forces .js and .css suffixes to urls it generates ↵Bharat Mediratta
(yay!)
2009-11-25Kohana::show_404() -> throw new Kohana_404_Exception()Bharat Mediratta
2009-11-25Convert one more instance of ORM::$loaded to ORM::loaded()Bharat Mediratta
2009-11-25Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
Conflicts: modules/gallery/controllers/rest.php
2009-11-25Preliminary work to cut over to Kohana 2.4Bharat Mediratta
- Kohana::log() -> Kohana_Log::add() - Kohana::config_XXX -> Kohana_Config::instance()->XXX - Implement View::set_global in MY_View - Updated Cache_Database_Driver to latest APIs - ORM::$loaded -> ORM::loaded() - Updated item::viewable() to use K2.4 parenthesization
2009-11-25Remove the REST_Controller and assorted baggage. Completes ticket #917Tim Almdal
2009-11-25Refactor the album, movie and photo handling to remove the REST_Controller. ↵Tim Almdal
Partial fix for ticket #917
2009-11-24Rename I18n to Gallery_I18n to avoid conflict with Kohana 2.4Bharat Mediratta
2009-11-24Make get_add_form private and use it non-statically.Bharat Mediratta