gallery3.git - A clone of the Gallery3 code for testing and development.

Age	Commit message (Collapse)	Author
2009-07-11	Fix a problem in delete() where we were referencing $parent without	Bharat Mediratta
	saving its value before $item got deleted. Further fix for #528.
2009-07-03	Split the clean method into two clean and purify. clean is a light weight	Tim Almdal
	approach using html::specialchars and purify uses HTMLPurifier to intelligently cleanse the output fields. Use purifier for text and title fields where it is likely that a user would enter html to format their data.
2009-07-01	Fix a bunch of XSS vulnerabilities turned up by manual inspection	Bharat Mediratta
	using the checklist in ticket #385.
2009-06-23	Cache the page_type in pane() instead of looking it up twice.	Bharat Mediratta

2009-06-22	Change the quick pan from static to dynamic. This allows modules to add ↵	Tim Almdal
	buttons to the quick pane. The quick pane is now divided into 4 sections: left, center, right and additional. Additional items appear in the drop down box. Buttons are not sorted within the groupings. In addition, the quick pane will overflow onto the "additional" dropdown if there is not enough room to display all the buttons. The use case is the digibug printing module needed to add a button to the quick pane, and I don't like putting code into core that says if module is active... That's another one of those code smells :-) Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-14	Get rid of the word "items" in the delete confirmation dialog.	Bharat Mediratta

2009-06-14	Switch quick delete from JS confirm to jQuery UI dialog, closes ticket #355.	Chad Kieffer

2009-06-09	Show status message when album cover is set (#257)	Chad Kieffer

2009-06-01	Security pass over all controller code. Mostly adding CSRF checking	Bharat Mediratta
	and verifying user permissions, but there are several above-the-bar changes: 1) Server add is now only available to admins. This is a hard requirement because we have to limit server access (eg: server_add::children) to a user subset and the current permission model doesn't include that. Easiest fix is to restrict to admins. Got rid of the server_add permission. 2) We now know check permissions at every level, which means in controllers AND in helpers. This "belt and suspenders" approach will give us defense in depth in case we overlook it in one area. 3) We now do CSRF checking in every controller method that changes the code, in addition to the Forge auto-check. Again, defense in depth and it makes scanning the code for security much simpler. 4) Moved Simple_Uploader_Controller::convert_filename_to_title to item:convert_filename_to_title 5) Fixed a bug in sending notification emails. 6) Fixed the Organize code to verify that you only have access to your own tasks. In general, added permission checks to organize which had pretty much no validation code. I did my best to verify every feature that I touched.
2009-05-27	Restructure things so that the application is now just another module.	Bharat Mediratta
	Kohana makes this type of transition fairly straightforward in that all controllers/helpers/etc are still located in the cascading filesystem without any extra effort, except that I've temporarily added a hack to force modules/gallery into the module path. Rename what's left of "core" to be "application" so that it conforms more closely to the Kohana standard (basically, just application/config/config.php which is the minimal thing that you need in the application directory) There's still considerable work left to be done here.