summaryrefslogtreecommitdiff
path: root/modules/gallery/controllers/albums.php
AgeCommit message (Collapse)Author
2009-06-23Don't allow renaming of the root album.Bharat Mediratta
2009-06-16Change the page.html file so that if the type of page is login, the sidebar ↵Tim Almdal
contents are are not shown
2009-06-15Fix up the titles in the default theme. They've been broken for aBharat Mediratta
while. This fixes ticket #342. The bug is that we were using $item instead of $theme->item(). But we were also not special casing tags properly, and they are effectively first class citizens (at least for now) so treat them properly. Also, set page_title by default in the theme so that we don't have to do an empty() check on it (makes the theme easier to read) and move the title out of Tags_Controller so that the theme has more control over it.
2009-06-09Replace login_page.html.php with the form, wrapped in our default pageBharat Mediratta
type.
2009-06-10Add some window dressing to login_page.html in order to make it more in lineTim Almdal
with the overall look of the Gallery3 theme Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-10Created not_authorized.html.php which is a prettier login screen if the rootTim Almdal
album is not publicly browsable. Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-09Rather than just displaying the "unformatted" login screen when the root albumTim Almdal
is not viewable by a guest, display the root album as if it was empty. When the page finishes loading force the login dialog to be displayed. Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
2009-06-01Security pass over all controller code. Mostly adding CSRF checkingBharat Mediratta
and verifying user permissions, but there are several above-the-bar changes: 1) Server add is now only available to admins. This is a hard requirement because we have to limit server access (eg: server_add::children) to a user subset and the current permission model doesn't include that. Easiest fix is to restrict to admins. Got rid of the server_add permission. 2) We now know check permissions at every level, which means in controllers AND in helpers. This "belt and suspenders" approach will give us defense in depth in case we overlook it in one area. 3) We now do CSRF checking in every controller method that changes the code, in addition to the Forge auto-check. Again, defense in depth and it makes scanning the code for security much simpler. 4) Moved Simple_Uploader_Controller::convert_filename_to_title to item:convert_filename_to_title 5) Fixed a bug in sending notification emails. 6) Fixed the Organize code to verify that you only have access to your own tasks. In general, added permission checks to organize which had pretty much no validation code. I did my best to verify every feature that I touched.
2009-05-28Fix broken html::script() and url::file() references to the newlyBharat Mediratta
moved gallery module.
2009-05-27Update all references to the core application to now point to theBharat Mediratta
gallery module. This type of mass update is prone to some small bugs.
2009-05-27Restructure things so that the application is now just another module.Bharat Mediratta
Kohana makes this type of transition fairly straightforward in that all controllers/helpers/etc are still located in the cascading filesystem without any extra effort, except that I've temporarily added a hack to force modules/gallery into the module path. Rename what's left of "core" to be "application" so that it conforms more closely to the Kohana standard (basically, just application/config/config.php which is the minimal thing that you need in the application directory) There's still considerable work left to be done here.