| Age | Commit message (Collapse) | Author |
|---|
|
loading that user.
|
|
|
|
|
|
|
|
68fd196d66e2d21f571ff3b5a673f18cd129abf9 leaving us in a temporarily
broken state.
|
|
|
|
appropriately in g2_import.
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
code preamble for security.
Update File_Structure_Test::code_files_start_with_preamble_test to
check all the php files in var, too.
|
|
users about images that failed to import.
|
|
and Gallery 3 have a class named Gallery. Clone a subset of the
Gallery 2 files and munge them so that we can rename the Galery 2
version to G2_Gallery.
Also, update the disclaimer in Admin > Settings > Gallery 2 Import.
|
|
gallery module. This type of mass update is prone to some small bugs.
|
|
Install: <module>_installer::install() is called, any necessary tables
are created.
Activate: <module>_installer::activate() is called. Module
controllers are routable, helpers are accessible, etc. The module is
in use.
Deactivate: <module>_installer::deactivate() is called. Module code
is not accessible or routable. Module is *not* in use, but its tables
are still around.
Uninstall: <module>_installer::uninstall() is called. Module is
completely removed from the database.
Admin > Modules will install and activate modules, but will only
deactivate (will NOT uninstall modules).
|
|
image instead so that we at least have a target for comments.
Fixes ticket #294
|
|
|
|
image" placeholder and keep on trucking. Oh, and notify the admin.
Fixes ticket #287
|
|
|
|
|
|
|
|
the user enters the path to G2 itself, we find the embed.php path from there.
|
|
|
|
|
|
Refactor the general flow of g2_import_task::import() to simplify it
and make it more sensible. It had gotten a little overgrown. It's
still a little overgrown, but I don't see an easy way to simplify it
from here.
|
|
|
|
any resizes (or thumbnails).
Fix a case where we were over-weighting the max dimension for square
resizes and thumbs.
|
|
|
|
|
|
|
|
not installed.
Resolves ticket #276
|
|
else it interferes with thumbnail/resize generation during regular imports
|
|
|
|
doesn't exist.
|
|
saving its dimensions to the item.
Also, import originationTimestamp as captured field.
|
|
|
|
|
|
|
|
Significantly speed up the process by copying Gallery2 thumbnails and
resizes wherever possible instead of regenerating them. This requires
us to figure out the dimensions of the original G2 derivative and make
sure that it matches in some reasonable way.
To allow users to take advantage of this, calculate the optimal thumb
and resize size to set in G3 to match what was used in G2. While
we're at it, give the user some idea of how much data is available in
G2 to import.
|
|
|
|
call.
|
|
|
|
Fixes ticket #247.
|
|
item in the database. This fixes the problem that the import fails
the first time around because the various groups are mapped in the db
but aren't available in the request.
|
|
|
|
|
|
* Delete g2_map records when the corresponding item is removed.
* Improve text on g2 import settings page
* Minor comment fixes.
|
|
Notes:
* Don't store the g2->g3 map in the task; it gets too large and
overflows the context column.
* Import album sort orders
* Try to treat duplication in the summary and description fields
sensibly.
* Move the g2 import config page under the Settings menu
* Clean up the settings page slightly and send users to the
maintenance page to do the actual import (not an optimal UI, but it
works).
|
|
duplication
|
|
appropriately.
|
|
around in the task so that on subsequent import runs we don't try to
reimport stuff we've already pulled in. This also gives us a mapping
so that we will be able to translate old G2 urls into the hot new G3
urls.
|
|
metadata, and doesn't import photos yet.
|
