summaryrefslogtreecommitdiff
path: root/modules/comment
AgeCommit message (Collapse)Author
2009-09-01Rename $comment_model to $comments, this time without stomping on theBharat Mediratta
pre-existing variable.
2009-09-01Revert "Rename $comment_model to $comments."Bharat Mediratta
This reverts commit d85a8b20bbe0a5be0a03da70354169d41f418d41.
2009-09-01Add missing mark_clean() for t() calls with %attr parameter.Andy Staudacher
2009-09-01XSS / style fixes for newly detected issues (after fixing XSS scanner)Andy Staudacher
2009-08-31Fix XSS vectors in HTML attributes (mostly t() calls)Andy Staudacher
2009-08-30XSS fixes in admin_comments.html.phpAndy Staudacher
2009-08-29Update all code to use helper method html::clean(), html::purify(), ... ↵Andy Staudacher
instead of SafeString directly.
2009-08-29Merge commit 'upstream/master'Andy Staudacher
Conflicts: modules/akismet/views/admin_akismet.html.php modules/comment/helpers/comment_rss.php modules/gallery/helpers/gallery_rss.php modules/gallery/libraries/I18n.php modules/gallery/views/permissions_browse.html.php modules/gallery/views/simple_uploader.html.php modules/info/views/info_block.html.php modules/organize/controllers/organize.php modules/organize/views/organize.html.php modules/organize/views/organize_album.html.php themes/default/views/album.html.php themes/default/views/movie.html.php themes/default/views/photo.html.php
2009-08-29Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-08-29Update status message styles. Lighten backgrounds, don't show background on ↵Chad Kieffer
Admin Maintenance rows, and added gModuleStatus class.
2009-08-29Refactor all calls of p::clean() to SafeString::of() and p::purify() to ↵Andy Staudacher
SafeString::purify(). Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
2009-08-29Add a test for Comment_Model::viewable().Bharat Mediratta
2009-08-29Rename $comment_model to $comments.Bharat Mediratta
2009-08-29Fix for 641... extend viewable functionality to comments. Viewable unit test ↵Tim Almdal
is not working.
2009-08-29Fix typo in the parameter listTim Almdal
2009-08-28Fix ticket #591: reCaptcha always on the page.Tim Almdal
1) move creating the "Add a comment" button into the comments.html.php 2) use $.get() to retrieve the comment add form
2009-08-27Remove 'ENGINE=InnoDB' specification from tables that we create. UseBharat Mediratta
the system's default table specification. Fixes ticket #597.
2009-08-08Update tags module to notify modules when items related to a tag areBharat Mediratta
affected. Practically speaking this means that we'll reindex items when tags are added or removed from them. API change: Remove item_related_updated_batch event. Rationale: While this is an efficient event, it requires module developers to support two event APIs for staying up to date and increases the likelihood that they'll forget one and have data corruption. Force them all through the slower but more reliable pipe, for now. We can always try to improve efficiency by using the batch_start and batch_stop events.
2009-08-02Change the API for getting to the original state of an ORM.Bharat Mediratta
Old API: $obj->original("field_name") New API: $obj->original()->field_name This allows us to revert the varous xxx_updated events back to passing an original ORM as well as the the updated one. This makes for a cleaner event API. Old API: comment_updated($comment) { $comment->original("field_name") } Old API: comment_updated($old, $new) { $old->field_name }
2009-07-29Show the author's username if the author has no fullname. Fixes ticket #601.Bharat Mediratta
2009-07-28Change search callbacks to use the event system, so move them out ofBharat Mediratta
xxx_search helpers and into xxx_event helpers.
2009-07-28Use events to generate menus, instead of having xxx_menu helpers.Bharat Mediratta
This is the first step towards having a simple, lightweight and unified API for module interaction.
2009-07-23Convert instances of theme_url() to just url() to match the API changeBharat Mediratta
made in dbeadc1407293d0c7af36723db6fe5699890b845
2009-07-22Use the Kohana cascading filesystem to locate resources loaded by theBharat Mediratta
theme. Because the theme comes first, this means that themes can override any module resources, at the cost that we no longer have namespacing for JS and CSS files. The only file getting used outside of this model is themes/default/screen.css which is used in the admin theme. I fixed that by copying screen.css into admin_default and renaming its screen.css to admin_screen.css. I also copied over all the images that it was referencing. Fixes tickets #48 and #539. Theme API changes: - theme_script(), theme_url() and theme_css() are no longer needed - script(), url() and css() now refer to the first matching asset in the module load path, where gallery3/lib is at the end of the path
2009-07-16Second non-trivial change to the event code. We now publish modelBharat Mediratta
related events from within the model handling code. The only exception to this currently is item_created which is challenging because we have to save the item using ORM_MPTT::add_to_parent() before the object itself is fully set up. When we get that down to one call to save() we can publish that event from within the model also.
2009-07-16Non-trivial changes to the event handling code:Bharat Mediratta
1) The item_updated event no longer takes the old and new items. Instead we overload ORM to track the original data and make that available via the item. This will allow us to move event publishing down into the API methods which in turn will give us more stability since we won't require each controller to remember to do it. 2) ORM class now tracks the original values. It doesn't track the original relationships (no need for that, yet) 3) Added new events: item_deleted group_deleted user_deleted
2009-07-13Add quotes around all values that contain spaces in them, and add aBharat Mediratta
test to make sure that we continue to do so. This makes sure that we don't have problems with 5.3 which treats the literal "on" as a boolean.
2009-07-13Avoid using the bare word "on" in a value; it breaks PHP 5.3.Bharat Mediratta
Fixes ticket #540.
2009-07-07Change references to Gallery 2 and Gallery 3 to consistently refer toTim Almdal
Gallery n as opposed any variants of this.
2009-07-04Forgot this file when i was fixing #477Tim Almdal
2009-07-04Fix for ticket #477. Use nl2br method when rendering comment::text andTim Almdal
item::description. In addition add p::clean or p::purify to places that xss cleaning had missed (i.e. rss feeds)
2009-07-03Split the clean method into two clean and purify. clean is a light weightTim Almdal
approach using html::specialchars and purify uses HTMLPurifier to intelligently cleanse the output fields. Use purifier for text and title fields where it is likely that a user would enter html to format their data.
2009-07-01Fix for ticket #357.Tim Almdal
Changed the set the created date as part of the import and change models/comment::save() to not set the creation date if it is already set.
2009-06-28Rename $theme->url() to $theme->theme_url() for consistency wihtBharat Mediratta
$theme->theme_script().
2009-06-26Create a theme_view function script which allows modules in the head or ↵Tim Almdal
admin_head functions to specify javascript files that are required for this page. In this commit, these script files are expressed at the end of the head or admin_head calls and appended to the beginning of the block stack. In a future commit these will be combined and gzipped for download.
2009-06-24Comment out [reply] and [edit] links because they're not implementedBharat Mediratta
yet. This closes ticket #416, and I'll open a new ticket to implement these functions.
2009-06-23Replay change from Romain DE LISEZ to change the state column to be a varcharBharat Mediratta
2009-06-23Upgrade to version 2 and change the state column to a varchar forBharat Mediratta
Postgres compatibility.
2009-06-23Refactor the install/upgrade code to be more flexible.Bharat Mediratta
Add xxx_installer::upgrade($version) method so that upgrade stanzas are separate from install stanzas. In the old code, to do an upgrade meant that you had to re-evolve everything from the initial install because we'd step through each version's changes. But what we really want is for the initial install to start off in the perfect initial state, and the upgrades to do the work behind the scenes. So now the install() function gets things set up properly the first time, and the upgrade() function does any work to catch you up to the latest code. See gallery_installer.php for a good example.
2009-06-18Fix l10n messages (malformed html)Andy Staudacher
2009-06-16Fix html bug in l10n messageAndy Staudacher
2009-06-15Refactor the comment_rss::feed() method to eliminate code duplication.Bharat Mediratta
2009-06-14Refactor the way that the rss module works so that we're not allowingBharat Mediratta
the url to dictate arbitrary static method calls. * Each xxx_rss helper has a single feed() call which takes an id as the argument * xxx_rss::available_feedS() only returns feeds when they're applicable (ie if you're viewing a tag, it won't show you an item feed). * Feed urls are now in the module/feed_id form so that we can bind a feed id to a given module * Tightened up the Rss_Controller by using url::merge and some other tricks. * Made the slideshow module express its own feed.
2009-06-14Refactor feed code to use stdClass everywhere. Fix bugs in theBharat Mediratta
max-pages calculation code. Move feed related data into the $feed variable and only pass that to the view.
2009-06-14Don't use stdClass to return the feed data. Just use an array.Tim Almdal
2009-06-14Remove the sidebar flag from the feed definition returned by available_feeds andTim Almdal
replace with a type field with one of two values (head and block). We need to do this to determine what fields go in the rss block so we can ignore the definitions that are related to the page head when creating the rss block that goes into the sidebar.
2009-06-12Create gallery::date_time(), gallery::date() and gallery::time()Bharat Mediratta
functions that format a unix timestamp into a date+time/date/time string. Partial fix for ticket #347.
2009-06-12Move the processing of rss feeds from the rss controller to callbacks in theTim Almdal
modules that are supplying the feed. The rss controller becomes a router. In this change the comment and updates fields are distributed.
2009-06-12Change from an event driven model to a call driven model similiar to the taskTim Almdal
api.
2009-06-12Change the "request_feed_links" eventing handling so that individual modulesTim Almdal
provide the part of the url (the suffix) that they are interested in and the rss module will format the rest of the url.