summaryrefslogtreecommitdiff
path: root/modules/comment
AgeCommit message (Collapse)Author
2009-06-11Changed rss_theme::sidebar_blocks to fire the event "request_feed_links" toTim Almdal
allow modules to contribute rss feed links to the rss sidebar block. Ticket #388.
2009-06-03Sanitize all data we return via json_encode() to guard against XSS andBharat Mediratta
other data leaks.
2009-06-01Security pass over all controller code. Mostly adding CSRF checkingBharat Mediratta
and verifying user permissions, but there are several above-the-bar changes: 1) Server add is now only available to admins. This is a hard requirement because we have to limit server access (eg: server_add::children) to a user subset and the current permission model doesn't include that. Easiest fix is to restrict to admins. Got rid of the server_add permission. 2) We now know check permissions at every level, which means in controllers AND in helpers. This "belt and suspenders" approach will give us defense in depth in case we overlook it in one area. 3) We now do CSRF checking in every controller method that changes the code, in addition to the Forge auto-check. Again, defense in depth and it makes scanning the code for security much simpler. 4) Moved Simple_Uploader_Controller::convert_filename_to_title to item:convert_filename_to_title 5) Fixed a bug in sending notification emails. 6) Fixed the Organize code to verify that you only have access to your own tasks. In general, added permission checks to organize which had pretty much no validation code. I did my best to verify every feature that I touched.
2009-05-31Run p::clean() on any variables that contain data entered by users.Bharat Mediratta
2009-05-26Restructure the module lifecycle.Bharat Mediratta
Install: <module>_installer::install() is called, any necessary tables are created. Activate: <module>_installer::activate() is called. Module controllers are routable, helpers are accessible, etc. The module is in use. Deactivate: <module>_installer::deactivate() is called. Module code is not accessible or routable. Module is *not* in use, but its tables are still around. Uninstall: <module>_installer::uninstall() is called. Module is completely removed from the database. Admin > Modules will install and activate modules, but will only deactivate (will NOT uninstall modules).
2009-05-19Rolled back r20813 to restore jump to comments, at least for nowChad Kieffer
2009-05-14Get rid of the 'View comments on this item' menu option for photos.Bharat Mediratta
It doesn't fit in with the others and as Jakob points out, the scroll wheel on the mouse is perfectly sufficient. I'll leave the icon around, though.
2009-05-13Gee it's May already. Update copyright to 2009.Bharat Mediratta
2009-05-11Refactor to support pagination and simplify the code.Bharat Mediratta
- Simplify the public controller methods - Fix a bug where missing thumbnails would cause a divide by zero error - actually pay attention to the page # for pagination and limit the query accordingly.
2009-05-02Remove direct call to item_before_delete since r20647 moved it into Item_ModelBharat Mediratta
2009-04-23Delete any comments associated with deleted itemsBharat Mediratta
2009-04-06Hide the "no comments yet" text after the first comment is posted.Bharat Mediratta
Fixes ticket #196.
2009-04-05Remove extra blank line.Bharat Mediratta
2009-04-03Concatenate chopped up internationalized string.Bharat Mediratta
2009-03-27Put csrf token into Admin_View and Theme_View by default, then use itBharat Mediratta
directly wherever possible instead of access::csrf_token().
2009-03-18Forgot to remove a back tickTim Almdal
2009-03-18Couple of sql statements that had incorrect prefix handling or noTim Almdal
prefix handling.
2009-02-28Change the pattern to identify tables that need prefix substitution toTim Almdal
mirror the drupal pattern of using braces {}.
2009-02-27This implements table prefix for all the queries in core, user, exif,Tim Almdal
tag, search, comment and notification modules (Ticket #68)
2009-02-23Temp fix for photostreamin admin dashboard, other miscellaneous css fixes. ↵Chad Kieffer
Apply jQuery UI button css to submit inputs in the admin theme.
2009-02-23added additional comment link, if no comments have been made yet.Jakob Hilden
2009-02-22Leave the comments title around, but add the "Be the first to comment"Bharat Mediratta
message below it.
2009-02-22Adjust the title based on whether or not there are comments.Bharat Mediratta
2009-02-22Standardize to uppercase DESC in the order by method callsTim Almdal
2009-02-20Fixes to comment admin buttons.Chad Kieffer
2009-02-15Apply buttons to comment moderation and action buttons, beginnings of a ↵Chad Kieffer
photo stream carousel block in admin dashboard.
2009-02-12Added a show comment form button. Add comment form is revealed when the ↵Chad Kieffer
button is clicked. Used jQuery UI Effect to .highlight() to bring attention to newly added comments. Also added a named anchor to our block library to allow direct linking/scrolling to those blocks on the page.
2009-02-02Resolve Trac Ticket #32Tim Almdal
2009-02-02Fix trac issue: #31Tim Almdal
2009-01-27Make the comment -> recaptcha binding happen via an event dispatch asBharat Mediratta
opposed to a direct call.
2009-01-26Adding Recaptcha to the comment module. Recaptcha integration consists of a ↵Tim Almdal
Form_Recaptcha class derived from Form_Input that can be added to any class that requires Recaptcha verfication.
2009-01-25Undo the adding underscores to the id on forge generated formsTim Almdal
2009-01-24Admin theme style cleanup. Merged separate selected, available, unavailable ↵Chad Kieffer
into a single set of reusable classes. Applied alternating row bg colors. Removed inline CSS from admin views. Moved user admin css into admin_default theme style sheet.
2009-01-24Supply a form id on all forms. This id can be used by modules otherTim Almdal
than the originating module to provide additional functionality to the form.
2009-01-18Don't force validation anymore; we're clearing the form properly inBharat Mediratta
the controller on successful add.
2009-01-18We don't need to reset the form anymore, since it's reset on the server side.Bharat Mediratta
2009-01-18Reset the form before sending it back on success so that we clear the values.Bharat Mediratta
2009-01-18Refactor dashboard -> block_manager since it'll manage blocks siteBharat Mediratta
wide, not just in the dashboard.
2009-01-18Rename theme callback helpers from xxx_block to xxx_theme to make roomBharat Mediratta
for us to rename the dashboard helper to be a block helper since sidebar blocks are not just in the dashboard.
2009-01-17Implement relevance ranked boolean searching on a full text index ofBharat Mediratta
item and comment data. Whew! It's not pretty yet. And you have to manually update the index currently in admin/maintenance. But it works.
2009-01-16Fix validation when adding new comments.Bharat Mediratta
Fire off the appropriate item_related_update events as appropriate.
2009-01-15Changing t() placeholder syntax from {{replace_me}} to %replace_me.Andy Staudacher
2009-01-15Simplifying the way t() is called. Refactoring localization function ↵Andy Staudacher
t($message, $options=array()) into 2 separate functions: - the new t($message, $options=array()) is for simple strings, optionally with placeholder interpolation. - t2($singular, $plural, $count, $options=array()) is for plurals.
2009-01-15Rename 'xxx_changed' events to 'xxx_updated'Bharat Mediratta
2009-01-14Make sure that helper functions are all static. Add newBharat Mediratta
File_Structure_Test to make sure we don't regress. According to the PHP docs, the "public" keyword is implied on static functions, so remove it. Also, require private static functions to start with an _. http://php.net/manual/en/language.oop5.visibility.php
2009-01-12Refactor dashboard block handling out into a dashboard helper so thatBharat Mediratta
module installers don't have to know the grotty details of how it works.
2009-01-12Implement deleting dashboard blocks.Bharat Mediratta
* Refactor blocks so that they have a separate id vs css_id. This way we can have a unique identifier for each visual block. * Store blocks with a random id as their unique identifier * Add Admin_Dashboard::remove_block() and modify themes/admin_default/views/block.html.php to call it when you click the remove box.
2009-01-12Updated for new Form_Submit API.Bharat Mediratta
OLD: $form->submit("Foo") --> <input type="submit" value="Foo"> New: $form->submit("foo_button")->("Foo") --> <input type="submit" name="foo_button" value="Foo"> Mostly we don't care what the button is so we leave the name blank.
2009-01-12Dashboard blocks are now data driven, and you can add new blocks toBharat Mediratta
both the sidebar and the center content area from a dropdown at the top of the dashboard sidebar.
2009-01-11Use the author's avatar, not the logged in user's one.Bharat Mediratta