| Age | Commit message (Collapse) | Author |
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
|
|
- Simplify the public controller methods
- Fix a bug where missing thumbnails would cause a divide by zero error
- actually pay attention to the page # for pagination and limit the query accordingly.
|
|
mirror the drupal pattern of using braces {}.
|
|
tag, search, comment and notification modules (Ticket #68)
|
|
|
|
Fire off the appropriate item_related_update events as appropriate.
|
|
|
|
t($message, $options=array()) into 2 separate functions:
- the new t($message, $options=array()) is for simple strings, optionally with placeholder interpolation.
- t2($singular, $plural, $count, $options=array()) is for plurals.
|
|
|
|
|
|
|
|
approve/unapprove/spam a comment.
|
|
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
|
|
1) Akismet now detects when we change a comment's published state and submits
info back to akismet.com as appropriate
2) We now show 4 different queues (all / approved / unapproved / spam) and let you
move messages between the queues
3) We track and display "spam caught" stats.
4) You can delete comments entirely.
|
|
(approved, unapproved, spam).
|