| Age | Commit message (Collapse) | Author |
|---|
|
(actually, we did that before: Now removing HTML element attributes since they were delimited by single quotes because PHP's ini parser can't
deal with double-quotes in values.)
Background:
Requiring all l10n messages a) to be well-formed HTML and b) to use double-quotes as HTML element attributes, since the l10n server side
validation normalizes all attribute delimiters to double-quotes). See ticket #254.
|
|
one that uses it. Perhaps this is not the best solution, but it's the
pragmatic one.
|
|
|
|
in a value that's read with
parse_ini_file. Using single quotes instead, even if that's not the best style in English.
|
|
and verifying user permissions, but there are several above-the-bar
changes:
1) Server add is now only available to admins. This is a hard
requirement because we have to limit server access (eg:
server_add::children) to a user subset and the current permission
model doesn't include that. Easiest fix is to restrict to admins.
Got rid of the server_add permission.
2) We now know check permissions at every level, which means in
controllers AND in helpers. This "belt and suspenders" approach will
give us defense in depth in case we overlook it in one area.
3) We now do CSRF checking in every controller method that changes the
code, in addition to the Forge auto-check. Again, defense in depth
and it makes scanning the code for security much simpler.
4) Moved Simple_Uploader_Controller::convert_filename_to_title to
item:convert_filename_to_title
5) Fixed a bug in sending notification emails.
6) Fixed the Organize code to verify that you only have access to your
own tasks. In general, added permission checks to organize which had
pretty much no validation code.
I did my best to verify every feature that I touched.
|
|
Install: <module>_installer::install() is called, any necessary tables
are created.
Activate: <module>_installer::activate() is called. Module
controllers are routable, helpers are accessible, etc. The module is
in use.
Deactivate: <module>_installer::deactivate() is called. Module code
is not accessible or routable. Module is *not* in use, but its tables
are still around.
Uninstall: <module>_installer::uninstall() is called. Module is
completely removed from the database.
Admin > Modules will install and activate modules, but will only
deactivate (will NOT uninstall modules).
|
|
|
|
|
|
|
|
into a single set of reusable classes. Applied alternating row bg colors. Removed inline CSS from admin views. Moved user admin css into admin_default theme style sheet.
|
|
than the originating module to provide additional functionality to the form.
|
|
|
|
|
|
|
|
|
|
File_Structure_Test to make sure we don't regress.
According to the PHP docs, the "public" keyword is implied on static
functions, so remove it. Also, require private static functions to
start with an _.
http://php.net/manual/en/language.oop5.visibility.php
|
|
OLD:
$form->submit("Foo") --> <input type="submit" value="Foo">
New:
$form->submit("foo_button")->("Foo") --> <input type="submit" name="foo_button" value="Foo">
Mostly we don't care what the button is so we leave the name blank.
|
|
linux, since the given value for server_remote_port is longer than 16 chars, the actual length of the DB field.
Removed the leading "server_" part of the test values to ensure that all values are small enough to be stored in the DB.
|
|
they're actually getting sent to Akismet. It looks like this code was
broken in the past, since it wasn't sending any of this extra info.
|
|
|
|
user modules.
* Don't delete vars when we delete a module. This makes
reinstalling a module a lot easier.
* Add user::lookup() as the preferred way to load a user, so that
other modules don't delve into the user module (that'd be a
problem when we swap out user modules)
* Notify site admins if Akismet is not fully configured
* Bundle all server variables into the comment so that if/when we
re-check the comment, we are not using the server info from the
site admin's request.
* Update Akismet to grab request context data from the comment
* Pre-seed comment fields if we have a logged in user. Update
comment::create() API to clarify it for this.
* Delete comment::update(), that's a controller function.
* Add url to User_Model
* Add author_name() author_email() and author_url() to
Comment_Model. It'll return the appropriate values depending
on whether the comment was left by a logged in user or a guest.
* Use resetForm() instead of clearForm() when we reload the
comment form after ajax submit, this way we preserve the
pre-seeded values.
* In the user profile page, ignore blank passwords.
|
|
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
|
|
akismet if it's on. Force it on in the scaffolding so that we don't
try to run all comments we add from there through Akismet.
|
|
1) Akismet now detects when we change a comment's published state and submits
info back to akismet.com as appropriate
2) We now show 4 different queues (all / approved / unapproved / spam) and let you
move messages between the queues
3) We track and display "spam caught" stats.
4) You can delete comments entirely.
|
|
value. Add phpdoc.
|
|
akismet stats page take up as much room as possible.
|
|
in its own right. Clean up the tests, streamline the code and improve
the admin interaction. Add a working stats page.
|
