| Age | Commit message (Collapse) | Author |
|---|
|
https://github.com/gallery/gallery3/commit/bb35aefffbc287efc9823abd4b0e451b86c37378
in an attempt to resolve #797.
Fixes #1640.
|
|
to integer. Fixes overflow probelm that causes #1490. Thanks to
nkinkade for the fix.
|
|
#1541.
|
|
https://github.com/douglascrockford/JSON-js/blob/master/json2.js
by Douglas Crockford at 8d11dc6950eafc7d01f141ce91d4f585caa29f3b. Fixes #1351.
|
|
|
|
to the correct location.
So lets fix that up. But first undo the reverts:
93d1a8103e757a87fb006f2389f0ee24497367a7 "Revert 'Move the contents of lib/gallery.common.css into themes/wind/css/screen.php and themes/admin_wind/css/screen.php. Most themers seem to copy the contents into their theme's screen.css anyway.'"
f14290f34f097f525a56bc00070b73fba1fb8e2c "Revert 'Clean up white space'"
ff8ee5bdfcc0d35e14f3124d349625814ec8771a "Revert 'Add some whitespace.'"
|
|
themes/wind/css/screen.php and themes/admin_wind/css/screen.php. Most themers seem to copy the contents into their theme's screen.css anyway."
This reverts commit 42517041753d460c337a2086c0346018ad582e8d.
|
|
and themes/admin_wind/css/screen.php. Most themers seem to copy the contents into their theme's screen.css anyway.
|
|
1) Prevent it from "bouncing" which happens when we queue up a lot of
open and close events. Stop any running animations before starting
new ones. This fixes #1340.
2) Prevent a bug that's not really visible to the user where we wind
up re-initializing a context menu over and over which results in us
binding tons of hover events. I don't think this causes any serious
damage, but it's probably not good.
|
|
of using CSS selector lookups for every operation. I assume (but have
not verified) that this is more efficient.
|
|
centered. Partial fix for #1354.
|
|
cbba45fffc7368280e9529f55e108d0080175b6a with a namespaced jQuery
custom event. This is way more portable.
|
|
The photo view page caches the dimensions of the full size and then
renders it in Javascript. But after rotation, those dimensions are no
longer valid. Create a new function on the items controller that
returns the appropriate dimensions, then add a hook on
$.gallery_replace_image and implement the hook on the photo view page
to have it make an async call to get the new dimensions.
Fixes ticket #1317
|
|
|
|
|
|
|
|
by the following rules:
1) An initial dialog or panel load can take either HTML or JSON, but
the mime type must accurately reflect its payload.
2) dialog form submits can handle a pure HTML response, but the mime
type must also be correct. This properly resolves the problem
where the reauth code gets a JSON response first from the reauth
code, and then an HTML response when you reauth and continue on to
a given form -- try it out with Admin > Settings > Advanced.
3) All JSON replies must set the mime type correctly. The json::reply
convenience function does this for us.
4) By default, any HTML content sent back in the JSON response should be
in the "html" field, no longer the "form" field.
The combination of these allows us to stop doing boilerplate code like
this in our controllers:
// Print our view, JSON encoded
json::reply(array("form" => (string) $view));
instead, controllers can just return HTML, eg:
// Print our view
print $view;
That's much more intuitive for developers.
|
|
information. We need to replace the contents of the entire dialog, not just the form, otherwise, there could be text floating around that doesn't make sense.
|
|
|
|
mime type returned to determine the content type.
|
|
gallery.dialog.js in 9538b3888dadbe3a6fac72e2a97f97c7db3d86f2
|
|
on a query param to urls that appear in dialogs. This keeps things simpler.
|
|
something more representative... 'gallery_dialog_request'
|
|
|
|
|
|
|
|
|
|
the dialog to recenter in case the contents have changed.
|
|
parameter to the url to let the controller know its in a dialog. The reauthenticate controller will format the password prompt as a page or a form content. If authentication is successful, then the original controller is called instead of being redirected to.
|
|
dialog. Convert all the controllers
that create the data to go into a dialog to return the html as part of a json object.
|
|
entire page when reauthenticating the administrator. Just put the form in the dialog."
This reverts commit 8493a3d36f597e183490ae880b35a3d98f50a045.
|
|
page when reauthenticating the administrator. Just put the form in the dialog.
|
|
it twice.
|
|
related and make more sense to be in the theme. Both three_nids and browny_wind* have created copies for their visual standard. So this just makes it consistent across the board.
|
|
|
|
|
|
|
|
|
|
|
|
1) gallery.common.js was using the wrong class name
2) we need to mark the CSS as !important because it conflicts with
other background images. Note that this will replace the existing
background which may not be desireable.
|
|
ticket #1165.
|
|
Conflicts:
lib/gallery.common.css
|
|
adding comment button for RTL (3) Flip the corner radiuses for any buttons set, which solves the issue of flipped corners in the comments admin page. Also, add the CSS3 selector of the round corners so they work in Opera (4) Fix ticket #1052
|
|
be shown even with the case the element has two or more of them (e.g. class='ui-corner-left ui-corner-right'.) Don't know if there was a better solution..
|
|
|
|
|
|
adding comment button for RTL (3) Flip the corner radiuses for any buttons set, which solves the issue of flipped corners in the comments admin page. Also, add the CSS3 selector of the round corners so they work in Opera (4) Fix ticket #1052
|
|
When load a file is uploaded using a dialog box and the jquery plugin ajaxForm, the ajaxForm plugin uses an hidden iFrame element to send the multi-part
form and this is where the response goes. The ajaxForm plugin then retrieves the document body and parses the result as a json string. If the file uploads
properly everything is fine, but if it fails Gallery3 return the input form with the the error fields highlighted as part of the json response. As this
response is returned to a hidden iframe, the browser attempts to manipulate it and all hell breaks loose. We lose the trailing brace, we start getting
escaping of form tags. When the ajaxForm plugin retrieves the iFrame body its no longer a valid json frame and the parsing fails and the user sees no
indication that it failed.
|
|
vendor.
|
|
they are...
|
