| Age | Commit message (Collapse) | Author |
|---|
|
|
|
are correct, all titles are correctly sized, and the dialog boxes go to
the top for older themes, too.
|
|
already been broken in v3.0.4...)
|
|
a link/menu.
If they come from a context menu, they're still really broken.
|
|
|
|
longer need to save xhr ahead of success.
Tested and seems to work well, even with watermarks on Chrome (previously an issue).
|
|
|
|
in dialogs. Fixes #236.
|
|
https://github.com/gallery/gallery3/commit/bb35aefffbc287efc9823abd4b0e451b86c37378
in an attempt to resolve #797.
Fixes #1640.
|
|
|
|
|
|
by the following rules:
1) An initial dialog or panel load can take either HTML or JSON, but
the mime type must accurately reflect its payload.
2) dialog form submits can handle a pure HTML response, but the mime
type must also be correct. This properly resolves the problem
where the reauth code gets a JSON response first from the reauth
code, and then an HTML response when you reauth and continue on to
a given form -- try it out with Admin > Settings > Advanced.
3) All JSON replies must set the mime type correctly. The json::reply
convenience function does this for us.
4) By default, any HTML content sent back in the JSON response should be
in the "html" field, no longer the "form" field.
The combination of these allows us to stop doing boilerplate code like
this in our controllers:
// Print our view, JSON encoded
json::reply(array("form" => (string) $view));
instead, controllers can just return HTML, eg:
// Print our view
print $view;
That's much more intuitive for developers.
|
|
information. We need to replace the contents of the entire dialog, not just the form, otherwise, there could be text floating around that doesn't make sense.
|
|
|
|
mime type returned to determine the content type.
|
|
on a query param to urls that appear in dialogs. This keeps things simpler.
|
|
something more representative... 'gallery_dialog_request'
|
|
|
|
the dialog to recenter in case the contents have changed.
|
|
parameter to the url to let the controller know its in a dialog. The reauthenticate controller will format the password prompt as a page or a form content. If authentication is successful, then the original controller is called instead of being redirected to.
|
|
dialog. Convert all the controllers
that create the data to go into a dialog to return the html as part of a json object.
|
|
entire page when reauthenticating the administrator. Just put the form in the dialog."
This reverts commit 8493a3d36f597e183490ae880b35a3d98f50a045.
|
|
page when reauthenticating the administrator. Just put the form in the dialog.
|
|
it twice.
|
|
When load a file is uploaded using a dialog box and the jquery plugin ajaxForm, the ajaxForm plugin uses an hidden iFrame element to send the multi-part
form and this is where the response goes. The ajaxForm plugin then retrieves the document body and parses the result as a json string. If the file uploads
properly everything is fine, but if it fails Gallery3 return the input form with the the error fields highlighted as part of the json response. As this
response is returned to a hidden iframe, the browser attempts to manipulate it and all hell breaks loose. We lose the trailing brace, we start getting
escaping of form tags. When the ajaxForm plugin retrieves the iFrame body its no longer a valid json frame and the parsing fails and the user sees no
indication that it failed.
|
|
because of an error.
|
|
submit button is disabled and the user is no longer able to submit multiple clicks. This should fix tickets: #623, #790, #799
|
|
view. Tightened up g-pager styles. Removed a few unecessary !importants.
|
|
shared images from wind to lib. Deleted unused images in the admin_wind. This will likely break a few ajax features.
|
|
and classes in the login/reset password dialog.
|
|
|
|
forms when an open dialog is reloaded.
|
|
|
|
supersized based on ly last commit.
|
|
|
|
|
|
click events, but just show the dialog. Also remove the destroy method and put all the cleanup into the dialog close handler
|
|
reason (probably a timing thing) the height of the contents was not being set correctly in FF. So we just hard code an estimate of the size of the Draw handle, and message areas.
|
|
and have some basic namespacing:
showMessage --> gallery_show_message
vAlign --> gallery_valign
showLoading --> gallery_show_loading
Convert gallery.show_full_size.js to be a jQuery function and give it a namespace:
show_full_size --> gallery_show_full_size
|
|
gallery_dialog respectively
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
Signed-off-by: Bharat Mediratta <bharat@menalto.com>
|
|
This reverts commit 1f014aae6c16bbda62d8f5937180f11ccb0eb1b1.
|
|
javascript lib (gallery.reload.js) which defines the functions
gallery_reload() and gallery_location(new_location). They just
do a window.location.reload() and window.location = new_location.
This change breaks the assumption that all themes will handle page reloads
the same and allows the theme to customize the page refresh.
|
|
action. The expectation is that we're going to reload the page (or
redirect to a new url). If we close the dialog, then we can trigger
the onhover for items we've just deleted causing errors.
Simplify the API while we're at it by getting rid of the no-longer-used
on_success argument to openDialog()
This fixes #528.
|
|
add the message to admin_default as
well.
|
|
|
|
is no form.
|
|
allows the form in the dialog todo custom processing when the form
closes.
For example, the server_add dialog (next commit) uses this callback to
determine if the upload task was cancelled and display a warning
message when the page reloads.
Usage:
$("#gServerAdd form").bind("form_closing", function(target){...});
|
|
in r20302.
|
|
1) Shuffled code around to create a on_form_loaded function
2) Check for a data.reset string in the json return. If it exists and
is a function then call. The idea being that if there is an error we
might have to reset some jquery widget initialization.
|
