| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2010-01-15 | Don't use Input directly to get album names, etc. Use the form fields. | Bharat Mediratta | |
| 2010-01-15 | Move setting Item_Model::rand_key into Item_Model::save() since it's | Bharat Mediratta | |
| business logic. | |||
| 2010-01-15 | Use $value in valid_xxx() functions instead of the member field. They're ↵ | Bharat Mediratta | |
| equivalent, but it's more intuitive this way. | |||
| 2010-01-14 | Begin the process of converting to model based validation. Right | Bharat Mediratta | |
| now only Albums_Controller::update() supports the pattern. All form and controller based validation happening when editing an album has been moved over. Model based validation means that our REST controllers share the same validation as web controllers. We'll have consistency enforced at the model level, which is a Good Thing. The basic pattern is now: 1) Rules are in the model 2) ORM::validate() (which is called by ORM::save() but you can call it directly, too) checks the model for all the rules and throws an ORM_Validation_Exception if there are failures 3) Actions are no longer taken when you call Item_Model::__set(). Instead, they're all queued up and executed when you call Item_Model::save(). Notes: - item::validate_xxx() functions are now in Item_Model:: - We still call $form->validate() because the form can have rules (and forms triggered by events will likely continue to have rules. | |||
| 2010-01-13 | Somemore K24 migration holdovers. need to specify the where statement with ↵ | Tim Almdal | |
| operands. '=' is no longer assumed. Fixes ticket #979 | |||
| 2010-01-13 | Did the old commit then save trick | Tim Almdal | |
| 2010-01-13 | Fix for ticket #978. Don't reset the original property as part of the save ↵ | Tim Almdal | |
| processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original. | |||
| 2010-01-12 | Put quotes around the item titles in all the messages and more importantly ↵ | Tim Almdal | |
| actually display the original's title properly. Fixes ticket #966, but does now show us ticket #978 | |||
| 2010-01-12 | If the user hits enter in the search text field, then cancel the submission, ↵ | Tim Almdal | |
| because the search is done in the browser and the the enter will unexpectedly reload the root directory. | |||
| 2010-01-12 | Correct the "l10n_client_data[index] is undefined" error. | Tim Almdal | |
| 2010-01-12 | Some whitespace and syntax corrects | Tim Almdal | |
| 2010-01-12 | Add a css id attribute to the i10n-edit-translation element. Fixes ticket #969. | Tim Almdal | |
| 2010-01-11 | Reformat the string list so that the search box does not get push off the ↵ | Tim Almdal | |
| end of the page. | |||
| 2010-01-11 | Remove the translation submit button from translation search form. Fixes ↵ | Tim Almdal | |
| ticket #975 | |||
| 2010-01-11 | Remove the automatically marking the resizes dirty line as this could cause ↵ | Tim Almdal | |
| alot of pain to some installations | |||
| 2010-01-11 | Fixes ticket #671. | Tim Almdal | |
| In the graphics_rules table height and width set the maximum height and width values and should be equal. Initially, the height on the resize target rule was less than the height, which artificially constrained images in portrait mode. **Note"" this fix requires an upgrade to version 22. All the resizes will be flagged dirty. | |||
| 2010-01-10 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-09 | Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where | Tim Almdal | |
| clauses and deletes all the entries in the table unless an array of id's are passed as the parameter. This fix used the Database_builder to specify any where conditions. Thanks psvo for find the first one. :-) | |||
| 2010-01-08 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-08 | Move the random image functionality into the gallery REST helper since | Bharat Mediratta | |
| choosing a random image is essentially a function on an item collection. Also implemented a bunch of other query filters for item collections. Created item::random_query() as a way of generating a reasonable starting point for random queries. | |||
| 2010-01-08 | Remove debug code. | Bharat Mediratta | |
| 2010-01-08 | Remove stray semicolons. | Bharat Mediratta | |
| 2010-01-08 | Remove the display of the "body_attributes" div when in debug mode. debug ↵ | Tim Almdal | |
| mode is by default set up to add new div's to display the location of the content. "body_attributes" are attributes on the body tag and trying to add content introduces an extra > in the html stream. | |||
| 2010-01-08 | Change file proxy to url encode the path components instead of the entire ↵ | Tim Almdal | |
| path. Otherwise, we will encode the slashes and won't find the item. | |||
| 2010-01-08 | Add item::random() to return a random Item_Model. | Bharat Mediratta | |
| 2010-01-08 | Expect merge_where and merge_or_where to handle empty tuples. | Bharat Mediratta | |
| 2010-01-08 | use item::random() to get the random item. | Bharat Mediratta | |
| 2010-01-08 | Change merge_where() and merge_or_where() to ignore empty tuples so that ↵ | Bharat Mediratta | |
| chaining is easier. | |||
| 2010-01-08 | Allow the "name" param in get() so that you can restrict the query to ↵ | Bharat Mediratta | |
| children with a given name. | |||
| 2010-01-08 | Change url parsing in resolve() to ignore the query string. | Bharat Mediratta | |
| 2010-01-08 | Fix for ticket #933. Move the inclusion of the piclens script from the ↵ | Tim Almdal | |
| theme::header callback to the theme::page_bottom callback. | |||
| 2010-01-07 | Use rawurlencode to remove any encoding that the browser may have added. ↵ | Tim Almdal | |
| Fixes ticket #954. | |||
| 2010-01-07 | remove unused calculation of max-age | Tim Almdal | |
| 2010-01-07 | Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev | Bharat Mediratta | |
| 2010-01-06 | Merge branch 'master' of git@github.com:gallery/gallery3 | Bharat Mediratta | |
| 2010-01-06 | Convert ORM::in() to ORM::where(.., "IN", ..) for K24 compatibility. | Bharat Mediratta | |
| 2010-01-06 | Typo when reapply the patch for Kohana ticket #2477 | Tim Almdal | |
| 2010-01-06 | Correct the controller_auth_data golden file to reflect that the csrf is not ↵ | Tim Almdal | |
| longer considered dirty in the logout controller. | |||
| 2010-01-06 | Updated Kohana to r4737 | Tim Almdal | |
| 2010-01-06 | Provide an error message when the sql in installer::empty_db fails. Also ↵ | Tim Almdal | |
| change the show tables not to specify a database as it will use the database in the active connection. Fixes ticket #963. | |||
| 2010-01-05 | Improve REST tag support. | Bharat Mediratta | |
| - Add support for retrieving a list of members from a collection - Implement put(), post() and delete() for tags. - Use tag_rest::delete() as a way to remove members from the tag collection | |||
| 2010-01-05 | $offset should be null by default, not 0. Hold over bug from the K24 migration. | Bharat Mediratta | |
| 2010-01-05 | $offset should be null by default, not 0. Hold over bug from the K24 migration. | Bharat Mediratta | |
| 2010-01-04 | Further progress on refining the REST server side code. | Bharat Mediratta | |
| 1) Deal in fully qualified URL resources through the rest interface. All rest methods are now passed the complete url in request->url. 2) Create rest::resolve() which lets individual resource definition code convert a full url into the appropriate matching resource. Implement gallery_rest::resolve() and tag_rest::resolve() 3) Reimplement tag_rest's get() and post() methods. They're much simpler now. 4) Implement the tags_rest helper which supports working with the entire tags collection. | |||
| 2010-01-04 | Merge branch 'master' of git@github.com:gallery/gallery3 | Bharat Mediratta | |
| 2010-01-04 | Fix the logout link to send you back to the current url. The old | Bharat Mediratta | |
| approach depended on having an $item, which is not the case on all pages (eg: tag pages). Also, check the CSRF in the logout controller, else you can use the logout link as a blind forwarder. | |||
| 2010-01-04 | Change uppercase NULL to lowercase null to match the gallery3 style guide | Tim Almdal | |
| 2010-01-04 | Another K2.4 holder over... We had, when checking for position, ->where(, ↵ | Tim Almdal | |
| "=", NULL) which would never find any. It should have been ->where(, "is", NULL) | |||
| 2010-01-04 | Send an empty Pragma header and use the item-updated time in the ↵ | Tim Almdal | |
| last-modified header | |||
| 2010-01-04 | Apply patch for Kohana ticket #2477 | Tim Almdal | |
