summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-06-19Updated for comment REST relationships.Bharat Mediratta
2010-06-19$request->params might not exist.Bharat Mediratta
2010-06-19post_test() should be using admin, not guest.Bharat Mediratta
2010-06-19$response is optional in the Rest_Exception constructor.Bharat Mediratta
2010-06-19Throw exceptions as appropriate, but allow the Kohana exceptionBharat Mediratta
handling framework to handle the exception and delegate to our template, which will JSON encode the response.
2010-06-19Rework our exception framework to fit into Kohana's model better.Bharat Mediratta
Instead of overwriting Kohana_Exception::handle() (which we were doing in MY_Kohana_Exception) we instead use their existing template system. gallery/views/kohana/error.php overrides system/views/kohana/error.php and is the standard error template for all exceptions. Our version of error.php figures out the appropriate view based on context (cli, authenticated admin, guest viewing a 404, guest viewing a system error) and delegates appropriately. Each delegated view has a narrow responsibility. This paves the way for us to add new error views per module. For example, the rest module will define its own template in Rest_Exception and then its exceptions can be rendered the way that it wants (json encoded, in that case).
2010-06-19single -> double quotes.Bharat Mediratta
2010-06-19Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2010-06-19Oops. Fix up a bad instance of $user in rest::access_key() introducedBharat Mediratta
in my last change.
2010-06-18Merge branch 'master' of git@github.com:gallery/gallery3Tim Almdal
2010-06-18Fix an issue that the root album was not being selected if there was noTim Almdal
children, or if organize was being invoked on the root album.
2010-06-18Simplify rest::get_access_key($user) to rest::access_key() thatBharat Mediratta
returns just the access key string for the active user. That's how we use the API, so keep it simple.
2010-06-18change single to double quotes.Bharat Mediratta
2010-06-181) Change how the size of the flexstage is calculated. (Basically remove theTim Almdal
dialogWidth and dialogHeight and adjsut the internal controls when added to the stage. 2) Cleanup the controller code
2010-06-18Update the installer/install.sql properly.Tim Almdal
2010-06-18Use request::protocol()Bharat Mediratta
2010-06-18Use request::protocol().Bharat Mediratta
2010-06-18Use request::protocol().Bharat Mediratta
2010-06-18Undo "else" clause -- we should keep the logic simple and easy toBharat Mediratta
follow, even if it's redundant. Expand a <ul> to multiple lines.
2010-06-18Fix ticket #1155. For compatibility with gallery2 increase the size of the ↵Tim Almdal
tag name field from 64 bytes to 128 bytes.
2010-06-17Remove duplicate trailing slash on the controllerUri parameterTim Almdal
2010-06-17Fix for ticket #1163. Don't all guests to a comment when there are no ↵Tim Almdal
comments and the comment access permission is register users.
2010-06-17Update the xss gold file with changes to views in the last couple of commits.Tim Almdal
2010-06-17Rearrange the adding of fields to the template so that they match the order ↵Tim Almdal
of appearance in the template. Also remove the @todo's
2010-06-17Add a cache-buster to the SWF url so that it'll refresh in the browserBharat Mediratta
every time the SWF file changes.
2010-06-17Fix for ticket #1110. Need to use the encode_path with a movie extension to ↵Tim Almdal
find the item. Thanks to samdavidoff for the initial fix.
2010-06-17Fix for ticket #1117 align videos to the center.Tim Almdal
2010-06-17Add the theme::resize_top and theme::resize_bottom to the movie view to be ↵Tim Almdal
consistent with the photo view.
2010-06-17Scale a movie to the resize size so that it doesn't overflow into the sidebar.Tim Almdal
2010-06-17Change the add album dialog to not replace the internet address or name ↵Tim Almdal
fields if they already contain values.
2010-06-16Remove comment_rest::post() -- that's in comments_rest now.Bharat Mediratta
2010-06-16Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2010-06-16Add REST support for comments. You can view, add, edit and deleteBharat Mediratta
comments.
2010-06-16Fix a typo... The controller parameter to the flex organize module should be ↵Tim Almdal
controllerUri instead.
2010-06-16Add start/num query parameters to tags::get()Bharat Mediratta
2010-06-16If the G2 orderBy or orderDirection fields are blank, use the G2 defaults.Bharat Mediratta
Second half of fix for #1054.
2010-06-16Fix a bug introduced in 1077477a9032d5a4855e19e2dd4ce923472b711c whereBharat Mediratta
we don't generate album highlights correctly. Possible fix for #1054.
2010-06-16Fix two bugs:Bharat Mediratta
#1161: guest comments get dropped because of a missing email address. #1075: G2 comments with " get turned into &quot;
2010-06-16Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2010-06-16slap my wrist... i forgot a debugging statementTim Almdal
2010-06-16Fix for ticket #1131. If the rss feed is for an item, then retrieve the ↵Tim Almdal
item. Using the left and right pointers find all the comments for the child items. Thanks to jankoprowski for the initial investigation.
2010-06-16Fix issue1068. Fill from_id field in photo with indetificatorJan Koprowski
2010-06-15Revert "Add a "convert_ids" parameter to Item_Model::as_restful_array(), which"Bharat Mediratta
This reverts commit 98fce83de5f772482382bfabdbcd94c25ecdbb1a. Conflicts: modules/gallery/tests/Item_Model_Test.php
2010-06-15Guard against relationships() not returning an array.Bharat Mediratta
2010-06-15Revert "Change the item rest update processing to call theBharat Mediratta
item::move(source, target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move." Rolling this back for a couple of reasons: 1) Bug in move.php ("message.info" is not a function name) 2) Having the message come back from the API call as a side-effect is sloppy. We should find a cleaner way to do this checking. 3) having item::move() call save() on any changed values in the ORM is counter-intuitive. Move should move, save should save. I think the right approach here is to roll the move() code properly into save(). This reverts commit 2492280cc0ec9eb64a8daeccc7b5698ece7fea66.
2010-06-15Revert "Fix for ticket #1118. Create a item::save_with_retries helperBharat Mediratta
method, which encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly." Rolled this back because it fails KISS. We already have an API for saving models with Item_Model::save() that's consistent with all of our other model code. Adding a new way to save items is confusing and inconsistent. This reverts commit 9504f71efcadc7ed27f6f09e5d663e8025bf3b86.
2010-06-15Bump the organize module to version 2, and check to make sure that theBharat Mediratta
REST module is active.
2010-06-15Fix a bug in the upgrader where we weren't bumping the version numberBharat Mediratta
during the upgrade path, so the 2nd stanza (version 2 to version 3) was never getting executed.
2010-06-15Make the "name" column a little wider.Bharat Mediratta
2010-06-15Update the description.Bharat Mediratta