summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-08-29Minor cleanupAndy Staudacher
2009-08-29Update all code to use helper method html::clean(), html::purify(), ... ↵Andy Staudacher
instead of SafeString directly.
2009-08-29Adding html::clean(), ::purify(), etc.Andy Staudacher
2009-08-29Undo url helper changes - url methods no longer return a SafeString.Andy Staudacher
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
2009-08-29XSS fixesAndy Staudacher
2009-08-29L10n fixes for the admin_languages page, and JS/XSS cleanup of the organize ↵Andy Staudacher
views.
2009-08-29Fix link in l10n UI (for SafeString changes)Andy Staudacher
2009-08-29Merge commit 'upstream/master'Andy Staudacher
Conflicts: modules/akismet/views/admin_akismet.html.php modules/comment/helpers/comment_rss.php modules/gallery/helpers/gallery_rss.php modules/gallery/libraries/I18n.php modules/gallery/views/permissions_browse.html.php modules/gallery/views/simple_uploader.html.php modules/info/views/info_block.html.php modules/organize/controllers/organize.php modules/organize/views/organize.html.php modules/organize/views/organize_album.html.php themes/default/views/album.html.php themes/default/views/movie.html.php themes/default/views/photo.html.php
2009-08-29Fixing all detected XSS vectors in PHP->JS code.Andy Staudacher
Xss: Rename UNKNOWN back to DIRTY, JS_XSS to DIRTY_JS. (using a different flag value to highlight potential XSS vectors in JS)
2009-08-29Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-08-29Update status message styles. Lighten backgrounds, don't show background on ↵Chad Kieffer
Admin Maintenance rows, and added gModuleStatus class.
2009-08-29Bugfix: Don't forget to copy the _is_purified_html flag when cloning a ↵Andy Staudacher
SafeString.
2009-08-29Refactor all calls of p::clean() to SafeString::of() and p::purify() to ↵Andy Staudacher
SafeString::purify(). Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
2009-08-29Add more factory methods for convenience:Andy Staudacher
SafeString::purify() and SafeString::of_safe_html(). Removing SafeString::mark_html_safe() since it's no longer needed.
2009-08-29Merge branch 'talmdal_branch' of git@github.com:gallery/gallery3Bharat Mediratta
2009-08-29Add a test for Comment_Model::viewable().Bharat Mediratta
2009-08-29Fix active() to not use user::guest() as the fallback for our Session::get() ↵Bharat Mediratta
call.
2009-08-29Clean up the test and get it working.Bharat Mediratta
2009-08-29Adding SafeString::for_html_attr()Andy Staudacher
2009-08-29Rename $comment_model to $comments.Bharat Mediratta
2009-08-29Fix for 641... extend viewable functionality to comments. Viewable unit test ↵Tim Almdal
is not working.
2009-08-29Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2009-08-29Have url::site() and other methods return a SafeString, just as t() and t2().Andy Staudacher
Benefits: - url::site() is often used in views and we can ensure in the url class that returned strings are indeed safe for use in HTML. Makes the list of vars of unknown safety status shorter. - url::site() is often used as message parameter to t() and t2(). The parameter would be HTML-escaped if it wasn't marked as safe HTML already. Makes the usage simpler / shorter.
2009-08-29Merge branch 'master' of git@github.com:gallery/gallery3jhilden
2009-08-29Fix a bug where organize doesn't properly generate the tree at the root album.Bharat Mediratta
2009-08-29* created new generic "Add" dropdown in the site menu. this should take care ↵jhilden
of ticket #537 * removed start/stop translation menu items from the admin, since they are on the languags admin page now
2009-08-29Standardize the access to the create_random_item methodTim Almdal
2009-08-29Merge branch 'master' of git://github.com/gallery/gallery3Tim Almdal
2009-08-29improved translation interface so that it now can be closed without going to ↵jhilden
the admin
2009-08-29Fix typo in the parameter listTim Almdal
2009-08-29Remove stray blank line.Bharat Mediratta
2009-08-29Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2009-08-29Get rid of the task infrastructure. The multiple requests greatlyBharat Mediratta
slow down simple operations. We may run into problems with more complex operations, but let's only add tasks into the mix when it's clear that we need them.
2009-08-29Adding SafeString which is going to replace p::clean() and p::purify().Andy Staudacher
Refactoring of Xss_Security_Test. t() and t2() return a SafeString instance. TODO: - Update all code to use SafeString where appropriate. - Update golden fole of Xss_Security_Test - Stop reporting CLEAN vars in Xss_Security_Test
2009-08-29Using SafeString in album controller / viewAndy Staudacher
2009-08-29Major refactor of organize:Bharat Mediratta
* Clean up naming conventions for variables in the controller so that we specifically refer to albums with $album_id, etc. * Move complexity for drawing tree out of the controller and into the view. * Simplify task definitions to get rid of extraneous text * Change __PLACEHOLDERS__ to clearly define which is the album and which is the item that we're moving before/after * Remove as many CSS ids as we can from the tree view to keep things simple
2009-08-29Log the actual exception details, before swallowing the exception.Bharat Mediratta
2009-08-28Merge branch 'master' of git@github.com:gallery/gallery3jhilden
2009-08-28improved translations admin interfacejhilden
2009-08-28Fixed issue where button classes and cancel link weren't being re-applied to ↵Chad Kieffer
forms when an open dialog is reloaded.
2009-08-28Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-08-28Button styles and event handlers weren't being applied in dialogs, fixes #669.Chad Kieffer
2009-08-28Fix for #440. Basically add a check that the mysql version is > 5.0.0.Tim Almdal
It was felt that actually listing the requirements might be overwhelming to novice users.
2009-08-28Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-08-28Display the sort order in the Organize dialog, and allow users toBharat Mediratta
change the sort order on the fly.
2009-08-28Make gMessage 100% of the width of its container.Chad Kieffer
2009-08-28Merge branch 'master' of git://github.com/gallery/gallery3Tim Almdal
2009-08-28Fix ticket #591: reCaptcha always on the page.Tim Almdal
1) move creating the "Add a comment" button into the comments.html.php 2) use $.get() to retrieve the comment add form
2009-08-28improved UI for the languages adminjhilden
this should take care of bug #329
2009-08-28Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer