summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-01-17Switch to model based validation approach.Bharat Mediratta
2010-01-17Use test::random_photo_unsaved() instead.Bharat Mediratta
2010-01-17Create xxx_unsaved() versions for the case where you want to tinker with the ↵Bharat Mediratta
item before it gets saved.
2010-01-17Updated for model based validation.Bharat Mediratta
2010-01-17Make set_data_file() chainable.Bharat Mediratta
2010-01-17Make it work with model based validation.Bharat Mediratta
Refactor _get_proxy() out of setup() and into its own helper function.
2010-01-17Add random_photo()Bharat Mediratta
2010-01-17Updated for model based validation.Bharat Mediratta
2010-01-17Updated for model based validation.Bharat Mediratta
2010-01-17Add validation for guest_email and guest_url.Bharat Mediratta
2010-01-17Updated for model based validation.Bharat Mediratta
2010-01-17Add album title in random_album().Bharat Mediratta
2010-01-17Helper class for common test methods (like creating albums, photos,Bharat Mediratta
etc).
2010-01-17Refactor to work with model based validation.Bharat Mediratta
While I'm at it, pull _make_comment() out of setup and only call it on demand; this makes the tests run faster.
2010-01-17Add special output support for ORM_Validation_ExceptionBharat Mediratta
2010-01-17Use an empty password for the guest user.Bharat Mediratta
2010-01-17Qualify the Bad Request output when the name is missingBharat Mediratta
2010-01-17Catch ORM_Validation_Exception and turn it into a 400 Bad Request withBharat Mediratta
appropriate error output.
2010-01-17Get rid of internal_only designation -- it's too hard to enforce cleanly.Bharat Mediratta
2010-01-17Remove a @todo.Bharat Mediratta
2010-01-17Remove unnecessary comment.Bharat Mediratta
2010-01-17Special case output for ORM_Validation_ExceptionsBharat Mediratta
2010-01-17If we call original() and there's no $original yet, then consider thisBharat Mediratta
to be the original. That should be safe because we're already guarding __set, __unset and save.
2010-01-17Adjust installers to work with model based validation.Bharat Mediratta
2010-01-17Move model rules down into their validate() function for consistency.Bharat Mediratta
Change "in_use" error to "conflict" for consistency.
2010-01-17Move rules down into validate() and improve valid_author().Bharat Mediratta
2010-01-17Move rules entirely down into validate() so that we can be moreBharat Mediratta
sophisticated but keep all our rules in one place. Add rules for most fields.
2010-01-16Use "(string) $form" instead of "$form->__toString()"Bharat Mediratta
2010-01-16Convert comment code over to model based validation.Bharat Mediratta
2010-01-16Get rid of add_rules_from() -- it's no longer necessary now that we're doing ↵Bharat Mediratta
model based validation.
2010-01-16Convert Users_Controller to model based validation.Bharat Mediratta
2010-01-16Convert Admin_Users_Controller, User_Model and Group_Model to useBharat Mediratta
model based validation.
2010-01-16Convert Admin_Users::add_user() to use model based validation. GetBharat Mediratta
the rules and business logic out of the form and user::create(), and move it into User_Model::save().
2010-01-16PHPdoc.Bharat Mediratta
2010-01-16Don't forget to save when we make insignificant chagnes only.Bharat Mediratta
2010-01-16Whitespace.Bharat Mediratta
2010-01-16Whitespace.Bharat Mediratta
2010-01-16Convert Movies_Controller::update() over to model based validation.Bharat Mediratta
2010-01-16Make movie creation use model based validation. Move movie relatedBharat Mediratta
logic from movie::create() into Item_Model
2010-01-16Oops, log::failure() doesn't exist. Use log::error().Bharat Mediratta
2010-01-16Convert Photos_Controller::update() to use model based validation.Bharat Mediratta
2010-01-16Check for illegal extensions in valid_name()Bharat Mediratta
Fix a bug where we were not calling valid_data_file correctly.
2010-01-16Convert photo uploading over to the new model based validationBharat Mediratta
approach. - Rearrange Simple_Uploader_Controller::add_photo() to validate the form early in the process, and switch to using model based validation. - Move thumbnail generation into gallery_event::item_created() so that it's decoupled from the model. - Delete photo::create() and move all of its logic into Item_Model::save(). - Add Item_Model::$data_file to track the data file associated with new movies and photos. - Do some cleanup on the validation callbacks -- it turns out the 2nd argument is the field name not the value.
2010-01-16Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
2010-01-16Remove debug code.Bharat Mediratta
2010-01-16Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_devBharat Mediratta
Conflicts: modules/gallery/models/item.php
2010-01-16Don't pass MY_ORM::original() to update event handlers, since afterBharat Mediratta
parent::save() it'll be reset. Clone it first. This is an alternate fix for #978.
2010-01-16Don't use MY_ORM::original() here since the values may not haveBharat Mediratta
changed since the last save. Instead, use the original ORM passed in.
2010-01-15Revert "Fix for ticket #978. Don't reset the original property as part of ↵Bharat Mediratta
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
2010-01-15Revert "Did the old commit then save trick"Bharat Mediratta
This reverts commit e41ad23a8ea05d28a99d12c01d8f317455b1d361.
generated by cgit v1.2.3 (git 2.46.0) at 2025-10-17 02:41:16 +0000