summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-01-18Coerce some integers to strings now that ORM isn't typecasting anymore.Bharat Mediratta
2010-01-18Coerce some integers to strings now that ORM isn't typecasting anymore.Bharat Mediratta
2010-01-18The root parent id is 0, not null (this deviation exposed by the new lack of ↵Bharat Mediratta
typecasting in ORM).
2010-01-18Don't assert_same() now that typecasting is gone from ORM.Bharat Mediratta
2010-01-18Don't use rand() as the name. Now that ORM::load_types() is gone, itBharat Mediratta
won't get coerced to a string, and then we wind up comparing: 12345 != 12345-12321 In the old approach, they'd both be strings so they'd be inequal. But in the new approach the first value is an integer (sinced it came from rand()) so the second value is typecast to an integer which drops everything after the - sign so they appear equal.
2010-01-18Merge branch 'master' into kohana_updateBharat Mediratta
2010-01-18VerifiedBharat Mediratta
2010-01-18Switch from stdClass to arrays which works around issues caused inBharat Mediratta
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but the solutions are equivalent so I'm not going to dig too far.
2010-01-18Change DENY and ALLOW to "0" and "1" to match the fact that ORM noBharat Mediratta
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18Updated Kohana to r4742Bharat Mediratta
2010-01-18Reload $item after removing view permissions.Bharat Mediratta
2010-01-18Overload url::current() and url::merge() to make the current url XSSBharat Mediratta
safe. Add tests to make sure that it doesn't relapse with future Kohana changes. Fixes ticket #983. Ref: http://gallery.menalto.com/node/93738
2010-01-16Remove debug code.Bharat Mediratta
2010-01-16Don't pass MY_ORM::original() to update event handlers, since afterBharat Mediratta
parent::save() it'll be reset. Clone it first. This is an alternate fix for #978.
2010-01-16Don't use MY_ORM::original() here since the values may not haveBharat Mediratta
changed since the last save. Instead, use the original ORM passed in.
2010-01-15Revert "Fix for ticket #978. Don't reset the original property as part of ↵Bharat Mediratta
the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original." This reverts commit daeaca110d16128040c86727c65df225e957f7c6.
2010-01-15Revert "Did the old commit then save trick"Bharat Mediratta
This reverts commit e41ad23a8ea05d28a99d12c01d8f317455b1d361.
2010-01-13Somemore K24 migration holdovers. need to specify the where statement with ↵Tim Almdal
operands. '=' is no longer assumed. Fixes ticket #979
2010-01-13Did the old commit then save trickTim Almdal
2010-01-13Fix for ticket #978. Don't reset the original property as part of the save ↵Tim Almdal
processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used ->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used ->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original.
2010-01-12Put quotes around the item titles in all the messages and more importantly ↵Tim Almdal
actually display the original's title properly. Fixes ticket #966, but does now show us ticket #978
2010-01-12If the user hits enter in the search text field, then cancel the submission, ↵Tim Almdal
because the search is done in the browser and the the enter will unexpectedly reload the root directory.
2010-01-12Correct the "l10n_client_data[index] is undefined" error.Tim Almdal
2010-01-12Some whitespace and syntax correctsTim Almdal
2010-01-12Add a css id attribute to the i10n-edit-translation element. Fixes ticket #969.Tim Almdal
2010-01-11Reformat the string list so that the search box does not get push off the ↵Tim Almdal
end of the page.
2010-01-11Remove the translation submit button from translation search form. Fixes ↵Tim Almdal
ticket #975
2010-01-11Remove the automatically marking the resizes dirty line as this could cause ↵Tim Almdal
alot of pain to some installations
2010-01-11Fixes ticket #671.Tim Almdal
In the graphics_rules table height and width set the maximum height and width values and should be equal. Initially, the height on the resize target rule was less than the height, which artificially constrained images in portrait mode. **Note"" this fix requires an upgrade to version 22. All the resizes will be flagged dirty.
2010-01-09Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any whereTim Almdal
clauses and deletes all the entries in the table unless an array of id's are passed as the parameter. This fix used the Database_builder to specify any where conditions. Thanks psvo for find the first one. :-)
2010-01-08Remove the display of the "body_attributes" div when in debug mode. debug ↵Tim Almdal
mode is by default set up to add new div's to display the location of the content. "body_attributes" are attributes on the body tag and trying to add content introduces an extra > in the html stream.
2010-01-08Change file proxy to url encode the path components instead of the entire ↵Tim Almdal
path. Otherwise, we will encode the slashes and won't find the item.
2010-01-08Fix for ticket #933. Move the inclusion of the piclens script from the ↵Tim Almdal
theme::header callback to the theme::page_bottom callback.
2010-01-07Use rawurlencode to remove any encoding that the browser may have added. ↵Tim Almdal
Fixes ticket #954.
2010-01-07remove unused calculation of max-ageTim Almdal
2010-01-06Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2010-01-06Convert ORM::in() to ORM::where(.., "IN", ..) for K24 compatibility.Bharat Mediratta
2010-01-06Typo when reapply the patch for Kohana ticket #2477Tim Almdal
2010-01-06Correct the controller_auth_data golden file to reflect that the csrf is not ↵Tim Almdal
longer considered dirty in the logout controller.
2010-01-06Updated Kohana to r4737Tim Almdal
2010-01-06Provide an error message when the sql in installer::empty_db fails. Also ↵Tim Almdal
change the show tables not to specify a database as it will use the database in the active connection. Fixes ticket #963.
2010-01-05$offset should be null by default, not 0. Hold over bug from the K24 migration.Bharat Mediratta
2010-01-04Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2010-01-04Fix the logout link to send you back to the current url. The oldBharat Mediratta
approach depended on having an $item, which is not the case on all pages (eg: tag pages). Also, check the CSRF in the logout controller, else you can use the logout link as a blind forwarder.
2010-01-04Change uppercase NULL to lowercase null to match the gallery3 style guideTim Almdal
2010-01-04Another K2.4 holder over... We had, when checking for position, ->where(, ↵Tim Almdal
"=", NULL) which would never find any. It should have been ->where(, "is", NULL)
2010-01-04Send an empty Pragma header and use the item-updated time in the ↵Tim Almdal
last-modified header
2010-01-04Apply patch for Kohana ticket #2477Tim Almdal
2010-01-02Add rest_controller::__call to the authorized controller methodsTim Almdal
2010-01-02Remove the Rest_Exception::trigger method.Tim Almdal
generated by cgit v1.2.3 (git 2.46.0) at 2025-10-17 07:20:00 +0000