summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-09-212nd attempt at gracefully dealing with sort columns that containBharat Mediratta
nulls. This time around, do a query to determine whether or not the sort column has nulls in it. If it doesn't, then use our comparators as before. There are NULLs in the sort column, so we can't use MySQL comparators. Fall back to iterating over every child row to get to the current one. This can be wildly inefficient for really large albums, but it should be a rare case that the user is sorting an album with null values in the sort column. Fixes #627
2009-09-21Set children_count to 0, photos have no children.Bharat Mediratta
2009-09-21Update the next/previous item calculations to match what we do in photos.phpBharat Mediratta
Force the children_count to be zero, movies have no children. Rename $photo to $movie everywhere.
2009-09-21Add viewable() protection to children() and children_count() calls.Bharat Mediratta
This is not currently necessary (nor is it a security hole) because we don't constrain permissions at the child level in the core, but it makes our security audits easier and will enable the scenario where somebody writes a module to add per-photo permissions.
2009-09-21Fix Item_Model::get_position() so that our sort is stable when the comparisonBharat Mediratta
row has a null value in the sort field. Fix for #627 Note: this changes get_position() to take an Item_Model instead of an id!
2009-09-10Merge branch 'master' of git@github.com:gallery/gallery3Chad Kieffer
2009-09-10Fix breadcrumbs in all dialogs rather than piecemeal.Chad Kieffer
2009-09-10Clean up server add dialog a bit.Chad Kieffer
2009-09-10Clear the Upload queue label from the breadcrumbs in the Add Photos dialog.Chad Kieffer
2009-09-10Put the buttons for album/photo dialogs in their own group in the formBharat Mediratta
so that they appear at the end, after any other groups that other modules add. Thanks Glooper!
2009-09-10Convert a couple of instances of Item_Model::url(array(), true) to ↵Bharat Mediratta
Item_Model::abs_url()
2009-09-10Use abs_url() inside url::redirect() calls so that we don't just windBharat Mediratta
up tacking onto the base url.
2009-09-10Merge branch 'master' of git@github.com:gallery/gallery3Bharat Mediratta
2009-09-10Merge branch 'master' of git@github.com:gallery/gallery3Tim Almdal
2009-09-10Reset the margins when the mouse is over a thumbnail when dragging. When the ↵Tim Almdal
border is displayed then adjust the margin to account for the border. Just hidding the border causes things to move.
2009-09-10Trim the input line to get rid of carriage returns on Windows. FixesBharat Mediratta
ticket #740. Thanks to jankoprowski!
2009-09-10Remove debug code.Bharat Mediratta
2009-09-10Rename "after_installer" to "welcome_message" in the code to make itBharat Mediratta
clearer what its purpose is. Add some spacing in the theme for it so that it's less cramped.
2009-09-10Revert "Update the ui.selectable.js to dev r3202"Tim Almdal
This reverts commit 3f4868aac5d5248d3cd5721601c737bf646f3fc1.
2009-09-10Merge branch 'master' of git@github.com:gallery/gallery3 into talmdal_devTim Almdal
2009-09-10Rename ORM_MPTT::is_descendant() to ORM_MPTT::contains() to make theBharat Mediratta
API a little clearer. Write a test for it, too.
2009-09-10Rename $album to $target in move_to()Bharat Mediratta
2009-09-10A better fix for #741... the original problem was that the source and album ↵Tim Almdal
variables were reversed
2009-09-10Merge branch 'master' into talmdal_devTim Almdal
2009-09-10If the current drop target is not defined, in that we have moved out of the ↵Tim Almdal
range of the current li elements, then assume the drop is occurring at the end of the list items. Fixes #742
2009-09-10Merge branch 'master' of git@github.com:gallery/gallery3 into talmdal_devTim Almdal
2009-09-10Changed the check in organize_Controller::move_to:Tim Almdal
1) check that target and source are not the same. 2) check that the source is not already a child of the target (use to be a descendant) Fixes #741.
2009-09-09Update the ui.selectable.js to dev r3202Tim Almdal
2009-09-09Reformat error messages in dialogs so that they don't overflow in weird ways.Bharat Mediratta
2009-09-08Fix a thinko-- of course we want urls to be the path to the file itself.Bharat Mediratta
2009-09-08Fix line > 100 chars.Bharat Mediratta
2009-09-08Replace two preg_replace() calls with a single trim() call.Bharat Mediratta
2009-09-08Change $this->_photo to just $photoBharat Mediratta
2009-09-08Fix test to support new slug code.Bharat Mediratta
2009-09-08Check for subscribers *before* going through the process of creatingBharat Mediratta
and rendering the email message. Fixes ticket #724.
2009-09-08Change the relative_path_cache and relative_url_cache columns to storeBharat Mediratta
urlencoded data for ease of use when we're dealing with the data. This fixes ticket #569 by not allowing the urls that we put into our RSS feeds to have bad characters in them. We have to convert a path like var/albums/foo/"quotes"/bar.jpg into something like var/albums/foo/%22quotes%22/bar.jpg. If we take the approach of storing native data in the cache, then we have to explode the path, urlencode the bits, and implode it again to avoid escaping the / char. By storing it escaped, we avoid this problem. I believe (but have not tested) that this is more efficient.
2009-09-08Amend the v12 installer to empty out the relative_url_cache andBharat Mediratta
relative_path_cache columns.
2009-09-08Update item::convert_filename_to_slug() to eliminate leading andBharat Mediratta
trailing hyphens.
2009-09-08Actually use the slug when creating new albums (instead of just converting theBharat Mediratta
filename over).
2009-09-08Trim leading and trailing hyphens from the slug.Bharat Mediratta
2009-09-08Remove unused $feed->link.Bharat Mediratta
2009-09-08Minor tweaks to the url refactor.Bharat Mediratta
2009-09-08Move specialized (pretty) url generation back into Item_Model so thatBharat Mediratta
we're not relying on overriding url::site() to do tricks around item urls. This means that you won't get item urls by doing url::site("albums/37"), for example, but it also means that we won't get pretty urls where we don't expect them (like in the action of a <form> element). Incidentally, this will help us move over to using the slug format because if you've got a bad character in a url, the edit forms will now work on it since they'll be id based.
2009-09-08Improve comment.Bharat Mediratta
2009-09-08Update to gallery module v12.Bharat Mediratta
2009-09-07Automagically generate pretty urls for movies, too.Bharat Mediratta
2009-09-07Fix a bug where we were not properly decoding the path in the fallbackBharat Mediratta
code in get_item_from_uri() by using relative_url() instead of relative_path().
2009-09-07Update Item_Model::save() to consider the relative_xxx_cache fields asBharat Mediratta
insignificant, in addition to the view_count field. This means that we won't trigger an event, nor will we adjust the updated field if *only* those fields are changed.
2009-09-071. Actually set the slug to the new value in the controllers.Bharat Mediratta
2. Fix up an issue where we were crashing if there were no conflicting rows 3. Amend Item_Model so that if you change the slug, it flushes the cache for all children
2009-09-07Add the 'Internet Address' field to all items, along with properBharat Mediratta
validation for the fields.