3 files changed, 22 insertions, 22 deletions

diff --git a/modules/gallery/helpers/gallery_task.php b/modules/gallery/helpers/gallery_task.php
index 9ce2c4a0..9edc3acd 100644
--- a/modules/gallery/helpers/gallery_task.php
+++ b/modules/gallery/helpers/gallery_task.php
@@ -45,7 +45,7 @@ class gallery_task_Core {
    * @param Task_Model the task
    */
   static function rebuild_dirty_images($task) {
-    $message = array();
+    $errors = array();
     try {
       $result = graphics::find_dirty_images_query();
       $completed = $task->get("completed", 0);
@@ -63,11 +63,11 @@ class gallery_task_Core {
           $success = graphics::generate($item);
           if (!$success) {
             $ignored[$item->id] = 1;
-            $message[] = t("Unable to rebuild images for '%title'",
-                         array("title" => p::purify($item->title)));
+            $errors[] = t("Unable to rebuild images for '%title'",
+                          array("title" => p::purify($item->title)));
           } else {
-            $message[] = t("Successfully rebuilt images for '%title'",
-                         array("title" => p::purify($item->title)));
+            $errors[] = t("Successfully rebuilt images for '%title'",
+                          array("title" => p::purify($item->title)));
           }
         }
 
@@ -101,13 +101,15 @@ class gallery_task_Core {
       $task->done = true;
       $task->state = "error";
       $task->status = $e->getMessage();
-      $message[] = $e->__toString();
+      $errors[] = $e->__toString();
+    }
+    if ($errors) {
+      $task->log($errors);
     }
-    $task->log($message);
   }
 
   static function update_l10n(&$task) {
-    $message = array();
+    $errors = array();
     try {
       $start = microtime(true);
       $dirs = $task->get("dirs");
@@ -139,8 +141,8 @@ class gallery_task_Core {
           }
         }
 
-        $message[] = $task->status = t2("Finding files: found 1 file",
-                                        "Finding files: found %count files", count($files));
+        $task->status = t2("Finding files: found 1 file",
+                           "Finding files: found %count files", count($files));
 
         if (!$dirs) {
           $task->set("mode", "scan_files");
@@ -165,8 +167,8 @@ class gallery_task_Core {
         }
 
         $total_files = $task->get("total_files");
-        $message[] = $task->status = t2("Scanning files: scanned 1 file",
-                              "Scanning files: scanned %count files", $total_files - count($files));
+        $task->status = t2("Scanning files: scanned 1 file",
+                           "Scanning files: scanned %count files", $total_files - count($files));
 
         $task->percent_complete = 10 + 80 * ($total_files - count($files)) / $total_files;
         if (empty($files)) {
@@ -177,7 +179,7 @@ class gallery_task_Core {
         break;
 
       case "fetch_updates":  // 90% - 100%
-        $message = array_merge($message, l10n_client::fetch_updates());
+        l10n_client::fetch_updates();
         $task->done = true;
         $task->state = "success";
         $task->status = t("Translations installed/updated");
@@ -191,8 +193,10 @@ class gallery_task_Core {
       $task->done = true;
       $task->state = "error";
       $task->status = $e->getMessage();
-      $message[] = $e->__toString();
+      $errors[] = $e->__toString();
+    }
+    if ($errors) {
+      $task->log($errors);
     }
-    $task->log($message);
   }
 }
\ No newline at end of file
diff --git a/modules/gallery/helpers/l10n_client.php b/modules/gallery/helpers/l10n_client.php
index b576b4e1..3460cc65 100644
--- a/modules/gallery/helpers/l10n_client.php
+++ b/modules/gallery/helpers/l10n_client.php
@@ -113,10 +113,6 @@ class l10n_client_Core {
     //   [{key:<key_1>, translation: <JSON encoded translation>, rev:<rev>, locale:<locale>},
     //    {key:<key_2>, ...}
     //   ]
-    $count = count($response);
-    $message[] = t2("Installed 1 new / updated translation message",
-                    "Installed %count new / updated translation messages", $count);
-
     foreach ($response as $message_data) {
       // @todo Better input validation
       if (empty($message_data->key) || empty($message_data->translation) ||
@@ -153,7 +149,6 @@ class l10n_client_Core {
       $entry->translation = $translation;
       $entry->save();
     }
-    return $message;
   }
 
   static function submit_translations() {
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index c7311081..58ac8f18 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -353,11 +353,12 @@ class Item_Model extends ORM_MPTT {
         $this->created = $this->updated;
         $r = ORM::factory("item")->select("MAX(weight) as max_weight")->find();
         $this->weight = $r->max_weight + 1;
-        $created = 1;
+      } else {
+        $send_event = 1;
       }
     }
     parent::save();
-    if (!isset($created)) {
+    if (isset($send_event)) {
       module::event("item_updated", $this);
     }
     return $this;