diff options
Diffstat (limited to 'core')
-rw-r--r-- | core/config/routes.php | 1 | ||||
-rw-r--r-- | core/controllers/item.php | 4 | ||||
-rw-r--r-- | core/controllers/rest.php | 28 |
3 files changed, 17 insertions, 16 deletions
diff --git a/core/config/routes.php b/core/config/routes.php index 567e999e..ea177eda 100644 --- a/core/config/routes.php +++ b/core/config/routes.php @@ -24,7 +24,6 @@ $config['^rest'] = null; $config['^rest/.*'] = null; $config['^(\w+)/(\d+)$'] = '$1/dispatch/$2'; -// @todo The following will need to support query strings. $config['^(\w+)$'] = '$1/index'; $config['^form/(\w+)/(\w+)/(.*)$'] = '$2/form/$3/$1'; diff --git a/core/controllers/item.php b/core/controllers/item.php index 7ee3674b..1113d00f 100644 --- a/core/controllers/item.php +++ b/core/controllers/item.php @@ -21,9 +21,9 @@ class Item_Controller extends REST_Controller { protected $resource_type = "item"; /** - * @see Rest_Controller::_index($query) + * @see Rest_Controller::_index() */ - public function _index($query) { + public function _index() { throw new Exception("@todo Item_Controller::_index NOT IMPLEMENTED"); } diff --git a/core/controllers/rest.php b/core/controllers/rest.php index b2097aaf..30a92b24 100644 --- a/core/controllers/rest.php +++ b/core/controllers/rest.php @@ -24,7 +24,7 @@ * class Comment_Controller extends REST_Controller { * protected $resource_type = "comment"; // this tells REST which model to use * - * public function _index($query) { + * public function _index() { * // Handle GET request to controller root * } * @@ -67,13 +67,9 @@ abstract class REST_Controller extends Controller { if (!$resource->loaded && !$this->request_method() == "post") { return Kohana::show_404(); } - /** - * We're expecting to run in an environment that only supports GET/POST, so expect to tunnel - * PUT/DELETE through POST. - */ - $output_format = $this->input->get("_format", $this->input->post("_format", "html")); + if ($this->request_method() == "get") { - $this->_show($resource, $output_format); + $this->_show($resource, $this->get_output_format()); if (Session::instance()->get("use_profiler", false)) { $profiler = new Profiler(); @@ -115,16 +111,18 @@ abstract class REST_Controller extends Controller { } } - public function index($query_string=null) { - // @todo Convert query string to an array and pass it along to _index() + public function index() { if (request::method() == "post") { return $this->dispatch(null); } - return $this->_index(array()); + return $this->_index(); } /** - * Return HTTP request method taking into consideration PUT and DELETE tunneling through POST. + * We're expecting to run in an environment that only supports GET/POST, so expect to tunnel + * PUT and DELETE through POST. + * + * Returns the HTTP request method taking into consideration PUT/DELETE tunneling. * @todo Move this to a MY_request helper? * @return string HTTP request method */ @@ -140,12 +138,16 @@ abstract class REST_Controller extends Controller { } } + // @todo Figure out a good consistent method of passing the output format to controller methods. + protected function get_output_format() { + return $this->input->get("_format", $this->input->post("_format", "html")); + } + /** * Perform a GET request on the controller root * (e.g. http://www.example.com/gallery3/comments) - * @param array $query name-value pairs from the query string, if any */ - abstract public function _index($query); + abstract public function _index(); /** * Perform a POST request on this resource |